Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mtasaka@ioa.s.u-tokyo.ac.jp QAContact: fedora-package-review@redhat.com
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SPECS/tcd-utils.... SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SRPMS/ Description: TCD Utils includes: * build_tide_db to convert harmonics.txt, offsets.xml, and NAVO formats to harmonics.tcd; * restore_tide_db to generate harmonics.txt and offsets.xml from harmonics.tcd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@free.fr, | |dave@flaterco.com BugsThisDependsOn| |217277
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-26 07:28 EST ------- srpm is: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SRPMS/tcd-utils-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
------- Additional Comments From pertusus@free.fr 2006-11-26 08:09 EST ------- * right name * license right, COPYING included * source match upstream f0d58145520be7eeaf5d78229dae4aa7 tcd-utils-20061120.tar.bz2 * %files right * rpmlint is silent
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |pertusus@free.fr OtherBugsDependingO|163776 |163779 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-11-26 08:48 EST ------- If the mkdir under install required? make install should do this automatically. I take it that this built fine in mock as well.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
Bug 217278 depends on bug 217277, which changed state.
Bug 217277 Summary: Review Request: libtcd - Tide Constituent Database Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217277
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-26 10:34 EST ------- * Rebuild for FE-devel succeeded. * SyncNeeded is requested for FE5/6.
Now I close this bug as CLOSED NEXTRELEASE. Thank you.
(In reply to comment #3)
If the mkdir under install required? make install should do this automatically. I take it that this built fine in mock as well.
It may be unneeded, however, this is my habit...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
------- Additional Comments From pertusus@free.fr 2006-11-26 15:13 EST ------- (In reply to comment #4)
It may be unneeded, however, this is my habit...
If it is unneeded, it is better to leave it out, since less code means better readability and maintainability, and your specs may be used by others as template. Not a blocker, though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-11-27 03:24 EST ------- (In reply to comment #5)
If it is unneeded, it is better to leave it out, since less code means better readability and maintainability, and your specs may be used by others as template. Not a blocker, though.
As newer version (20061127) is released, I will check this version and remove 'mkdir /var/tmp/...' if it is possible (perhaps possible). Thank you, Patrice and Paul.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
------- Additional Comments From pertusus@free.fr 2006-11-27 05:55 EST ------- I sent David a patch about setting CPPFLAGS instead of CXXFLAGS for tideEditor, and he also made that a similar change in tcd-utils. This should remove a warning in configure.
package-review@lists.fedoraproject.org