[Bug 598101] New: Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Summary: Review Request: maven-deploy-plugin - Uploads the
                    project artifacts to the internal remote repository.
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...
SRPM URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...
Description: Uploads the project artifacts to the internal remote repository.

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2219364

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Weinan Li  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|fedora-review?              |

--- Comment #1 from Alexander Kurtakov  2010-06-01 15:15:41 EDT ---
You should not set the fedora-review flag.
It should beset by the reviewer.
I'm taking it now.

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #2 from Alexander Kurtakov  2010-06-01 15:24:07 EDT ---
Things to fix:
* Remove the depmap -it's not needed in koji now
* Use new names of the plugins e.g. maven-javadoc-plugin not
maven2-plugin-javadoc
* You should obsolete/provide  maven2-plugin-deploy
* Please remove the empty line between %changelog and the changelog entry

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #3 from Weinan Li  2010-06-02 00:09:53 EDT ---
- depmap removed
- Use new BRs for some already updated maven components
- obsolete/provide maven2-plugin-deploy
- Remove the empty line between changelog and the changelog entry

Spec URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...
SRPM URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2224090

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #4 from Alexander Kurtakov  2010-06-02 02:48:52 EDT ---
Review:

FIXIT: rpmlint must be run on every package. Output:
maven-deploy-plugin.noarch: W: self-obsoletion maven2-plugin-deploy <= 0:2.0.8 
obsoletes maven2-plugin-deploy = 2.5-2.fc13

If you obsolete with epoch (it's needed because maven2 package has epoch 0),
you should provide with epoch.

maven-deploy-plugin.noarch: W: no-documentation
maven-deploy-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-deploy-plugin

False positives.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8.    
OK: Provides/Obsoletes are good.

FIXIT: URL should be http://maven.apache.org/plugins/maven-deploy-plugin/ not
svn

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #5 from Weinan Li  2010-06-02 04:41:30 EDT ---
- Fix URL
- Add Epoch

Spec URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...
SRPM URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2224389

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #6 from Alexander Kurtakov  2010-06-02 04:55:22 EDT ---
Please remove the Epoch: 0 from the package and just change the Provides line
to be:
Provides:       maven2-plugin-deploy = 0:%{version}-%{release}

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #7 from Weinan Li  2010-06-02 05:48:58 EDT ---
- remove the Epoch section

Spec URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...
SRPM URL:
http://weli.fedorapeople.org/packages/fedora-14/maven-deploy-plugin/maven-de...

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2224553

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Alexander Kurtakov  2010-06-02 07:16:08 EDT ---
Thanks, looks good.

This package is APPROVED.

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #9 from Weinan Li  2010-06-02 07:28:30 EDT ---
New Package CVS Request
=======================
Package Name: maven-deploy-plugin
Short Description: Uploads the project artifacts to the internal remote
repository.
Owners: weli
Branches: 
InitialCC:

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Weinan Li  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

--- Comment #10 from Kevin Fenzi  2010-06-03 16:32:56 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 598101] Review Request: maven-deploy-plugin - Uploads the project artifacts to the internal remote repository.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=598101

Weinan Li  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE