https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Bug ID: 2295134 Summary: Review Request: rust-cidr - IP network and IP host within network types Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rh-bugzilla@pfeister.dev QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/ppfeister/pkg/master/rust-cidr.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora...
Description: This library provides types to represent an IP network (Cidr) or an IP host withing a network (Inet)
Fedora Account System Username: ppfeister
Please confirm that I have handled extras correctly.
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Paul Pfeister rh-bugzilla@pfeister.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2295136
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2295136 [Bug 2295136] Review Request: rust-cidr-utils - Functions for working with IPv4 CIDRs and IPv6 CIDRs
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/ci | |dr
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7697772 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Paul Pfeister rh-bugzilla@pfeister.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2295139
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2295139 [Bug 2295139] Review Request: rustscan - Modern port scanner
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Can you clarify what you mean by "extras"? That term doesn't mean anything wrt/ Rust packages.
However, package looks good to me.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cidr
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
--- Comment #4 from Paul Pfeister rh-bugzilla@pfeister.dev --- "extras" meaning +xyz such as in this case, rust-cidr+bitstring-devel But it seems like we're good to go with those!
Created according to recommended tasks. Thanks for review!
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-ad7671890f (rust-cidr-0.2.3-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad7671890f
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-03 21:38:27
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-ad7671890f (rust-cidr-0.2.3-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Sorry - looks like I messed up the check for the package installability. Not sure how ... but I see you already opened a review request for the "bitstring" crate.
https://bugzilla.redhat.com/show_bug.cgi?id=2295134
--- Comment #8 from Paul Pfeister rh-bugzilla@pfeister.dev --- The fact that bitstring an _optional_ (and unused) dependency is what screwed up my own testing. This is something that I've added to my _list of things to look out for_ in later packages.
package-review@lists.fedoraproject.org