[Bug 2295134] New: Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Bug ID: 2295134
           Summary: Review Request: rust-cidr - IP network and IP host
                    within network types
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://raw.githubusercontent.com/ppfeister/pkg/master/rust-cidr.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/ppfeister/RustScan/fedora...

Description: This library provides types to represent an IP network (Cidr) or
an IP host withing a network (Inet)

Fedora Account System Username: ppfeister

Please confirm that I have handled extras correctly.

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Paul Pfeister  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2295136

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2295136
[Bug 2295136] Review Request: rust-cidr-utils - Functions for working with IPv4
CIDRs and IPv6 CIDRs

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged
                URL|                            |https://crates.io/crates/ci
                   |                            |dr

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7697772
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Paul Pfeister  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2295139

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2295139
[Bug 2295139] Review Request: rustscan - Modern port scanner

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review+
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

--- Comment #2 from Fabio Valentini  ---
Can you clarify what you mean by "extras"? That term doesn't mean anything wrt/
Rust packages.

However, package looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST

--- Comment #3 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-cidr

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

--- Comment #4 from Paul Pfeister  ---
"extras" meaning +xyz
such as in this case, rust-cidr+bitstring-devel
But it seems like we're good to go with those!

Created according to recommended tasks. Thanks for review!

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-2024-ad7671890f (rust-cidr-0.2.3-2.fc41) has been submitted as an update
to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ad7671890f

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2024-07-03 21:38:27

--- Comment #6 from Fedora Update System  ---
FEDORA-2024-ad7671890f (rust-cidr-0.2.3-2.fc41) has been pushed to the Fedora
41 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

--- Comment #7 from Fabio Valentini  ---
Sorry - looks like I messed up the check for the package installability. Not
sure how ... but I see you already opened a review request for the "bitstring"
crate.

[Bug 2295134] Review Request: rust-cidr - IP network and IP host within network types

https://bugzilla.redhat.com/show_bug.cgi?id=2295134

--- Comment #8 from Paul Pfeister  ---
The fact that bitstring an _optional_ (and unused) dependency is what screwed
up my own testing. This is something that I've added to my _list of things to
look out for_ in later packages.