[Bug 701426] New: Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-taboot - Client utility for scripted multi-system administration over Func

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Summary: Review Request: python-taboot - Client utility for
                    scripted multi-system administration over Func
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL: http://people.redhat.com/~tbielawa/taboot/python-taboot.spec
SRPM URL:
http://people.redhat.com/~tbielawa/taboot/releases/taboot-latest/python-tabo...
Description: 
Tool for managing and executing tasks related to software releases and
system administration via customizable YAML scripts. A library of
prewritten tasks is built in so you can get started immediately.

Taboot uses Func for inter-system communication, eliminating hacky ssh
commands and the overhead associated with key management. Taboot can
be extended by writing your Func modules and tasks in Python.

This is my first package here so I will need a sponsor. Thanks!

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Ken Dreyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ken Dreyer  2011-05-04 07:32:18 EDT ---
Welcome Tim! Please block FE-NEEDSPONSOR.
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Tim Bielawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #2 from Tim Bielawa  2011-05-04 09:47:22 EDT ---
Oh man, missed that! I thought I had gotten everything.

It's blocking now. Thanks for the pointer.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Kevin Fenzi  2011-05-04 12:13:05 EDT ---
I'm not sure when I might get to it, but if no one beats me to it I am
interested in reviewing this and sponsoring you. ;) (Other sponsors feel free
to take it before then. :)

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #4 from Tim Bielawa  2011-05-05 11:41:01 EDT ---
Today I released Taboot 0.2.12-1. The specfile listed has been updated to
reflect this.

The new SRPM address is:

http://people.redhat.com/~tbielawa/taboot/releases/taboot-latest/python-tabo...

Side note: I make concurrent releases for el5/el6/FC14. There are SRPMs for el5
and el6 in that directory as well.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #5 from Kevin Fenzi  2011-05-07 15:24:46 EDT ---
ok, I am going to try and get this reviewed this weekend. ;)

Look for a review in a while...

Do you have any other packages you are going to submit at this time?

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #6 from Kevin Fenzi  2011-05-07 15:45:00 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License GPLv3+
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
676c7ef0093bbd43298cedf934420143  python-taboot-0.2.12.tar.gz
676c7ef0093bbd43298cedf934420143  python-taboot-0.2.12.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
See below - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues:

1. Not a blocker, but: There's no need to use macros for things that are longer
than 
the command they replace, ie, %{__make} vs just 'make'. I think the non macro
versions
make the spec more readable, but it's up to you.

2. Both the main package and subpackage require func, so what is the advantage
of 
having the subpackage? I guess to install on clients only?

3. You don't need a clean section if you aren't targeting EPEL (which I hope
you are)
but why the "%{__make} clean" at the top of it?

4. rpmlint says: 
taboot-func.noarch: W: no-documentation
which can be ignored.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #7 from Tim Bielawa  2011-05-07 23:22:00 EDT ---
Kevin, thanks for taking the time to review this!
> Issues:
> Not a blocker, but: There's no need to use macros for things that are longer...

You just cleared something up I've been wondering for a while. I figured the
macros were for compatibility across build targets. But yeah you're right, cp
and rm are probably not going to have any compatibility issues.

I'm going to leave them in though since: 1) they're already there, and 2) the
uniformity makes the %install section look nice and readable.
> Both the main package and subpackage require func, so what is the advantage...

- python-taboot is a client package that you can install on any minion you run
commands from,  your 'command-center' you might say.

- taboot-func is a func module that gets installed on target machines. I'll
update the %description of that, its purpose could be much clearer.

Specifically: taboot-func provides a func interface to the mod_jk API on tomcat
JK balancers. The way we use Taboot now we have 'command center' type host in a
given environment that is granted access to the other minions. From there the
func command would go to a machine and utilize the modjk func module that was
installed by taboot-func.
> You don't need a clean section if you aren't targeting EPEL (which I hope you are) but why
>
> the "%{__make} clean" at the top of it?

That is a very good question. I'll see it's unnecessary and remove it if so.

Yes, I do intend to target EPEL. From the EPEL Package Maintainers Page [0] I
see it says that after this is approved for Fedora I can then go on to request
EPEL branches. What does that require of me exactly?
> Do you have any other packages you are going to submit at this time?

When you asked about taboot-func it reminded me that the modjkapi library needs
to be available too. It's already packaged with a specfile, I just need to
build it and clean out any rpmlint that might show up.

I'll reply to this ticket again as soon as I have another release addressing
the issues you brought up. Also included will be a reference to the modjkapi
library review request.

[0] http://fedoraproject.org/wiki/EPEL_Package_Maintainers

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Tim Bielawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |702892

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #8 from Tim Bielawa  2011-05-08 01:33:38 EDT ---
> Both the main package and subpackage require func, so what is
>
> the advantage...

Description of taboot-func has been updated in this release.
> You don't need a clean section if you aren't targeting EPEL (which I hope
>
> you are) but why the "%{__make} clean" at the top of it?

I removed "make clean" and the world didn't come to an end. It's gone in this
release too.
> Do you have any other packages you are going to submit at this time?

Now blocking this ticket is a review request for python-modjkapi. taboot-func
has been updated to depend on it (it should have been doing that before now
anyway).

Specfile url is the same:
http://people.redhat.com/~tbielawa/taboot/python-taboot.spec

SRPM is now:
http://people.redhat.com/~tbielawa/taboot/releases/taboot-0.2.13/python-tabo...

Thanks for your time Kevin

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|fedora-review?              |fedora-review+

--- Comment #9 from Kevin Fenzi  2011-05-11 15:44:33 EDT ---
I don't see any further blockers here, so this package is APPROVED.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #10 from Tim Bielawa  2011-05-11 21:49:51 EDT ---
New Package SCM Request
=======================
Package Name: python-taboot
Short Description: Client utility for scripted multi-system administration over
Func
Owners: tbielawa
Branches: f14 f15 el5 el6
InitialCC:

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Tim Bielawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #11 from Jason Tibbitts  2011-05-12 12:40:33 EDT ---
Git done (by process-git-requests).

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Tim Bielawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-05-12 16:29:15

--- Comment #12 from Tim Bielawa  2011-05-12 16:29:15 EDT ---
Koji builds complete:

- el5
 - el6
 - f14

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Bug 701426 depends on bug 702892, which changed state.

Bug 702892 Summary: Review Request: python-modjkapi - API for modjk management
https://bugzilla.redhat.com/show_bug.cgi?id=702892

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #13 from Fedora Update System  2011-05-12 16:35:27 EDT ---
python-taboot-0.2.13-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/python-taboot-0.2.13-1.el5

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #14 from Fedora Update System  2011-05-12 16:37:16 EDT ---
python-taboot-0.2.13-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-taboot-0.2.13-1.el6

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #15 from Fedora Update System  2011-05-12 16:54:38 EDT ---
python-taboot-0.2.13-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/python-taboot-0.2.13-1.fc14

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #16 from Fedora Update System  2011-05-24 22:28:55 EDT ---
python-taboot-0.2.13-1.fc14 has been pushed to the Fedora 14 stable repository.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |python-taboot-0.2.13-1.fc14
         Resolution|NEXTRELEASE                 |ERRATA

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #17 from Fedora Update System  2011-06-02 15:03:26 EDT ---
python-taboot-0.2.13-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|python-taboot-0.2.13-1.fc14 |python-taboot-0.2.13-1.el5

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

--- Comment #18 from Fedora Update System  2011-06-02 15:24:22 EDT ---
python-taboot-0.2.13-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

[Bug 701426] Review Request: python-taboot - Client utility for scripted multi-system administration over Func

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701426

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|python-taboot-0.2.13-1.el5  |python-taboot-0.2.13-1.el6