Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226482
Summary: Merge Review: tcp_wrappers Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: twoerner@redhat.com
Fedora Merge Review: tcp_wrappers
http://cvs.fedora.redhat.com/viewcvs/devel/tcp_wrappers/ Initial Owner: twoerner@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226482
jpo@di.uminho.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |jpo@di.uminho.pt
------- Additional Comments From jpo@di.uminho.pt 2007-03-09 15:12 EST ------- Review against tcp_wrappers-7.6-43
Tomas,
The following itens should be fixed/improved: * the post/postun scripts belong to the -libs subpackage * remove the end dots in the summary lines (rpmlint) * the buildroot is not the canonical one * the files timestamps should be preserved (replace "cp" by "install -p mxxx") * replace %defattr(-,root,root) by %defattr(-,root,root,-)
Other * Why is tcpd installed with a 711 mask?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226482
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
------- Additional Comments From jpo@di.uminho.pt 2007-03-30 16:11 EST ------- ping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226482
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium Product|Fedora Extras |Fedora
jpo@di.uminho.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jpo@di.uminho.pt |nobody@fedoraproject.org QAContact|fedora-package- |extras-qa@fedoraproject.org |review@redhat.com | CC| |notting@redhat.com, fedora- | |package-review@redhat.com, | |jpo@di.uminho.pt
------- Additional Comments From jpo@di.uminho.pt 2007-06-28 10:16 EST ------- Reassigning this bug to the component owner.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226482
jpo@di.uminho.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tjanouse@redhat.com
------- Additional Comments From jpo@di.uminho.pt 2007-06-28 10:19 EST ------- Manually reassigning to Tomas Janousek.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/show_bug.cgi?id=226482
tjanouse@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From tjanouse@redhat.com 2007-10-16 06:03 EST ------- Package Change Request ====================== Package Name: tcp_wrappers New Branches: F-8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/show_bug.cgi?id=226482
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-10-16 12:03 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/show_bug.cgi?id=226482
tjanouse@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |
------- Additional Comments From tjanouse@redhat.com 2007-10-16 12:14 EST ------- Thanks for your review and sorry for the delay.
I incorporated your suggestions: http://cvs.fedoraproject.org/viewcvs/rpms/tcp_wrappers/devel/tcp_wrappers.sp... Please note that at least the License field has changed since the time you reviewed it.
The tcpd binary was 711 since/because of this changelog entry:
* Tue May 16 2000 Chris Evans chris@ferret.lmh.ox.ac.uk - Make tcpd mode -rwx--x--x as a security hardening measure
I changed it to 755, since even suid binaries are no longer non-readable.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: tcp_wrappers
https://bugzilla.redhat.com/show_bug.cgi?id=226482
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |426387 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Radek Vokal rvokal@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|rvokal@redhat.com |nobody@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Robert Scheck redhat-bugzilla@linuxnetz.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tjanouse@redhat.com
--- Comment #9 from Robert Scheck redhat-bugzilla@linuxnetz.de 2008-12-28 16:26:19 EDT --- Adding Tomas Janousek on Cc because of being the current maintainer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@redhat.com AssignedTo|nobody@fedoraproject.org |mnowak@redhat.com Flag| |fedora-review?, | |needinfo?(jsafrane@redhat.c | |om)
--- Comment #10 from Michal Nowak mnowak@redhat.com 2009-04-09 09:22:22 EDT --- * tcp_wrappers.src: W: mixed-use-of-spaces-and-tabs (spaces: line 249, tab: line 37)
Sane. Easy.
* tcp_wrappers.x86_64: E: obsolete-on-name
I wonder why tcp_wrappers obsoletes itself, for clean update path is >N-V-R enough when the name is the same, right?
* tcp_wrappers-devel.x86_64: W: summary-not-capitalized tcp_wrappers development libraries and headers * tcp_wrappers-libs.x86_64: W: summary-not-capitalized tcp_wrappers libraries
tcp_wrappers-libs... -> Tcp_wrappers-libs...
* tcp_wrappers-devel.x86_64: W: obsolete-not-provided tcp_wrappers * tcp_wrappers-libs.x86_64: W: obsolete-not-provided tcp_wrappers
preferably dump the whote "Obsoletes" and we are done.
The rest looks good to me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Jan Safranek jsafrane@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jchadima@redhat.com, | |jsafrane@redhat.com Flag|needinfo?(jsafrane@redhat.c | |om) |
--- Comment #11 from Jan Safranek jsafrane@redhat.com 2009-04-09 09:35:31 EDT --- jchadima is current tcp_wrappers owner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(jchadima@redhat.c | |om)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
--- Comment #12 from Michal Nowak mnowak@redhat.com 2009-08-11 09:23:12 EDT --- ping
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Jan F. Chadima jchadima@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag|needinfo?(jchadima@redhat.c | |om) |
--- Comment #14 from Jan F. Chadima jchadima@redhat.com 2010-01-06 05:21:25 EDT --- All requested actios done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226482
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(mnowak@redhat.com | |)
--- Comment #15 from Michal Nowak mnowak@redhat.com 2010-01-06 05:37:26 EDT --- Will get back to this, when I find more time.
package-review@lists.fedoraproject.org