https://bugzilla.redhat.com/show_bug.cgi?id=2105993
Bug ID: 2105993 Summary: Review Request: perl-Data-Constraint - Prototypical value checking Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint-1.203-1.fc37... Description: A constraint is some sort of condition on a datum. This module checks one condition against one value at a time, and I call the thing that checks that condition the "constraint". A constraint returns true or false, and that's it. It should have no side effects, it should not change program flow, and it should mind its own business. Let the thing that calls the constraint figure out what to do with it. I want something that says "yes" or "no" (and I discuss why this needs a fancy module later).
Fedora Account System Username: corsepiu
This package is yet another, so far missing, optional dependency of perl-Type-Tiny.
https://bugzilla.redhat.com/show_bug.cgi?id=2105993
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jplesnik@redhat.com CC| |jplesnik@redhat.com
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok
License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax $ license-fedora2spdx "Artistic 2.0" Artistic-2.0
Description is ok URL and Source0 are ok All tests passed
BuildRequires FIX: Please add build-requires: coreutils - needed for macro %{_fixperms} TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version.
$ rpm -qp --requires perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Class::Prototyped) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) Binary requires are Ok.
$ rpm -qp --provides perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c 1 perl(Data::Constraint) = 1.203 1 perl-Data-Constraint = 1.203-1.fc38 Binary provides are Ok.
$ rpmlint ./perl-Data-Constraint* =========================== rpmlint session starts =========================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok
FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46.
Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file.
Resolution: Not Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2105993
--- Comment #2 from Ralf Corsepius rc040203@freenet.de --- (In reply to Jitka Plesnikova from comment #1)
License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax $ license-fedora2spdx "Artistic 2.0" Artistic-2.0
Done, though I generally disagree with most of the new guidelines.
TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version.
No active Fedora release is using such an old version. => I added this, but I do not see any sense in enforcing it.
FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46.
Done.
Update: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Data-Constraint-1.203-2.fc38...
https://bugzilla.redhat.com/show_bug.cgi?id=2105993
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com ---
License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax $ license-fedora2spdx "Artistic 2.0" Artistic-2.0
-License: Artistic 2.0 +License: Artistic-2.0 Done
BuildRequires FIX: Please add build-requires: coreutils - needed for macro %{_fixperms}
+BuildRequires: coreutils Done
TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version.
-BuildRequires: perl(ExtUtils::MakeMaker) >= 6.64 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Done
FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46.
-%{__perl} Makefile.PL INSTALLDIRS=vendor INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 +%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 Done
The package is in line with Fedora and Perl packaging guide lines.
Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2105993
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Constraint
https://bugzilla.redhat.com/show_bug.cgi?id=2105993
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|ASSIGNED |CLOSED Last Closed| |2022-09-09 12:15:06
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com