https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Bug ID: 1248100 Summary: Review Request: python-qpid - The Apache Qpid Python client library for AMQP. Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: iboverma@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
This review is needed to ubretire a package.
Spec URL: fedpkg co python-qpid git checkout f597e62
SRPM URL: https://kojipkgs.fedoraproject.org//packages/python-qpid/0.32/1.fc23/src/pyt...
Description: The Apache Qpid Python client library for AMQP. Fedora Account System Username: irina
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #1 from Irina Boverman iboverma@redhat.com --- I am removing python bits from qpid-cpp and rebasing both packages to 0.34 upstream. These changes will be made in rawhide and F23.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment| |review? #1059990 Flags| |
--- Comment #2 from Irina Boverman iboverma@redhat.com --- Created attachment 1059990 --> https://bugzilla.redhat.com/attachment.cgi?id=1059990&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #3 from Irina Boverman iboverma@redhat.com --- Created attachment 1059992 --> https://bugzilla.redhat.com/attachment.cgi?id=1059992&action=edit source rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #4 from Irina Boverman iboverma@redhat.com --- Attached revised spec file and source RPM.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1251146
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1251146 [Bug 1251146] Re-organise qpid-cpp package, un-retire python-qpid package, add qpid-tools and qpid-tests packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #6 from Irina Boverman iboverma@redhat.com --- Testing mock build:
$ rpm -q -a | grep qpid qpid-proton-c-0.9-5.fc23.x86_64 rubygem-qpid_messaging-0.32.0-3.fc23.x86_64 perl-qpid-proton-0.9-5.fc23.x86_64 qpid-proton-java-javadoc-0.9-2.fc23.noarch qpid-cpp-client-devel-0.34-1.fc24.x86_64 python-qpid-qmf-0.32-1.fc24.x86_64 qpid-cpp-server-ha-0.34-1.fc24.x86_64 qpid-cpp-server-devel-0.34-1.fc24.x86_64 qpid-qmf-debuginfo-0.32-1.fc24.x86_64 libqpid-dispatch-0.4-3.fc23.x86_64 python-qpid-proton-0.9-5.fc23.x86_64 qpid-proton-c-devel-0.9-5.fc23.x86_64 rubygem-qpid_messaging-doc-0.32.0-3.fc23.noarch qpid-dispatch-tools-0.4-3.fc23.x86_64 qpid-dispatch-router-0.4-3.fc23.x86_64 rubygem-qpid_proton-0.9.0-2.fc23.x86_64 qpid-proton-java-0.9-2.fc23.noarch qpid-proton-c-devel-doc-0.9-5.fc23.noarch python-qpid-proton-doc-0.9-5.fc23.noarch qpid-cpp-server-0.34-1.fc24.x86_64 python-qpid-common-0.32-9.fc24.noarch qpid-qmf-0.32-1.fc24.x86_64 qpid-tools-0.32-9.fc24.noarch qpid-cpp-server-rdma-0.34-1.fc24.x86_64 qpid-qmf-devel-0.32-1.fc24.x86_64 python-qpid-messaging-0.34-1.fc24.x86_64 qpid-cpp-server-linearstore-0.34-1.fc24.x86_64 perl-qpid-messaging-0.34-1.fc24.x86_64 qpid-cpp-debuginfo-0.34-1.fc24.x86_64 libqpid-dispatch-devel-0.4-3.fc23.x86_64 rubygem-qpid_proton-doc-0.9.0-2.fc23.noarch qpid-dispatch-router-docs-0.4-3.fc23.noarch qpid-cpp-client-0.34-1.fc24.x86_64 python-qpid-0.32-9.fc24.noarch qpid-cpp-client-rdma-0.34-1.fc24.x86_64 ruby-qpid-qmf-0.32-1.fc24.x86_64 qpid-cpp-server-xml-0.34-1.fc24.x86_64 qpid-cpp-client-devel-docs-0.34-1.fc24.noarch
$ git clone git://git.apache.org/qpid.git qpid-0.32
$ git checkout -t remotes/origin/0.32 Branch 0.32 set up to track remote branch 0.32 from origin. Switched to a new branch '0.32'
$ cd qpid
[root@mrg19 qpid]# ./python/qpid-python-test qpid.tests.codec.BitTestCase.test_bit1 ..................................................................... pass qpid.tests.codec.BitTestCase.test_bit2 ..................................................................... pass qpid.tests.codec.BitTestCase.test_bit3 ..................................................................... pass qpid.tests.codec.BitTestCase.test_bit_decode_0 ............................................................. pass qpid.tests.codec.BitTestCase.test_bit_decode_1 ............................................................. pass qpid.tests.codec.BooleanTestCase.test_false_decode ......................................................... pass qpid.tests.codec.BooleanTestCase.test_false_encode ......................................................... pass qpid.tests.codec.BooleanTestCase.test_true_decode .......................................................... pass qpid.tests.codec.BooleanTestCase.test_true_encode .......................................................... pass qpid.tests.codec.ContentTestCase.test_content_inline ....................................................... pass qpid.tests.codec.ContentTestCase.test_content_inline_decode ................................................ pass qpid.tests.codec.ContentTestCase.test_content_reference .................................................... pass qpid.tests.codec.ContentTestCase.test_content_reference_decode ............................................. pass qpid.tests.codec.FieldTableTestCase.test_field_table_decode ................................................ pass qpid.tests.codec.FieldTableTestCase.test_field_table_multiple_name_value_pair .............................. pass qpid.tests.codec.FieldTableTestCase.test_field_table_name_value_pair ....................................... pass qpid.tests.codec.IntegerTestCase.test_octet_out_of_upper_range ............................................. pass qpid.tests.codec.IntegerTestCase.test_ulong_int ............................................................ pass qpid.tests.codec.IntegerTestCase.test_ulong_int_decode ..................................................... pass qpid.tests.codec.IntegerTestCase.test_ulong_int_out_of_lower_range ......................................... pass qpid.tests.codec.IntegerTestCase.test_ulong_int_out_of_upper_range ......................................... pass qpid.tests.codec.IntegerTestCase.test_ulong_int_with_fraction .............................................. pass qpid.tests.codec.IntegerTestCase.test_ulong_long_int ....................................................... pass qpid.tests.codec.IntegerTestCase.test_ulong_long_int_decode ................................................ pass qpid.tests.codec.IntegerTestCase.test_ulong_long_int_out_of_lower_range .................................... pass qpid.tests.codec.IntegerTestCase.test_ulong_long_int_out_of_upper_range .................................... pass qpid.tests.codec.IntegerTestCase.test_ulong_long_int_with_fraction ......................................... pass qpid.tests.codec.IntegerTestCase.test_unsigned_octet ....................................................... pass qpid.tests.codec.IntegerTestCase.test_unsigned_octet_decode ................................................ pass qpid.tests.codec.IntegerTestCase.test_uoctet_out_of_lower_range ............................................ pass qpid.tests.codec.IntegerTestCase.test_uoctet_with_fraction ................................................. pass qpid.tests.codec.IntegerTestCase.test_ushort_int ........................................................... pass qpid.tests.codec.IntegerTestCase.test_ushort_int_decode .................................................... pass qpid.tests.codec.IntegerTestCase.test_ushort_int_out_of_lower_range ........................................ pass qpid.tests.codec.IntegerTestCase.test_ushort_int_out_of_upper_range ........................................ pass qpid.tests.codec.IntegerTestCase.test_ushort_int_with_fraction ............................................. pass qpid.tests.codec.ResolveTestCase.test_resolve_64bit_signed_max ............................................. pass qpid.tests.codec.ResolveTestCase.test_resolve_64bit_signed_min ............................................. pass qpid.tests.codec.ResolveTestCase.test_resolve_None ......................................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_above_64bit_signed_max ....................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_below_64bit_signed_min ....................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_float ........................................................ pass qpid.tests.codec.ResolveTestCase.test_resolve_int_1 ........................................................ pass qpid.tests.codec.ResolveTestCase.test_resolve_int_above_signed_32bit_max ................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_int_max ...................................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_int_min ...................................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_int_negative_1 ............................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_long_1 ....................................................... pass qpid.tests.codec.ResolveTestCase.test_resolve_long_above_signed_32bit_max .................................. pass qpid.tests.codec.ResolveTestCase.test_resolve_string ....................................................... pass qpid.tests.codec.StringTestCase.test_long_string_decode .................................................... pass qpid.tests.codec.StringTestCase.test_long_string_positive_length ........................................... pass qpid.tests.codec.StringTestCase.test_long_string_zero_length ............................................... pass qpid.tests.codec.StringTestCase.test_short_string_decode ................................................... pass qpid.tests.codec.StringTestCase.test_short_string_out_of_upper_range ....................................... pass qpid.tests.codec.StringTestCase.test_short_string_positive_length .......................................... pass qpid.tests.codec.StringTestCase.test_short_string_zero_length .............................................. pass qpid.tests.codec.oldTests.test_oldtestcases ................................................................ pass qpid.tests.codec010.CodecTest.testArrayEmpty ............................................................... pass qpid.tests.codec010.CodecTest.testArrayInt ................................................................. pass qpid.tests.codec010.CodecTest.testArrayNone ................................................................ pass qpid.tests.codec010.CodecTest.testArrayString .............................................................. pass qpid.tests.codec010.CodecTest.testDatetime ................................................................. pass qpid.tests.codec010.CodecTest.testInt16 .................................................................... pass qpid.tests.codec010.CodecTest.testInt64 .................................................................... pass qpid.tests.codec010.CodecTest.testList ..................................................................... pass qpid.tests.codec010.CodecTest.testListEmpty ................................................................ pass qpid.tests.codec010.CodecTest.testListNone ................................................................. pass qpid.tests.codec010.CodecTest.testMapAll ................................................................... pass qpid.tests.codec010.CodecTest.testMapBinary ................................................................ pass qpid.tests.codec010.CodecTest.testMapBuffer ................................................................ pass qpid.tests.codec010.CodecTest.testMapDatetime .............................................................. pass qpid.tests.codec010.CodecTest.testMapEmpty ................................................................. pass qpid.tests.codec010.CodecTest.testMapInt ................................................................... pass qpid.tests.codec010.CodecTest.testMapList .................................................................. pass qpid.tests.codec010.CodecTest.testMapLong .................................................................. pass qpid.tests.codec010.CodecTest.testMapNested ................................................................ pass qpid.tests.codec010.CodecTest.testMapNone .................................................................. pass qpid.tests.codec010.CodecTest.testMapString ................................................................ pass qpid.tests.codec010.CodecTest.testMapTimestamp ............................................................. pass qpid.tests.codec010.CodecTest.testMapUUID .................................................................. pass qpid.tests.codec010.CodecTest.testMapUnicode ............................................................... pass qpid.tests.connection.ConnectionTest.test .................................................................. pass qpid.tests.connection.ConnectionTest.testCloseGet .......................................................... pass qpid.tests.connection.ConnectionTest.testCloseListen ....................................................... pass qpid.tests.connection.ConnectionTest.testHeartbeat ......................................................... pass qpid.tests.connection.ConnectionTest.testSync .............................................................. pass qpid.tests.datatypes.MessageTest.testClear ................................................................. pass qpid.tests.datatypes.MessageTest.testGet ................................................................... pass qpid.tests.datatypes.MessageTest.testHas ................................................................... pass qpid.tests.datatypes.MessageTest.testSet ................................................................... pass qpid.tests.datatypes.MessageTest.testSetOnEmpty ............................................................ pass qpid.tests.datatypes.MessageTest.testSetReplace ............................................................ pass qpid.tests.datatypes.RangeTest.testIntersect1 .............................................................. pass qpid.tests.datatypes.RangeTest.testIntersect2 .............................................................. pass qpid.tests.datatypes.RangeTest.testIntersect3 .............................................................. pass qpid.tests.datatypes.RangedSetTest.test .................................................................... pass qpid.tests.datatypes.RangedSetTest.testAddSelf ............................................................. pass qpid.tests.datatypes.RangedSetTest.testEmpty ............................................................... pass qpid.tests.datatypes.RangedSetTest.testMinMax .............................................................. pass qpid.tests.datatypes.SerialTest.test ....................................................................... pass qpid.tests.datatypes.SerialTest.testAdd .................................................................... pass qpid.tests.datatypes.SerialTest.testHash ................................................................... pass qpid.tests.datatypes.SerialTest.testIn ..................................................................... pass qpid.tests.datatypes.SerialTest.testIncr ................................................................... pass qpid.tests.datatypes.SerialTest.testNone ................................................................... pass qpid.tests.datatypes.SerialTest.testSub .................................................................... pass qpid.tests.datatypes.TimestampTest.testAbs ................................................................. pass qpid.tests.datatypes.TimestampTest.testAdd ................................................................. pass qpid.tests.datatypes.TimestampTest.testConversion .......................................................... pass qpid.tests.datatypes.TimestampTest.testNeg ................................................................. pass qpid.tests.datatypes.TimestampTest.testPos ................................................................. pass qpid.tests.datatypes.TimestampTest.testSub ................................................................. pass qpid.tests.datatypes.UUIDTest.test ......................................................................... pass qpid.tests.framing.FrameTest.testEmpty ..................................................................... pass qpid.tests.framing.FrameTest.testMaxChannel ................................................................ pass qpid.tests.framing.FrameTest.testMaxTrack .................................................................. pass qpid.tests.framing.FrameTest.testMaxType ................................................................... pass qpid.tests.framing.FrameTest.testSequence .................................................................. pass qpid.tests.framing.FrameTest.testSingle .................................................................... pass qpid.tests.framing.OpTest.testChannel ...................................................................... pass qpid.tests.framing.OpTest.testCompound ..................................................................... pass qpid.tests.framing.OpTest.testContentTypeHeadersPayloadMT .................................................. pass qpid.tests.framing.OpTest.testControl ...................................................................... pass qpid.tests.framing.OpTest.testEmptyMTSync .................................................................. pass qpid.tests.framing.OpTest.testEmptyPayloadMT ............................................................... pass qpid.tests.framing.OpTest.testEmtpyMT ...................................................................... pass qpid.tests.framing.OpTest.testHeadersEmptyPayloadMT ........................................................ pass qpid.tests.framing.OpTest.testHeadersPayloadMT ............................................................. pass qpid.tests.framing.OpTest.testListCompound ................................................................. pass qpid.tests.framing.OpTest.testMT ........................................................................... pass qpid.tests.framing.OpTest.testMixed ........................................................................ pass qpid.tests.framing.OpTest.testMulti ........................................................................ pass qpid.tests.framing.OpTest.testMultiHeadersEmptyPayloadMT ................................................... pass qpid.tests.framing.OpTest.testMultiHeadersPayloadMT ........................................................ pass qpid.tests.framing.OpTest.testPayloadMT .................................................................... pass qpid.tests.framing.OpTest.testSyncMT ....................................................................... pass qpid.tests.framing.SegmentTest.testEmpty ................................................................... pass qpid.tests.framing.SegmentTest.testInterleaveChannel ....................................................... pass qpid.tests.framing.SegmentTest.testInterleaveTrack ......................................................... pass qpid.tests.framing.SegmentTest.testMaxChannel .............................................................. pass qpid.tests.framing.SegmentTest.testMaxTrack ................................................................ pass qpid.tests.framing.SegmentTest.testMaxType ................................................................. pass qpid.tests.framing.SegmentTest.testSequence ................................................................ pass qpid.tests.framing.SegmentTest.testSingle .................................................................. pass qpid.tests.mimetype.MimeTypeTests.testCaseInsensitivity .................................................... pass qpid.tests.mimetype.MimeTypeTests.testMultipleParams ....................................................... pass qpid.tests.mimetype.MimeTypeTests.testTypeOnly ............................................................. pass qpid.tests.mimetype.MimeTypeTests.testTypeSubtype .......................................................... pass qpid.tests.mimetype.MimeTypeTests.testTypeSubtypeParam ..................................................... pass qpid.tests.mimetype.MimeTypeTests.testTypeSubtypeParamComment .............................................. pass qpid.tests.queue.QueueTest.test_close ...................................................................... pass qpid.tests.queue.QueueTest.test_listen ..................................................................... pass qpid.tests.spec010.SpecTest.testMessageProperties .......................................................... pass qpid.tests.spec010.SpecTest.testMessageSubscribe ........................................................... pass qpid.tests.spec010.SpecTest.testSessionHeader .............................................................. pass qpid.tests.spec010.SpecTest.testXid ........................................................................ pass qpid.tests.util.UtilTest.test_get_client_properties_with_no_provided_values ................................ pass qpid.tests.util.UtilTest.test_get_client_properties_with_provided_value .................................... pass qpid.tests.util.UtilTest.test_get_client_properties_with_provided_value_that_overrides_default ............. pass qpid.tests.util.UtilTest.test_get_spec_recommended_client_properties ....................................... pass qpid.tests.messaging.address.AddressTests.testBadList1 ..................................................... pass qpid.tests.messaging.address.AddressTests.testBadList2 ..................................................... pass qpid.tests.messaging.address.AddressTests.testBadList3 ..................................................... pass qpid.tests.messaging.address.AddressTests.testBadList4 ..................................................... pass qpid.tests.messaging.address.AddressTests.testBadOptions1 .................................................. pass qpid.tests.messaging.address.AddressTests.testBadOptions2 .................................................. pass qpid.tests.messaging.address.AddressTests.testBadOptions3 .................................................. pass qpid.tests.messaging.address.AddressTests.testBadOptions4 .................................................. pass qpid.tests.messaging.address.AddressTests.testBadOptions5 .................................................. pass qpid.tests.messaging.address.AddressTests.testBadOptions6 .................................................. pass qpid.tests.messaging.address.AddressTests.testBadOptions7 .................................................. pass qpid.tests.messaging.address.AddressTests.testBoolean ...................................................... pass qpid.tests.messaging.address.AddressTests.testColon ........................................................ pass qpid.tests.messaging.address.AddressTests.testCommaSubject ................................................. pass qpid.tests.messaging.address.AddressTests.testCommaSubjectOptions .......................................... pass qpid.tests.messaging.address.AddressTests.testDashAlone1 ................................................... pass qpid.tests.messaging.address.AddressTests.testDashAlone2 ................................................... pass qpid.tests.messaging.address.AddressTests.testDashInId1 .................................................... pass qpid.tests.messaging.address.AddressTests.testDashInId2 .................................................... pass qpid.tests.messaging.address.AddressTests.testEmpty ........................................................ pass qpid.tests.messaging.address.AddressTests.testHash ......................................................... pass qpid.tests.messaging.address.AddressTests.testIdNum ........................................................ pass qpid.tests.messaging.address.AddressTests.testIdSpaceNum ................................................... pass qpid.tests.messaging.address.AddressTests.testLeadingDash .................................................. pass qpid.tests.messaging.address.AddressTests.testList1 ........................................................ pass qpid.tests.messaging.address.AddressTests.testList2 ........................................................ pass qpid.tests.messaging.address.AddressTests.testList3 ........................................................ pass qpid.tests.messaging.address.AddressTests.testList4 ........................................................ pass qpid.tests.messaging.address.AddressTests.testMap1 ......................................................... pass qpid.tests.messaging.address.AddressTests.testMap2 ......................................................... pass qpid.tests.messaging.address.AddressTests.testMap3 ......................................................... pass qpid.tests.messaging.address.AddressTests.testNegativeNum .................................................. pass qpid.tests.messaging.address.AddressTests.testNoName ....................................................... pass qpid.tests.messaging.address.AddressTests.testNoNameSlash .................................................. pass qpid.tests.messaging.address.AddressTests.testOptions ...................................................... pass qpid.tests.messaging.address.AddressTests.testOptionsNone .................................................. pass qpid.tests.messaging.address.AddressTests.testOptionsTrailingComma ......................................... pass qpid.tests.messaging.address.AddressTests.testSemiSubject .................................................. pass qpid.tests.messaging.address.AddressTests.testSlashHexEsc1 ................................................. pass qpid.tests.messaging.address.AddressTests.testSlashHexEsc2 ................................................. pass qpid.tests.messaging.address.AddressTests.testSlashHexEsc3 ................................................. pass qpid.tests.messaging.address.AddressTests.testSlashQuote ................................................... pass qpid.tests.messaging.address.AddressTests.testSlashUnicode1 ................................................ pass qpid.tests.messaging.address.AddressTests.testSlashUnicode2 ................................................ pass qpid.tests.messaging.address.AddressTests.testSlashUnicode3 ................................................ pass qpid.tests.messaging.address.AddressTests.testSlashUnicode4 ................................................ pass qpid.tests.messaging.address.AddressTests.testStar ......................................................... pass qpid.tests.messaging.address.AddressTests.testTrailingDash ................................................. pass qpid.tests.messaging.address.AddressTests.testUnbalanced ................................................... pass qpid.tests.messaging.endpoints.AddressErrorTests.testInvalidMode ........................................... pass qpid.tests.messaging.endpoints.AddressErrorTests.testNoSource .............................................. pass qpid.tests.messaging.endpoints.AddressErrorTests.testNoTarget .............................................. pass qpid.tests.messaging.endpoints.AddressErrorTests.testNoneSource ............................................ pass qpid.tests.messaging.endpoints.AddressErrorTests.testNoneTarget ............................................ pass qpid.tests.messaging.endpoints.AddressErrorTests.testUnlexableSource ....................................... pass qpid.tests.messaging.endpoints.AddressErrorTests.testUnlexableTarget ....................................... pass qpid.tests.messaging.endpoints.AddressErrorTests.testUnparseableSource ..................................... pass qpid.tests.messaging.endpoints.AddressErrorTests.testUnparseableTarget ..................................... pass qpid.tests.messaging.endpoints.AddressTests.testAssert1 .................................................... pass qpid.tests.messaging.endpoints.AddressTests.testAssert2 .................................................... pass qpid.tests.messaging.endpoints.AddressTests.testCreateExchange ............................................. pass qpid.tests.messaging.endpoints.AddressTests.testCreateExchangeDirect ....................................... pass qpid.tests.messaging.endpoints.AddressTests.testCreateExchangeTopic ........................................ pass qpid.tests.messaging.endpoints.AddressTests.testCreateQueue ................................................ pass qpid.tests.messaging.endpoints.AddressTests.testDeleteByReceiver ........................................... pass qpid.tests.messaging.endpoints.AddressTests.testDeleteBySender ............................................. pass qpid.tests.messaging.endpoints.AddressTests.testDeleteSpecial .............................................. pass qpid.tests.messaging.endpoints.AddressTests.testIllegalKey ................................................. pass qpid.tests.messaging.endpoints.AddressTests.testLinkBindings ............................................... pass qpid.tests.messaging.endpoints.AddressTests.testLinkName ................................................... pass qpid.tests.messaging.endpoints.AddressTests.testNodeBindingsQueue .......................................... pass qpid.tests.messaging.endpoints.AddressTests.testNodeBindingsTopic .......................................... pass qpid.tests.messaging.endpoints.AddressTests.testReliabilityAtLeastOnce ..................................... pass qpid.tests.messaging.endpoints.AddressTests.testReliabilityUnreliable ...................................... pass qpid.tests.messaging.endpoints.AddressTests.testSubjectDefault ............................................. pass qpid.tests.messaging.endpoints.AddressTests.testSubjectOverride ............................................ pass qpid.tests.messaging.endpoints.AddressTests.testWrongType1 ................................................. pass qpid.tests.messaging.endpoints.AddressTests.testWrongType2 ................................................. pass qpid.tests.messaging.endpoints.AddressTests.testWrongValue ................................................. pass qpid.tests.messaging.endpoints.ConnectionTests.testCheckClosed ............................................. pass qpid.tests.messaging.endpoints.ConnectionTests.testClose ................................................... pass qpid.tests.messaging.endpoints.ConnectionTests.testDetach .................................................. pass qpid.tests.messaging.endpoints.ConnectionTests.testSessionAnon ............................................. pass qpid.tests.messaging.endpoints.ConnectionTests.testSessionNamed ............................................ pass qpid.tests.messaging.endpoints.ConnectionTests.testSimultaneousClose ....................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testAtMostOnce ................................................ pass qpid.tests.messaging.endpoints.ReceiverTests.testAvailable ................................................. pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacity10 ................................................ pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacity100 ............................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacity100Threshold1 ..................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacity10Threshold1 ...................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacity5 ................................................. pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacity5Threshold1 ....................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacityDecrease .......................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacityIncrease .......................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testCapacityUNLIMITED ......................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testDoubleClose ............................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testFetch ..................................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testFetchFromClosedConnection ................................. pass qpid.tests.messaging.endpoints.ReceiverTests.testFetchFromClosedReceiver ................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testFetchFromClosedSession .................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testFetchFromConcurrentCloseConnection ........................ pass qpid.tests.messaging.endpoints.ReceiverTests.testFetchFromConcurrentCloseReceiver .......................... pass qpid.tests.messaging.endpoints.ReceiverTests.testFetchFromConcurrentCloseSession ........................... pass qpid.tests.messaging.endpoints.ReceiverTests.testMode ...................................................... pass qpid.tests.messaging.endpoints.ReceiverTests.testUnreliable ................................................ pass qpid.tests.messaging.endpoints.ReceiverTests.testUnsettled ................................................. pass qpid.tests.messaging.endpoints.SenderTests.testCapacityTimeout ............................................. pass qpid.tests.messaging.endpoints.SenderTests.testEINTR ....................................................... pass qpid.tests.messaging.endpoints.SenderTests.testSendAsyncCapacity0 .......................................... pass qpid.tests.messaging.endpoints.SenderTests.testSendAsyncCapacity1 .......................................... pass qpid.tests.messaging.endpoints.SenderTests.testSendAsyncCapacity5 .......................................... pass qpid.tests.messaging.endpoints.SenderTests.testSendAsyncCapacityUNLIMITED .................................. pass qpid.tests.messaging.endpoints.SenderTests.testSendList .................................................... pass qpid.tests.messaging.endpoints.SenderTests.testSendMap ..................................................... pass qpid.tests.messaging.endpoints.SenderTests.testSendString .................................................. pass qpid.tests.messaging.endpoints.SessionTests.testAcknowledge ................................................ pass qpid.tests.messaging.endpoints.SessionTests.testAcknowledgeAsync ........................................... pass qpid.tests.messaging.endpoints.SessionTests.testAcknowledgeAsyncAckCap0 .................................... pass qpid.tests.messaging.endpoints.SessionTests.testAcknowledgeAsyncAckCap1 .................................... pass qpid.tests.messaging.endpoints.SessionTests.testAcknowledgeAsyncAckCap5 .................................... pass qpid.tests.messaging.endpoints.SessionTests.testAcknowledgeAsyncAckCapUNLIMITED ............................ pass qpid.tests.messaging.endpoints.SessionTests.testClose ...................................................... pass qpid.tests.messaging.endpoints.SessionTests.testCommit ..................................................... pass qpid.tests.messaging.endpoints.SessionTests.testCommitAck .................................................. pass qpid.tests.messaging.endpoints.SessionTests.testCommitSend ................................................. pass qpid.tests.messaging.endpoints.SessionTests.testDetachedReceiver ........................................... pass qpid.tests.messaging.endpoints.SessionTests.testDoubleCommit ............................................... pass qpid.tests.messaging.endpoints.SessionTests.testNextReceiver ............................................... pass qpid.tests.messaging.endpoints.SessionTests.testReceiver ................................................... pass qpid.tests.messaging.endpoints.SessionTests.testReject ..................................................... pass qpid.tests.messaging.endpoints.SessionTests.testRelease .................................................... pass qpid.tests.messaging.endpoints.SessionTests.testRollback ................................................... pass qpid.tests.messaging.endpoints.SessionTests.testRollbackAck ................................................ pass qpid.tests.messaging.endpoints.SessionTests.testRollbackSend ............................................... pass qpid.tests.messaging.endpoints.SessionTests.testRxCallback ................................................. pass qpid.tests.messaging.endpoints.SessionTests.testSender ..................................................... pass qpid.tests.messaging.endpoints.SetupTests.testConnectError ................................................. pass qpid.tests.messaging.endpoints.SetupTests.testEstablish .................................................... pass qpid.tests.messaging.endpoints.SetupTests.testGetError ..................................................... pass qpid.tests.messaging.endpoints.SetupTests.testOpen ......................................................... pass qpid.tests.messaging.endpoints.SetupTests.testOpenCloseResourceLeaks ....................................... pass qpid.tests.messaging.endpoints.SetupTests.testOpenFailResourceLeaks ........................................ pass qpid.tests.messaging.endpoints.SetupTests.testOpenReconnectURLs ............................................ pass qpid.tests.messaging.endpoints.SetupTests.testReconnect .................................................... pass qpid.tests.messaging.endpoints.SetupTests.testTcpNodelay ................................................... pass qpid.tests.messaging.endpoints.TimeoutTests.testConnectionClose ............................................ pass qpid.tests.messaging.endpoints.TimeoutTests.testConnectionDetach ........................................... pass qpid.tests.messaging.endpoints.TimeoutTests.testConnectionOpen ............................................. start 2015-08-10 16:51:38,392 WARNING recoverable error[attempt 1]: [Errno -2] Name or service not known 2015-08-10 16:51:38,393 WARNING sleeping 1 seconds 2015-08-10 16:51:39,393 WARNING trying: badhostname:5672 2015-08-10 16:51:39,416 WARNING recoverable error[attempt 2]: [Errno -2] Name or service not known 2015-08-10 16:51:39,417 WARNING sleeping 2 seconds qpid.tests.messaging.endpoints.TimeoutTests.testConnectionOpen ............................................. pass qpid.tests.messaging.endpoints.TimeoutTests.testReceiverClose .............................................. start 2015-08-10 16:51:41,417 WARNING trying: badhostname:5672 qpid.tests.messaging.endpoints.TimeoutTests.testReceiverClose .............................................. pass qpid.tests.messaging.endpoints.TimeoutTests.testSenderClose ................................................ pass qpid.tests.messaging.endpoints.TimeoutTests.testSenderSync ................................................. pass qpid.tests.messaging.endpoints.TimeoutTests.testSessionClose ............................................... pass qpid.tests.messaging.endpoints.TimeoutTests.testSessionSync ................................................ pass qpid.tests.messaging.message.MessageEchoTests.testApplicationProperties .................................... pass qpid.tests.messaging.message.MessageEchoTests.testBooleanEncoding .......................................... pass qpid.tests.messaging.message.MessageEchoTests.testContentTypeUnknown ....................................... pass qpid.tests.messaging.message.MessageEchoTests.testExceptionRaisedMismatchedContentType ..................... pass qpid.tests.messaging.message.MessageEchoTests.testListContent .............................................. pass qpid.tests.messaging.message.MessageEchoTests.testMapContent ............................................... pass qpid.tests.messaging.message.MessageEchoTests.testProperties ............................................... pass qpid.tests.messaging.message.MessageEchoTests.testRecoverAfterException .................................... pass qpid.tests.messaging.message.MessageEchoTests.testReplyTo .................................................. pass qpid.tests.messaging.message.MessageEchoTests.testReplyToQueue ............................................. pass qpid.tests.messaging.message.MessageEchoTests.testReplyToQueueSubject ...................................... pass qpid.tests.messaging.message.MessageEchoTests.testReplyToTopic ............................................. pass qpid.tests.messaging.message.MessageEchoTests.testReplyToTopicSubject ...................................... pass qpid.tests.messaging.message.MessageEchoTests.testStringContent ............................................ pass qpid.tests.messaging.message.MessageEchoTests.testTextPlain ................................................ pass qpid.tests.messaging.message.MessageEchoTests.testTextPlainEmpty ........................................... pass qpid.tests.messaging.message.MessageEchoTests.testUnicodeContent ........................................... pass qpid.tests.messaging.message.MessageTests.testContentTypeOverride .......................................... pass qpid.tests.messaging.message.MessageTests.testCreateList ................................................... pass qpid.tests.messaging.message.MessageTests.testCreateMap .................................................... pass qpid.tests.messaging.message.MessageTests.testCreateString ................................................. pass qpid.tests.messaging.message.MessageTests.testCreateUnicode ................................................ pass qpid.tests.saslmech.finder.SaslFinderTests.test_known_mechansim ............................................ pass qpid.tests.saslmech.finder.SaslFinderTests.test_sasl_mechanism_fallback_without_credentials ................ pass qpid.tests.saslmech.finder.SaslFinderTests.test_sasl_mechanism_with_higher_priority_prefered ............... pass qpid.tests.saslmech.finder.SaslFinderTests.test_sasl_mechansim_options ..................................... pass qpid.tests.saslmech.finder.SaslFinderTests.test_unknown_mechansim .......................................... pass Totals: 342 tests, 342 passed, 0 skipped, 0 ignored, 0 failed
$ cd python/examples/api
$ ./hello Hello world!
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #7 from Irina Boverman iboverma@redhat.com --- Testing using python-qpid-messaging installed bits:
$ rpm -ql python-qpid-messaging /usr/lib64/python2.7/site-packages/_qpid_messaging.so /usr/lib64/python2.7/site-packages/qpid_messaging.py /usr/lib64/python2.7/site-packages/qpid_messaging.pyc /usr/lib64/python2.7/site-packages/qpid_messaging.pyo /usr/share/doc/python-qpid-messaging /usr/share/doc/python-qpid-messaging-0.34/examples /usr/share/doc/python-qpid-messaging-0.34/examples/console /usr/share/doc/python-qpid-messaging-0.34/examples/drain /usr/share/doc/python-qpid-messaging-0.34/examples/hello /usr/share/doc/python-qpid-messaging-0.34/examples/hello_xml /usr/share/doc/python-qpid-messaging-0.34/examples/server /usr/share/doc/python-qpid-messaging-0.34/examples/spout /usr/share/doc/python-qpid-messaging-0.34/examples/statistics.py /usr/share/doc/python-qpid-messaging-0.34/examples/statistics.pyc /usr/share/doc/python-qpid-messaging-0.34/examples/statistics.pyo /usr/share/doc/python-qpid-messaging/LICENSE
$ cd /usr/share/doc/python-qpid-messaging-0.34/examples
$ python hello Hello world!
$ python spout -c 5 'my-queue;{create:always}'
Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:0'}, content_type='text/plain', content='') Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:1'}, content_type='text/plain', content='') Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:2'}, content_type='text/plain', content='') Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:3'}, content_type='text/plain', content='') Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:4'}, content_type='text/plain', content='')
$ python drain 'my-queue'
Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:0'}, content_type='text/plain', content='') Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:1'}, content_type='text/plain', content='') Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:2'}, content_type='text/plain', content='') Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:3'}, content_type='text/plain', content='') Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:4'}, content_type='text/plain', content='')
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1059990 is| | obsolete| | Attachment|review? | #1059990 Flags| |
--- Comment #9 from Irina Boverman iboverma@redhat.com --- Created attachment 1061649 --> https://bugzilla.redhat.com/attachment.cgi?id=1061649&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1061649 is| | obsolete| |
--- Comment #10 from Irina Boverman iboverma@redhat.com --- Created attachment 1061651 --> https://bugzilla.redhat.com/attachment.cgi?id=1061651&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1059992 is| | obsolete| |
--- Comment #11 from Irina Boverman iboverma@redhat.com --- Created attachment 1061654 --> https://bugzilla.redhat.com/attachment.cgi?id=1061654&action=edit source rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #12 from Irina Boverman iboverma@redhat.com --- Created attachment 1061657 --> https://bugzilla.redhat.com/attachment.cgi?id=1061657&action=edit Results of the fedora-review tool
$ fedora-review -n python-qpid INFO: Processing local files: python-qpid INFO: Getting .spec and .srpm Urls from : Local files in /home/iboverma/python-qpid INFO: --> SRPM url: file:///home/iboverma/python-qpid/python-qpid-0.32-9.fc24.src.rpm INFO: --> Spec url: file:///home/iboverma/python-qpid/python-qpid.spec INFO: Using review directory: /home/iboverma/python-qpid/review-python-qpid INFO: Downloading (Source0): http://www.apache.org/dyn/closer.cgi/qpid/0.32/qpid-python-0.32.tar.gz INFO: Running checks and generating report INFO: Results and/or logs in: /home/iboverma/python-qpid/review-python-qpid/results INFO: Build completed INFO: Installing built package(s) INFO: Active plugins: Python, Generic, Shell-api INFO: Starting new HTTPS connection (1): admin.fedoraproject.org INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag
Review template in: /home/iboverma/python-qpid/review-python-qpid/review.txt fedora-review is automated tool, but *YOU* are responsible for manually reviewing the results and finishing the review. Do not just copy-paste the results without understanding them.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #13 from Alan Conway aconway@redhat.com --- Created attachment 1061750 --> https://bugzilla.redhat.com/attachment.cgi?id=1061750&action=edit fedora-review files
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: =======
Noted by aconway ----------------
- /usr/bin/qpid-python-test is not a user executable, don't package or package under libexec.
Summary of fedora-review failed manual checks ---------------------------------------------
MUST [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site-packages/qpid aconway: I think this directory should be owned by the python-qpid package?
SHOULD [!]: Package does not include license text files separate from upstream. aconway: LICENSE.txt is not from upstream, but I don't see why this is an issue. [!]: %check is present and all tests pass. aconway: there's no %check. Manual tests look OK.
fedora-review automatic issues ------------------------------
- Package contains BR: python2-devel or python3-devel - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/aconway/tmp/review/review-python-qpid/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/acls/name/python-qpid See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Packag...
===== MUST items =====
Generic: [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache (v2.0)". Detailed output of licensecheck in /home/aconway/tmp/review/review-python-qpid/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site-packages/qpid [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [X]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [X]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package (aconway: does not apply to python libraries) [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [X]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- qpid-common OK: main package depends on subpackage, not vice-versa.
[X]: Package functions as described. [X]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [X]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-qpid-0.32-2.fc22.noarch.rpm python-qpid-common-0.32-2.fc22.noarch.rpm python-qpid-0.32-2.fc22.src.rpm python-qpid.noarch: W: no-manual-page-for-binary qpid-python-test python-qpid-common.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- python-qpid.noarch: W: no-manual-page-for-binary qpid-python-test python-qpid-common.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Requires -------- python-qpid (rpmlib, GLIBC filtered): /usr/bin/env /usr/bin/python python(abi) python-qpid-common python-saslwrapper
python-qpid-common (rpmlib, GLIBC filtered): /usr/bin/env python(abi)
Provides -------- python-qpid: python-qpid
python-qpid-common: python-qpid-common
Source checksums ---------------- http://www.apache.org/dyn/closer.cgi/qpid/0.32/qpid-python-0.32.tar.gz : CHECKSUM(SHA256) this package : 646bb803907681f64dbe831cb1664d2ec8936c3759548f721b9a7c349f740d26 CHECKSUM(SHA256) upstream package : b3b9a3cf9be1f55a4f6ad028c30736f7888cb82dbc13f68846554ebe7c0b30f6 diff -r also reports differences
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n python-qpid Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |aconway@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1061651 is| | obsolete| |
--- Comment #14 from Irina Boverman iboverma@redhat.com --- Created attachment 1062162 --> https://bugzilla.redhat.com/attachment.cgi?id=1062162&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1061654 is| | obsolete| |
--- Comment #15 from Irina Boverman iboverma@redhat.com --- Created attachment 1062163 --> https://bugzilla.redhat.com/attachment.cgi?id=1062163&action=edit source rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1061657 is| | obsolete| |
--- Comment #16 from Irina Boverman iboverma@redhat.com --- Created attachment 1062166 --> https://bugzilla.redhat.com/attachment.cgi?id=1062166&action=edit Results of the fedora-review tool
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1062162 is| | obsolete| |
--- Comment #18 from Irina Boverman iboverma@redhat.com --- Created attachment 1062220 --> https://bugzilla.redhat.com/attachment.cgi?id=1062220&action=edit Package spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1062163 is| | obsolete| |
--- Comment #19 from Irina Boverman iboverma@redhat.com --- Created attachment 1062221 --> https://bugzilla.redhat.com/attachment.cgi?id=1062221&action=edit source rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1062166 is| | obsolete| |
--- Comment #20 from Irina Boverman iboverma@redhat.com --- Created attachment 1062222 --> https://bugzilla.redhat.com/attachment.cgi?id=1062222&action=edit Results of the fedora-review tool
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #22 from Alan Conway aconway@redhat.com --- PASS
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package contains BR: python2-devel or python3-devel - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/aconway/tmp/review /review-python-qpid/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/acls/name/python-qpid See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Packag...
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache (v2.0)". Detailed output of licensecheck in /home/aconway/tmp/review/review-python-qpid/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- qpid-common [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-qpid-0.32-9.fc24.noarch.rpm python-qpid-common-0.32-9.fc24.noarch.rpm python-qpid-0.32-9.fc24.src.rpm python-qpid-common.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- python-qpid-common.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- python-qpid (rpmlib, GLIBC filtered): python(abi) python-qpid-common python-saslwrapper
python-qpid-common (rpmlib, GLIBC filtered): /usr/bin/env python(abi)
Provides -------- python-qpid: python-qpid
python-qpid-common: python-qpid-common
Source checksums ---------------- http://www.apache.org/dyn/closer.cgi/qpid/0.32/qpid-python-0.32.tar.gz : CHECKSUM(SHA256) this package : 646bb803907681f64dbe831cb1664d2ec8936c3759548f721b9a7c349f740d26 CHECKSUM(SHA256) upstream package : 198e156ef6115a82b665a3918b83b797bc0a17385641af491423a679118eace7 diff -r also reports differences
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n python-qpid Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Alan Conway aconway@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1061750 is| | obsolete| |
--- Comment #23 from Alan Conway aconway@redhat.com --- Created attachment 1066400 --> https://bugzilla.redhat.com/attachment.cgi?id=1066400&action=edit fedora-review files
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Alan Conway aconway@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #25 from Jon Ciesla limburgher@gmail.com --- Now SCM request present.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com Flags| |needinfo?(limburgher@gmail. | |com)
--- Comment #26 from Irina Boverman iboverma@redhat.com --- I am not sure if this package has been "unretired" or not, the master still has this, but the flag (fedora-cvs) has been removed...
$ ls dead.package
$ git status # On branch master
What is suppose to happen next?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #28 from Jon Ciesla limburgher@gmail.com --- Looks unretired now.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(limburgher@gmail. | |com) |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
--- Comment #32 from Jon Ciesla limburgher@gmail.com --- This is unretired. You should be able to commit changes to the git repo.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |apevec@gmail.com, | |iboverma@redhat.com Flags| |needinfo?(iboverma@redhat.c | |om)
--- Comment #33 from Alan Pevec apevec@gmail.com --- python-qpid is still not available in Fedora Rawhide repo, please rebuild it in fc24 target
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(iboverma@redhat.c | |om) |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Irina Boverman iboverma@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Till Maas opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment #21 is|1 |0 private| | Comment #31 is|1 |0 private| | Comment #17 is|1 |0 private| | Comment #35 is|1 |0 private| | Comment #30 is|1 |0 private| | Comment #5 is|1 |0 private| | Comment #24 is|1 |0 private| | Comment #27 is|1 |0 private| | Comment #8 is|1 |0 private| | Comment #34 is|1 |0 private| | Comment #29 is|1 |0 private| | CC| |vondruch@redhat.com
--- Comment #36 from Vít Ondruch vondruch@redhat.com --- @Irina
Please don't make the comments private. There is nothing secrete in them and somebody could be prevented from seeing them.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100
Alan Conway aconway@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |EOL Last Closed| |2016-04-07 11:33:46
package-review@lists.fedoraproject.org