Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libbind - ISC's standard resolver library
https://bugzilla.redhat.com/show_bug.cgi?id=483620
Summary: Review Request: libbind - ISC's standard resolver library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: atkac@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://atkac.fedorapeople.org/libbind.spec SRPM URL: http://atkac.fedorapeople.org/libbind-6.0-0.1.b1.fc11.src.rpm
libbind was part of bind package but upstream has splitted libbind to separate tarball. Thus it makes sence to split it to separate package.
Note about man pages - most of them currently conflict with glibc's manual pages so I removed them. (they are same as glibc's)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |dan@danny.cz Flag| |fedora-review?
--- Comment #1 from Dan Horák dan@danny.cz 2009-02-17 06:00:20 EDT --- formal review is here, see the notes below:
OK source files match upstream: 05affb35022128a71d8660b6bcb0b0858a49c330 libbind-6.0b1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK* compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. BAD rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. BAD doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app.
- no need to manually export CFLAGS, the %configure macro takes care of that (rpmbuild --eval %configure) - rpmlint complains a bit libbind-devel.x86_64: W: obsolete-not-provided bind-devel libbind.x86_64: W: obsolete-not-provided bind-libs you should drop the F-7 bits and see https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplaci... for details and/or explain your variant with respect to the guideline libbind.x86_64: W: no-documentation you should include CHANGES, COPYRIGHT and README as %doc libbind.x86_64: W: shared-lib-calls-exit /usr/lib64/libbind.so.4.2.0 exit@GLIBC_2.2.5 IMHO can be ignored - you shouldn't own %{_includedir}/{arpa,net,sys} directories (list only the headers) and rather make a dependency on glibc-headers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
--- Comment #2 from Adam Tkac atkac@redhat.com 2009-02-19 11:01:28 EDT --- Updated files:
http://atkac.fedorapeople.org/libbind.spec http://atkac.fedorapeople.org/libbind-6.0-0.2.b1.fc11.src.rpm
libbind.x86_64: W: obsolete-not-provided bind-libs
Well, I don't think it is wise to put Provides: bind-libs to spec. "Old" bind-libs contained both bind-libs and libbind files. Some libraries have been splitted to libbind but some libraries are still in bind-libs. Due this reason I think we should not provide bind-libs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
--- Comment #3 from Dan Horák dan@danny.cz 2009-02-24 04:28:28 EDT --- few final notes: - the bind-libbind* Provides/Obsoletes can be completely removed, because bind-libbind was present only in F <= 7. - the bind-libs/bind-devel Obsolete should be removed too, because you are only moving one library into a separate package - freeciv, milter-greylist and dnscap should require an update of BuildRequires after importing libbind
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
--- Comment #4 from Adam Tkac atkac@redhat.com 2009-03-03 06:15:39 EDT --- Fixed package + spec: http://atkac.fedorapeople.org/libbind-6.0-0.3.b1.fc11.src.rpm http://atkac.fedorapeople.org/libbind.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Dan Horák dan@danny.cz 2009-03-04 03:10:25 EDT --- All issues are fixed, this package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
Adam Tkac atkac@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Adam Tkac atkac@redhat.com 2009-03-04 04:21:47 EDT --- New Package CVS Request ======================= Package Name: libbind Short Description: ISC's standard resolver library Owners: atkac Branches: devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-03-05 15:10:41 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483620
Adam Tkac atkac@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #8 from Adam Tkac atkac@redhat.com 2009-03-09 12:11:15 EDT --- libbind is in rawhide and all dependant packages are successfully rebuilt.
package-review@lists.fedoraproject.org