https://bugzilla.redhat.com/show_bug.cgi?id=2350482
Bug ID: 2350482 Summary: Review Request: rust-gufo-png - Data structure for PNG images Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-gufo-png.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-gufo-png-0.2.1-1.fc41.src.rpm
Description: Data structure for PNG images.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=129911196
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/gu | |fo-png
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8737288 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |fedora@lecris.me Assignee|nobody@fedoraproject.org |fedora@lecris.me Status|NEW |POST
--- Comment #3 from Cristian Le fedora@lecris.me --- LGTM.
First time I see a license file say literally ``` MPL-2.0 OR LGPL-2.1-or-later ``` Guess it's technically correct though ¯_(ツ)_/¯
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass. (Tests are disabled because of missing test data) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thank you for the review!
First time I see a license file say literally
MPL-2.0 OR LGPL-2.1-or-laterGuess it's technically correct though ¯_(ツ)_/¯
Yes, this confused me too, at first, but the actual license texts are also included as separate files, so ... :shrug:
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gufo-png
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-400fbca948 (rust-g2gen-1.2.0-1.fc43, rust-g2poly-1.2.0-1.fc43, and 4 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-400fbca948
https://bugzilla.redhat.com/show_bug.cgi?id=2350482
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2025-03-21 12:38:56
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-400fbca948 (rust-g2gen-1.2.0-1.fc43, rust-g2poly-1.2.0-1.fc43, and 4 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com