Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rotoscope - A free rotoscoping application.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
Summary: Review Request: rotoscope - A free rotoscoping application. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: yanstadel@googlemail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://freeki.de/fedora/rotoscope.spec SRPM URL: freeki.de/fedora/rotoscope-0.2-1.fc10.src.rpm Description: Rotoscope is a free software rotoscoping application that can be used to give photos a cartoon-like appearance. This is similar to the technique used in movies such as Waking Life and A Scanner Darkly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
Simon Wesp cassmodiah@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cassmodiah@fedoraproject.or | |g Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kalev@smartlink.ee
--- Comment #1 from Kalev Lember kalev@smartlink.ee 2009-03-27 19:55:07 EDT --- Some initial comments:
1) You have a typo in %install section. It should read %{buildroot}, not %{buidroot}.
2) A package should own all the directories it creates, otherwise it will leave empty directories behind when you uninstall it. Change: %{_datadir}/%{name}/%{name}.* to: %{_datadir}/%{name}/
3) remove dot at the end of summary line;
4) NEWS file seems to be empty, so just don't install it;
5) rpmlint complains about mixed-use-of-spaces-and-tabs;
6) in the SRPM file you have execute bit set on both the spec file and the patch;
7) Licence is wrong. It seems to be GPLv2+, not GPLv2 as you have set in the spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(yanstadel@googlem | |ail.com)
--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-04-14 13:02:23 EDT --- Yannik, would you address issues pointed out by Kalev and reupload the new spec/srpm (with Epoch-Version-Release changed)?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-04-26 14:21:41 EDT --- ping again?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-05-10 05:08:04 EDT --- again ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-05-14 11:28:00 EDT --- I will close this bug as NOTABUG if no response is received from the reporter within ONE WEEK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution| |NOTABUG Flag|needinfo?(yanstadel@googlem | |ail.com) |
--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-05-21 12:37:55 EDT --- Once closing.
If someone wants to import this package into Fedora, please file a new review request and mark this bug as a duplicate of the new one.
Thank you!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492165
Tareq Al Jurf taljurf@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |taljurf@fedoraproject.org Resolution|NOTABUG |DUPLICATE
--- Comment #7 from Tareq Al Jurf taljurf@fedoraproject.org 2010-06-03 02:27:06 EDT ---
*** This bug has been marked as a duplicate of bug 599324 ***
package-review@lists.fedoraproject.org