[Bug 1901747] New: Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

Bug ID: 1901747
           Summary: Review Request: python-subprocess-tee - A
                    subprocess.run that works like tee, being able to
                    display output in real time while still capturing it
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://chedi.fedorapeople.org/python-subprocess-tee.spec
SRPM URL:
https://chedi.fedorapeople.org/python-subprocess-tee-0.1.5-1.fc33.src.rpm
Description: A subprocess.run that works like tee, being able to display output
in real time while still capturing it
Fedora Account System Username: chedi

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dan.cermak@cgc-instruments.
                   |                            |com
           Assignee|[e-mail]    |dan.cermak@cgc-instruments.
                   |                            |com
           Doc Type|---                         |If docs needed, set a value

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

--- Comment #1 from [e-mail] ---
- Please consider upgrading your spec to version 0.2.0 (got released two days
ago).
- there is no justification of the patches
- consider replacing everything under %prep with: %autosetup -p1 -n
%{srcname}-%{version}
- the spec file that you linked is different to the one in the srpm (the one
not in the srpm has an additional commented out BuildRequires).

Besides that, looks good to me.

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "*No copyright* Expat
     License". 23 files have unknown license. Detailed output of
     licensecheck in /home/dan/fedora-scm/1901747-python-subprocess-
     tee/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: python3-subprocess-tee-0.1.5-1.fc34.noarch.rpm
          python-subprocess-tee-0.1.5-1.fc34.src.rpm
python3-subprocess-tee.noarch: E: summary-too-long C A subprocess.run that
works like tee, being able to display output in real time while still capturing
it
python3-subprocess-tee.noarch: W: no-documentation
python3-subprocess-tee.noarch: E: zero-length
/usr/lib/python3.9/site-packages/subprocess_tee/py.typed
python-subprocess-tee.src: E: summary-too-long C A subprocess.run that works
like tee, being able to display output in real time while still capturing it
2 packages and 0 specfiles checked; 3 errors, 1 warnings.

Rpmlint (installed packages)
----------------------------
python3-subprocess-tee.noarch: E: summary-too-long C A subprocess.run that
works like tee, being able to display output in real time while still capturing
it
python3-subprocess-tee.noarch: W: no-documentation
python3-subprocess-tee.noarch: E: zero-length
/usr/lib/python3.9/site-packages/subprocess_tee/py.typed
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/subprocess-tee/subprocess-t...
:
  CHECKSUM(SHA256) this package     :
46995b7cc6d3f84f7bcb5921b45e08287c9d26c2bc87b50ae1d4d8b980e29db2
  CHECKSUM(SHA256) upstream package :
46995b7cc6d3f84f7bcb5921b45e08287c9d26c2bc87b50ae1d4d8b980e29db2

Requires
--------
python3-subprocess-tee (rpmlib, GLIBC filtered):
    python(abi)
    python3dist(rich)

Provides
--------
python3-subprocess-tee:
    python-subprocess-tee
    python3-subprocess-tee
    python3.9-subprocess-tee
    python3.9dist(subprocess-tee)
    python3dist(subprocess-tee)

Diff spec file in url and in SRPM
---------------------------------
---
/home/dan/fedora-scm/1901747-python-subprocess-tee/srpm/python-subprocess-tee.spec
 2020-12-21 20:50:30.936907489 +0100
+++
/home/dan/fedora-scm/1901747-python-subprocess-tee/srpm-unpacked/python-subprocess-tee.spec
2020-11-26 00:13:49.000000000 +0100
@@ -24,4 +24,5 @@
 BuildRequires: python3dist(pytest)
 BuildRequires: python3dist(pytest-cov)
+# BuildRequires: python3dist(pytest-plus)
 BuildRequires: python3dist(pytest-xdist)

Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1901747
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: SugarActivity, R, Perl, C/C++, PHP, Java, Haskell, fonts,
Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

--- Comment #2 from chedi toueiti  ---
@dan

first, thanks for taking the time to review this package. I updated the srpm to
be the same as the spec file.

as for the points you mentioned:

1- Unfortunately I can't use the latest version as it requires a newer version
of python-rich (9.5.1) that is not 
currently available in fedora (latest in rawhide is 9.3.0), and a new package
python-enrich (that I'll be submitting 
for review as soon as possible). so for the time being I'll stick to v 0.1.5

2- The patches as necessary for the version python-pytest < 6.1. (the current
version in f33 is 6.0) not having them 
causes the tests to fail.

3- I updated the spec file

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
By saying “there is no justification of the patches,” I believe the reviewer is
not claiming they are not required. Instead, they are trying to say that each
patch should have a comment in the spec file either linking to an upstream bug
report or explaining what the patch does, why it is required, and whether it
will be offered upstream; see
https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatu....

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

--- Comment #4 from chedi toueiti  ---
sorry for the misunderstanding. I've added justifications for the patches.

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+

--- Comment #5 from [e-mail] ---
Looks good now, thanks for your work!

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-subprocess-tee

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

chedi toueiti  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

[Bug 1901747] Review Request: python-subprocess-tee - A subprocess.run that works like tee, being able to display output in real time while still capturing it

https://bugzilla.redhat.com/show_bug.cgi?id=1901747

chedi toueiti  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-07-13 14:17:14