[Bug 1047702] New: Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

Bug ID: 1047702
           Summary: Review Request: tclcl - Tcl/C++ interface
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-1.oji.fc19.src.rpm
Description:
TclCL (Tcl with classes) is a Tcl/C++ interface used by Mash,
vic, vat, rtp_play, ns, and nam. It provides a layer of C++
glue over OTcl.

Fedora Account System Username: moceap

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

Mosaab Alzoubi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1047497 (OTcl)
              Alias|                            |TCLCL

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1047497
[Bug 1047497] Review Request: otcl - MIT Object Tcl

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

Mosaab Alzoubi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1049116 (ns2)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1049116
[Bug 1049116] Review Request: ns2 - The Network Simulator

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

Mosaab Alzoubi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Mosaab Alzoubi  ---
- Resort Descripsions.
- Fix -devel to be arched.
- Decrease %%configure line
- Remove .a library.

-------------------

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-2.fc20.src.rpm

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #2 from Mosaab Alzoubi  ---
- Undo remove library, it's needed by ns2.

-------------------

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-3.fc20.src.rpm

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #3 from Michael Schwendt  ---
> %description devel
> This package contains libraries and header files for
> developing applications that use %{name}.

Currently, the package does not contain any libraries.
> Group: Development/Languages

The group for such development packages is "Development/Libraries".
> %files
> %{_bindir}/*
> %{_libdir}/*

That's a strange place for a static lib.

Also check out:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Librari...

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #4 from Mosaab Alzoubi  ---
Thank You :)

- Fix library to be included in -devel.
- Fix -devel group.

-------------------

Spec URL: http://ojuba.org/oji/SPECS/tclcl.spec
SRPM URL: http://ojuba.org/oji/SRPMS/tclcl-1.20-4.fc20.src.rpm

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #5 from Michael Schwendt  ---
And it would still be a static lib:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Librari...

But let's focus on OTcl first.

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #6 from Michael Schwendt  ---
Lots of hardcoded …/lib paths in tclcl-1.20/conf/configure.in.otcl, so no
surprise it doesn't build on x86_64.

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #7 from Mosaab Alzoubi  ---
- Fix -devel requires.
- Use shared lib instead of static.
- Improving lib locations.

Spec: http://ojuba.org/test/tclcl.spec
Srpm: http://ojuba.org/test/tclcl-1.20-5.oj35.src.rpm

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #8 from Mosaab Alzoubi  ---
- Tweaks:

Spec: http://ojuba.org/test/tclcl.spec
Srpm: http://ojuba.org/test/tclcl-1.20-6.oj35.src.rpm

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Build fails in rawhide, see attached log.

It seems that some private fields in tcl data structures are accessed. Is it
possible that something changed in tcl recently?

[Bug 1047702] Review Request: tclcl - Tcl/C++ interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1047702

--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
Created attachment 1011505
  --> https://bugzilla.redhat.com/attachment.cgi?id=1011505&action=edit
failing build log on rawhide/i386