[Bug 2283678] New: Review Request: rust-metrics-util - Helper types/functions used by the metrics ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Bug ID: 2283678 Summary: Review Request: rust-metrics-util - Helper types/functions used by the metrics ecosystem Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/18bb026c3e9d3de4cfbc75fe... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metr... Description: Dependency for `rust-metrics-exporter-prometheus` -> `atuin` Fedora Account System Username: lecris
rust2rpm.toml ```toml [requires] build = [ "tomcli", ]
[scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ]
[[package.extra-patches]] comments = [ "Relax predicates dependencies", ] file = "rust-metrics-util-0.17.0-Relax_dependency.diff" number = 10 ```
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2283677
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283677 [Bug 2283677] Review Request: rust-metrics-exporter-prometheus - Metrics-compatible exporter for sending metrics to Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2283676, 2240393, 2283679, | |2283681, 2283682, 2283683
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2240393 [Bug 2240393] rust-ordered-float-4.2.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2283676 [Bug 2283676] Review Request: rust-metrics - Lightweight metrics facade https://bugzilla.redhat.com/show_bug.cgi?id=2283679 [Bug 2283679] Review Request: rust-quanta - High-speed timing library https://bugzilla.redhat.com/show_bug.cgi?id=2283681 [Bug 2283681] Review Request: rust-ndarray - N-dimensional array for general elements and for numerics https://bugzilla.redhat.com/show_bug.cgi?id=2283682 [Bug 2283682] Review Request: rust-ndarray-stats - Statistical routines for ArrayBase https://bugzilla.redhat.com/show_bug.cgi?id=2283683 [Bug 2283683] Review Request: rust-sketches-ddsketch - Direct port of the Golang DDSketch implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #1 from Cristian Le fedora@lecris.me --- Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/83dda26784f2c9cbe603473e... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metr... Description: Dependency for `rust-metrics-exporter-prometheus` -> `atuin` Fedora Account System Username: lecris
rust2rpm.toml ```toml [requires] build = [ "tomcli", ]
[scripts.prep] post = [ "# Do not depend on criterion; it is needed only for benchmarks.", "tomcli set Cargo.toml del dev-dependencies.criterion", ]
[package] cargo-toml-patch-comments = [ "- Relax predicates dependencies", "- Bump sketches-ddsketch dependency", ] ```
metrics-util-fix-metadata.diff ``` --- metrics-util-0.17.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ metrics-util-0.17.0/Cargo.toml 2024-07-05T13:11:23.410917+00:00 @@ -119,7 +119,7 @@ default-features = false
[dependencies.sketches-ddsketch] -version = "0.2" +version = "0.3" optional = true default-features = false
@@ -156,10 +156,10 @@ version = "4.2"
[dev-dependencies.predicates-core] -version = "=1.0.5" +version = "1.0.5"
[dev-dependencies.predicates-tree] -version = "=1.0.7" +version = "1.0.7"
[dev-dependencies.quickcheck] version = "1" @@ -175,7 +175,7 @@ version = "0.4"
[dev-dependencies.sketches-ddsketch] -version = "0.2" +version = "0.3"
[dev-dependencies.tracing] version = "0.1" ```
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2283676, which changed state.
Bug 2283676 Summary: Review Request: rust-metrics - Lightweight metrics facade https://bugzilla.redhat.com/show_bug.cgi?id=2283676
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/me | |trics-util
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7712641 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7712864 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2283683, which changed state.
Bug 2283683 Summary: Review Request: rust-sketches-ddsketch - Direct port of the Golang DDSketch implementation https://bugzilla.redhat.com/show_bug.cgi?id=2283683
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #4 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-...
Update to persistent link
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #5 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-...
Bump dependency for ndarray 0.16
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7947949 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2240393, which changed state.
Bug 2240393 Summary: rust-ordered-float-4.2.2 is available https://bugzilla.redhat.com/show_bug.cgi?id=2240393
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2283679, which changed state.
Bug 2283679 Summary: Review Request: rust-quanta - High-speed timing library https://bugzilla.redhat.com/show_bug.cgi?id=2283679
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2283681, which changed state.
Bug 2283681 Summary: Review Request: rust-ndarray - N-dimensional array for general elements and for numerics https://bugzilla.redhat.com/show_bug.cgi?id=2283681
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2283682, which changed state.
Bug 2283682 Summary: Review Request: rust-ndarray-stats - Statistical routines for ArrayBase https://bugzilla.redhat.com/show_bug.cgi?id=2283682
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2318344
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2318344 [Bug 2318344] rust-metrics-0.24.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2253820
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2253820 [Bug 2253820] rust-mockall-0.13.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #7 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-...
Update metrics to 0.18
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8186338 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net
--- Comment #9 from Ben Beasley code@musicinmybrain.net --- Just summarizing the current status for clarity:
DEBUG util.py:459: Problem 1: nothing provides requested (crate(metrics/default) >= 0.24.0 with crate(metrics/default) < 0.25.0~) DEBUG util.py:459: Problem 2: nothing provides requested (crate(mockall) >= 0.13.0 with crate(mockall) < 0.14.0~)
These are bug 2253820 and bug 2318344.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #10 from Ben Beasley code@musicinmybrain.net --- I cloned https://github.com/metrics-rs/metrics, checked out the metrics-util-v0.18.0 tag, patched the dependency on mockall in the top-level Cargo.toml from "0.12" to "0.11", and ran "cargo test" in "metrics-util/". Everything still passed. Then I patched it to "0.13" (the current release) instead, and again successfully compiled and ran the tests.
Therefore, you should just patch the version specification "0.12" for mockall to ">=0.11, <0.14", rather than waiting for a rust-mockall update to be coordinated with other packages that depend on it.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #11 from Ben Beasley code@musicinmybrain.net --- Since rust-metrics is your package, and it is a leaf package (so there is nothing to coordinate), you should just go ahead and update it.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #12 from Ben Beasley code@musicinmybrain.net --- (In reply to Ben Beasley from comment #10)
Then I patched it to "0.13" (the current release) instead, and again successfully compiled and ran the tests.
There is already an upstream PR for this: https://github.com/metrics-rs/metrics/pull/499
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #13 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util.... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-metrics-util/rust-metrics-util-...
Relaxed the mockall dependency to unblock this
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2253820 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2253820 [Bug 2253820] rust-mockall-0.13.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8403805 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678 Bug 2283678 depends on bug 2318344, which changed state.
Bug 2318344 Summary: rust-metrics-0.24.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=2318344
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review+
--- Comment #15 from Fabio Valentini decathorpe@gmail.com --- Package looks good to me. Two minor points:
- Version 0.19.0 is now out, you're packaging 0.18.0. Importing 0.18.0 now and updating to 0.19.0 is fine. - You're already patching Cargo.toml to relax some dependencies, at this point, using both a patch *and* tomcli to drop criterion is a bit weird, I would recommend to add the "drop criterion" bit to the patch too, and drop the tomcli dependency.
I would also greatly appreciate it if you could review one of my pending packages in return.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged 🫤 license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-metrics-util
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #17 from Cristian Le fedora@lecris.me --- Thank you for the review, Fabio. I'll address the minor points after `rust-metrics-exporter-prometheus` is in.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-5aa42836b1 (rust-metrics-util-0.18.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-5aa42836b1
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rust-metrics-util-0.18.0-1. | |fc43
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2025-03-17 08:56:55
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-5aa42836b1 (rust-metrics-util-0.18.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-88b90d626c (rust-metrics-util-0.18.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-88b90d626c
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-88b90d626c (rust-metrics-util-0.18.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-88b90d626c
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-263bfa9908 (rust-metrics-util-0.18.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-263bfa9908
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-e7ea7d7609 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e7ea7d7609` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e7ea7d7609
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-263bfa9908 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-263bfa9908` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-263bfa9908
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-88b90d626c has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-88b90d626c` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-88b90d626c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
amanda amandawalker178@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |amandawalker178@outlook.com
--- Comment #25 from amanda amandawalker178@outlook.com --- Thanks to everyone involved for tracking and moving this package review forward. Great collaboration!
https://bugzilla.redhat.com/show_bug.cgi?id=2283678
ronald59pepper@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ronald59pepper@outlook.com
--- Comment #26 from ronald59pepper@outlook.com --- This bug report highlights a critical issue in Red Hat, showing how certain system behaviors can cause unexpected failures. It’s good to see it documented so the team can investigate and provide a fix https://www.empowerretirement.com.co
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com