[Bug 1262552] New: Review Request: python-pyhsm - Python module to talk to YubiHSM hardware - package-review

List overview All Threads
Download

newer

[Bug 1262552] New: Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

older

[Bug 1321461] New: Review Request:...

[Bug 1172771] New: Review Request:...

Red Hat Bugzilla

12 Sep 2015 12 Sep '15

7:33 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

Bug ID: 1262552 Summary: Review Request: python-pyhsm - Python module to talk to YubiHSM hardware Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: kevin@scrye.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm-1.0.4l-... Description: PyHSM is a python module and set of utilities to manage a YubiHSM, Yubico's Hardware Security Module.

Fedora Account System Username: kevin

koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11065502

rpmlint says:

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

30 Nov 30 Nov

6:08 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:

--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- %py2_build %py2_install

Remove rm -rf $RPMBUILDROOT.

Is it python2 only?

Looks OK otherwise.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Dec 1 Dec

12:48 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- kevin's scratch build of python-pyhsm-1.0.4l-2.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12018984

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:51 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #3 from Kevin Fenzi kevin@scrye.com --- Made those changes (%py2_build / %py2_install), removed rm -rf in install.

Yes, it's python2 only at this time.

Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm-1.0.4l-...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:08 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- - license is OK - license file is present, %license is used - new python macros are used (mostly) - rpmlint:

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

- provides: python-pyhsm = 1.0.4l-2.fc24

Please generate python2-pyhsm binary subpackage, and add %{?python_provide:%python_provide python2-%{srcname}}.

- requires: /bin/sh /usr/bin/env /usr/bin/python python(abi) = 2.7 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1

OK, except that /usr/bin/env is suspicious.

run.sh in Tests/ is completely broken. Should be either fixed or removed.

Some files in /bin/ use #!/usr/bin/env python, others use #!/usr/bin/python. Please fix them all to use #!%{__python2}.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Dec 5 Dec

7:52 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #5 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- kevin's scratch build of python-pyhsm-1.0.4l-3.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12073282

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:07 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #6 from Kevin Fenzi kevin@scrye.com --- ok. I created the python2 subpackage.

Can you explain how run.sh in Tests is broken? It worked fine here, but note (as per the comment in the spec file) it's commented out because you have to have a YubiHSM to test against.

Is there a guideline saying to replace all /usr/bin/env calls? I agree it's not great, but I would prefer to ask upstream to change that instead of carrying some large patch.

Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm-1.0.4l-...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:50 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:

--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Kevin Fenzi from comment #6)

...

ok. I created the python2 subpackage.

Can you explain how run.sh in Tests is broken? It worked fine here, but note (as per the comment in the spec file) it's commented out because you have to have a YubiHSM to test against.

$ /usr/share/doc/python2-pyhsm/Tests/run.sh python: can't open file '/usr/share/doc/python2-pyhsm/Tests/../setup.py': [Errno 2] No such file or directory

It also refers to ../Lib, which is not in the package at all.

...

Is there a guideline saying to replace all /usr/bin/env calls? I agree it's not great, but I would prefer to ask upstream to change that instead of carrying some large patch.

Some executables in the package in /usr/bin/ have /usr/bin/env python, others have /usr/bin/python. This is kind of inelegant. Also there's bigger chance of running a user-installed python by mistake. Changing it to /usr/bin/python2 everywhere makes things crystal clear. I don't think that there's an official guideline, but I think it's generally recommended.

...

Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm-1.0.4l- 3.fc24.src.rpm

OK, please fix (or not) the two small issues pointed out above as you see fit. Package is APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Dec 6 Dec

6:13 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #8 from Kevin Fenzi kevin@scrye.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7)

...

$ /usr/share/doc/python2-pyhsm/Tests/run.sh python: can't open file '/usr/share/doc/python2-pyhsm/Tests/../setup.py': [Errno 2] No such file or directory

It also refers to ../Lib, which is not in the package at all.

Oh right. It does the tests from the source tree after build, but before install. That Lib is in the source checkout.

...

Some executables in the package in /usr/bin/ have /usr/bin/env python, others have /usr/bin/python. This is kind of inelegant. Also there's bigger chance of running a user-installed python by mistake. Changing it to /usr/bin/python2 everywhere makes things crystal clear. I don't think that there's an official guideline, but I think it's generally recommended.

ok. I'll check with upstream and if they don't respond or the like carry a patch.

...

OK, please fix (or not) the two small issues pointed out above as you see fit. Package is APPROVED.

Thank you very much for the review!

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:30 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #9 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- A patch would be overkill, imho:

sed -i '1s|^#!.*python.*$|#!%{__python2} -s|' %{buildroot}%{_bindir}/*

(untested)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:43 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #10 from Kevin Fenzi kevin@scrye.com --- Sure, I meant a local change in the spec, not a patch specifically, but sure.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:39 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #11 from Till Maas opensource@till.name --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pyhsm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:23 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-c7f5a96b03

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:23 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:23 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-8ccbad579c

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:23 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-a37053b711

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Dec 8 Dec

12:22 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-pyhsm' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-8ccbad579c

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:32 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-pyhsm' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-c7f5a96b03

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:21 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update python-pyhsm' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-a37053b711

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

25 Dec 25 Dec

1:27 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:27 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Dec 29 Dec

12:54 a.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Apr 3 Apr

6:56 p.m.

New subject: [Bug 1262552] Review Request: python-pyhsm - Python module to talk to YubiHSM hardware

https://bugzilla.redhat.com/show_bug.cgi?id=1262552

--- Comment #20 from Fedora Update System updates@fedoraproject.org --- python-pyhsm-1.0.4l-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3398

Age (days ago)

3602

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla