[Bug 1944463] New: Review Request: rust-pam-client - Application API wrapper to Pluggable Authentication Modules (PAM)
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
Bug ID: 1944463 Summary: Review Request: rust-pam-client - Application API wrapper to Pluggable Authentication Modules (PAM) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: remilauzier@protonmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3... SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3... Description: Application API wrapper to Pluggable Authentication Modules (PAM) Fedora Account System Username: remilauzier
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |remilauzier@protonmail.com Blocks| |177841 (FE-NEEDSPONSOR), | |1941896 Depends On| |1901106
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1901106 [Bug 1901106] Review Request: rust-pam-sys - FFI rust crate https://bugzilla.redhat.com/show_bug.cgi?id=1941896 [Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Could you make sure that in all you Rust request you've included the license file in the devel subpackage:
%package devel Summary: %{summary} BuildArch: noarch
%description devel %{_description}
This package contains library source intended for building other packages which use "%{crate}" crate.
%files devel %doc README.md %license LICENSE %{cargo_registry}/%{crate}-%{version_no_tilde}/
- Similarly, please add a comment explaining what changes did you make to the Casgo.toml(s)
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
--- Comment #2 from Rémi Lauzier remilauzier@protonmail.com --- Hi! Just want to know, do i have to include the license if the git repo contain none? Do i have to point to a file somewhere? There's two package in this situation.
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
--- Comment #3 from Rémi Lauzier remilauzier@protonmail.com --- Hi! I manager to compile rust-pam-client without the patch. https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3... https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3...
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- (In reply to Rémi Lauzier from comment #2)
Hi! Just want to know, do i have to include the license if the git repo contain none? Do i have to point to a file somewhere? There's two package in this situation.
No, but you should file a bug report asking upstream to add it to their crate, then add a link to the bug above the License; field.
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
--- Comment #5 from Rémi Lauzier remilauzier@protonmail.com --- Hi! I have done all the bug report and put the link in the .spec file. i have import in the source from github for those where the file exist and put the link to the bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #6 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Package approved. You still need to find a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
--- Comment #8 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pam-client
https://bugzilla.redhat.com/show_bug.cgi?id=1944463
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-07-11 05:06:55
https://bugzilla.redhat.com/show_bug.cgi?id=1944463 Bug 1944463 depends on bug 1901106, which changed state.
Bug 1901106 Summary: Review Request: rust-pam-sys - FFI rust crate https://bugzilla.redhat.com/show_bug.cgi?id=1901106
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com