https://bugzilla.redhat.com/show_bug.cgi?id=2353504
Bug ID: 2353504 Summary: Review Request: rust-revision - Serialization and deserialization implementation Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-revision/rust-revision.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-revision/rust-revision-0.11.0-...
Description: A serialization and deserialization implementation which allows for schema-evolution.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2353504
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2353503
--- Comment #1 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [package] summary = "Serialization and deserialization implementation" cargo-toml-patch-comments = ["Drop unnecessary criterion dependency"]
[features] hide = [ # Missing dependencies "geo", "roaring", ]
[scripts] prep.pre = [ # Remove spurious executable bits "chmod -x LICENSE README.md src/lib.rs tests/test.rs" ]
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2353503 [Bug 2353503] Review Request: rust-revision-derive - Implements procedural macros for automatic Revision trait implementation
https://bugzilla.redhat.com/show_bug.cgi?id=2353504
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/re | |vision
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8796428 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2353504 Bug 2353504 depends on bug 2353503, which changed state.
Bug 2353503 Summary: Review Request: rust-revision-derive - Implements procedural macros for automatic Revision trait implementation https://bugzilla.redhat.com/show_bug.cgi?id=2353503
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2353504
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Package looks good to me. Please file an upstream PR for dropping the executable bit from non-executable source files.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)
package-review@lists.fedoraproject.org