[Bug 459161] New: Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Summary: Review Request: wraplinux - Utility to wrap a Linux
                    kernel and initrd into an ELF or NBI file
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://togami.com/~warren/fedora/wraplinux.spec
SRPM URL: http://togami.com/~warren/fedora/wraplinux-1.5-1.fc9.src.rpm

A tool to wrap an x86 Linux kernel and one or more initrd files into a
single file in ELF or NBI format, as required by some booting protocols.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Warren Togami  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Customer Facing|                            |---

--- Comment #1 from Warren Togami   2008-08-14 16:30:40 EDT ---
As requested by drago01:
- Builds in mock (yes it really doesn't have any build reqs)
-  wraplinux.i386: W: executable-stack /usr/bin/wraplinux
This is the only rpmlint warning.  Asking hpa upstream if this was intended or
not.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

--- Comment #2 from Warren Togami   2008-08-14 22:11:46 EDT ---
http://togami.com/~warren/fedora/wraplinux.spec
http://togami.com/~warren/fedora/wraplinux-1.6-1.fc9.src.rpm

No remaining rpmlint warnings, builds cleanly in mock.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Rahul Sundaram  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #3 from Rahul Sundaram   2008-08-14 22:18:40 EDT ---

Looks clean. Approved.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Warren Togami  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Christoph Wickert   2009-07-19 11:30:00 EDT ---
Rahul, sorry to rain on your parade once again, but the license tag is wrong.
It's GPLv2+, not GPLv2. You did check the headers, did you?

Warren, please fix this in the next version or rebuild. Thanks.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

--- Comment #5 from Rahul Sundaram   2009-07-19 11:40:57 EDT ---
I don't recall what all I checked six months backs and whether the headers have
changed meanwhile in new releases but I am feeling quite amused you decided to
recheck all my reviews. I suggest that if you find packaging bugs, you file a
new bug report instead of commenting on closed reviews. I know package
maintainers who filter out comments on closed bug reports to low priority or
even /dev/null.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

--- Comment #6 from Christoph Wickert   2009-07-19 11:58:19 EDT ---
(In reply to comment #5)
> I don't recall what all I checked six months backs

One more reason to write it down in the review...
> and whether the headers have changed meanwhile in new releases

There was no new release in the meantime.
> but I am feeling quite amused you decided to
> recheck all my reviews.

Not all your reviews, just the obvious errors that are easy to find.
> I suggest that if you find packaging bugs, you file a
> new bug report instead of commenting on closed reviews.

Thanks for the suggestion, I will CC you then because I want you to become
aware of your errors.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

--- Comment #7 from Rahul Sundaram   2009-07-19 12:16:14 EDT ---
Writing down makes no real difference to me. There has been instances of people
blindly copy pasting templates and still overlooking checklist items. Again,
instead of approaching it on a case by case basis, if you feel strongly about
how reviews should be done, it is better to take it to the packaging committee
or FESCo and make it part of the guidelines/rules. Otherwise it is just
individual's freedom to do the reviews as they see fit.

I would also note that packaging is primarily the responsibility of the package
maintainers. Reviewers are merely volunteering to help out with the process as
QA assistance. Mistakes are bound to happen either way even with a recheck.
Just to demonstrate, I checked the copyright notices again, GPLv2+ doesn't seem
the right choice here either. reloc_linux.c seems to be under the MIT license
actually and xmalloc.c doesn't even have a license notice. Warren, I suggest
you contact upstream and clarify these.

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

Rahul Sundaram  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235(FE-Legal)

[Bug 459161] Review Request: wraplinux - Utility to wrap a Linux kernel and initrd into an ELF or NBI file

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459161

--- Comment #8 from Warren Togami   2009-07-19 12:41:44 EDT ---
> It's GPLv2+, not GPLv2. You did check the headers, did you?

What if I choose to use it only under the GPLv2?

You know, I really don't care.  Aren't you a provenpackager?  Just fix it
yourself if you care.  It really doesn't matter.