[Bug 1555225] New: Review Request: python-mplcairo - A (new) cairo backend for Matplotlib
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
Bug ID: 1555225 Summary: Review Request: python-mplcairo - A (new) cairo backend for Matplotlib Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://qulogic.fedorapeople.org//python-mplcairo.spec SRPM URL: https://qulogic.fedorapeople.org//python-mplcairo-0.1-0.1.a1.fc27.src.rpm
Description: This is a new, essentially complete implementation of a cairo backend for Matplotlib. It can be used in combination with a Qt5, GTK3, Tk, wx, or macOS UI, or noninteractively (i.e., to save figure to various file formats). Noteworthy points include: * Speed (the backend can be up to 10× faster than Agg, e.g., when stamping circular markers of variable colors). * Support for a wider variety of font formats, such as otf and pfb, for vector (PDF, PS, SVG) backends (Matplotlib’s Agg backend also supports such fonts). * Optional support for complex text layout (right-to-left languages, etc.) using Raqm. Note that Raqm depends on Fribidi, which is licensed under the LGPLv2.1+. * Support for embedding URLs in PDF (but not SVG) output (requires cairo≥1.15.4). * Support for multi-page output both for PDF and PS (Matplotlib only supports multi-page PDF).
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- No scratch build yet because we need the Python subpackages to be added to pybind11: https://src.fedoraproject.org/rpms/pybind11/pull-request/2
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Can't check install because matplotlib 2.2 is not yet available:
DEBUG util.py:482: BUILDSTDERR: Problem: conflicting requests DEBUG util.py:482: BUILDSTDERR: - nothing provides python3-matplotlib >= 2.2 needed by python3-mplcairo-0.1-0.1.a1.fc29.x86_64
- Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./vendor/setuptools_scm-1.15.6.egg See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools...
Remove vendor.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./vendor/setuptools_scm-1.15.6.egg See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools...
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "*No copyright* LGPL (v2.1)", "Unknown or generated". 42 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-mplcairo/review- python-mplcairo/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-mplcairo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-mplcairo-0.1-0.1.a1.fc29.x86_64.rpm python-mplcairo-debugsource-0.1-0.1.a1.fc29.x86_64.rpm python-mplcairo-0.1-0.1.a1.fc29.src.rpm python3-mplcairo.x86_64: W: spelling-error %description -l en_US wx -> ex, w, x python3-mplcairo.x86_64: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS python3-mplcairo.x86_64: W: spelling-error %description -l en_US noninteractively -> non interactively, non-interactively, interactively python3-mplcairo.x86_64: W: spelling-error %description -l en_US otf -> oft, of, oaf python3-mplcairo.x86_64: W: spelling-error %description -l en_US pfb -> pf, pub, pf b python-mplcairo-debugsource.x86_64: W: no-documentation python-mplcairo.src: W: spelling-error %description -l en_US wx -> ex, w, x python-mplcairo.src: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS python-mplcairo.src: W: spelling-error %description -l en_US noninteractively -> non interactively, non-interactively, interactively python-mplcairo.src: W: spelling-error %description -l en_US otf -> oft, of, oaf python-mplcairo.src: W: spelling-error %description -l en_US pfb -> pf, pub, pf b 3 packages and 0 specfiles checked; 0 errors, 11 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- OK, now updated to the final release:
Spec URL: https://qulogic.fedorapeople.org/python-mplcairo.spec SRPM URL: https://qulogic.fedorapeople.org/python-mplcairo-0.1-1.fc28.src.rpm
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28587866
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mplcairo
https://bugzilla.redhat.com/show_bug.cgi?id=1555225
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |python-mplcairo-0.1-1.fc30 | |python-mplcairo-0.1-1.fc29 Resolution|--- |RAWHIDE Last Closed| |2018-08-16 00:48:50
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com