[Bug 827730] New: Review Request: trac-code-comments-plugin - Trac plugin for code comments and sending them to tickets
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Bug ID: 827730 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: trac-code-comments-plugin - Trac plugin for code comments and sending them to tickets Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: codeblock@elrod.me Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-co... SRPM URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-co... Description: This plugin allows you to leave comments on top of files, change sets, and attachments. Once you've added all of your comments, you can send them to tickets. These include links to these comments and their description. Fedora Account System Username: codeblock
Clean rpmlint, minus one warning because of how the source was obtained (upstream is a tarball downloaded from github).
[ricky@t520 rpmbuild]$ rpmlint SRPMS/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.src.rpm trac-code-comments-plugin.src: W: invalid-url Source0: Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[ricky@t520 rpmbuild]$ rpmlint RPMS/noarch/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Note that this does have several javascript libraries bundled with it with varying licenses. I've included (in %doc) a LICENSING_BREAKDOWN file which shows what is licensed differently from the plugin itself, as instructed here: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensi...
Happy to clarify any of the licensing related things if I need to (or communicate with upstream to do so).
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Ricky Elrod codeblock@elrod.me changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@scrye.com
--- Comment #1 from Ricky Elrod codeblock@elrod.me --- Kevin has agreed to review this. CCing.
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |kevin@scrye.com Flags| |fedora-review?
--- Comment #2 from Kevin Fenzi kevin@scrye.com --- I'll try and review this sometime this weekend. ;)
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz.new OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. The release seems a bit off here. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_package... for more info. If this is a prerelease of 1.2.0, I'd suggest:
0.1.alpha2
or
0.1.20120601gitb260714 (if there's no tag/release of alpha2)
2. Might ask upstream to include copies of the licenses it's under. (non blocker)
3. rpmlint says:
trac-code-comments-plugin.src: W: invalid-url Source0: Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Which can be ignored.
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #4 from Ricky Elrod codeblock@elrod.me --- *Updated the 'Release' field.
* Filed #18 upstream asking if they'd mind including a LICENSE file: https://github.com/Automattic/trac-code-comments-plugin/issues/18
Files are in the same locations:
Spec URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-co... SRPM URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-co...
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #5 from Ricky Elrod codeblock@elrod.me --- oops, I lied
New SRPM: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-co...
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Kevin Fenzi kevin@scrye.com --- Looks good. I see no further blockers, so this package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #7 from Ricky Elrod codeblock@elrod.me --- New Package SCM Request ======================= Package Name: trac-code-comments-plugin Short Description: Trac plugin for code comments and sending them to tickets Owners: codeblock Branches: f16 f17 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Ricky Elrod codeblock@elrod.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1....
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1....
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1....
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been pushed to the Fedora EPEL 6 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827730
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-06-26 17:27:57
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 has been pushed to the Fedora 16 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827730
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla