[Bug 741900] New: Review Request: grinder - A tool for synchronizing repositories and their contents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: grinder - A tool for synchronizing repositories and their contents
https://bugzilla.redhat.com/show_bug.cgi?id=741900
Summary: Review Request: grinder - A tool for synchronizing repositories and their contents Product: Fedora Version: 16 Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmorsi@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
SPEC: http://mo.morsi.org/files/rpms/grinder.spec SRPM: http://mo.morsi.org/files/rpms/grinder-0.0.27-1.fc15.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3384961
A tool for synching content from the Red Hat Network.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741900
James Laska jlaska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |743402
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741900
Scott Dodson sdodson@sdodson.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sdodson@sdodson.com
--- Comment #1 from Scott Dodson sdodson@sdodson.com 2011-10-06 00:10:52 EDT --- Informal review. I am not a sponsored packager yet.
[ FAIL ] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
$ rpmlint grinder-0.0.27-1.fc15.src.rpm grinder.spec ~/rpmbuild/RPMS/noarch/grinder-0.0.27-1.fc15.noarch.rpm grinder.src: W: spelling-error %description -l en_US synching -> syncing, lynching, sync hing grinder.noarch: E: explicit-lib-dependency python-hashlib grinder.noarch: W: spelling-error %description -l en_US synching -> syncing, lynching, sync hing grinder.noarch: W: incoherent-version-in-changelog 0.0.118-1 ['0.0.27-1.fc15', '0.0.27-1'] grinder.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grinder/SatDumpClient.py 0644L /usr/bin/env grinder.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grinder/rhn_api.py 0644L /usr/bin/python grinder.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grinder/PackageFetch.py 0644L /usr/bin/env grinder.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grinder/RHNComm.py 0644L /usr/bin/env grinder.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grinder/grinder.py 0644L /usr/bin/python grinder.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grinder/ParallelFetch.py 0644L /usr/bin/env grinder.noarch: W: no-manual-page-for-binary grinder 2 packages and 1 specfiles checked; 7 errors, 4 warnings.
[ PASS ] MUST: The package must be named according to the Package Naming Guidelines .
[ PASS ] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[ FAIL ] MUST: The package must meet the Packaging Guidelines . It lacks meaningful documentation. Changelog has entries that don't seem relevant to the version packaged. Is this 0.0.27 or a later version?
[ PASS ] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[ PASS ] MUST: The License field in the package spec file must match the actual license.
[ FAIL ] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
tarball has a LICENSE please include it.
[ PASS ] MUST: The spec file must be written in American English.
[ PASS ] MUST: The spec file for the package MUST be legible.
[ PASS ] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
$ md5sum rpmbuild/SOURCES/grinder-0.0.27.tar.gz ; curl -s -o - http://mmccune.fedorapeople.org/grinder/grinder-0.0.27.tar.gz | md5sum - 8367b3988299d6ba364620d170c57ad3 rpmbuild/SOURCES/grinder-0.0.27.tar.gz 8367b3988299d6ba364620d170c57ad3 -
[ PASS ] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[ PASS ] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[ N/A ] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[ PASS ] MUST: Packages must NOT bundle copies of system libraries.
[ N/A ] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[ PASS ] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[ PASS ] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[ FAIL ] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
Several scripts are not executable, though it's not clear that all of them are intended to be scripts. See rpmlint output above.
[ PASS ] MUST: Each package must consistently use macros.
[ PASS ] MUST: The package must contain code, or permissable content.
[ N/A ] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[ PASS ] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[ N/A ] MUST: Header files must be in a -devel package.
[ N/A ] MUST: Static libraries must be in a -static package.
[ N/A ] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[ N/A ] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[ PASS ] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[ N/A ] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[ PASS ] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[ PASS ] MUST: All filenames in rpm packages must be valid UTF-8.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741900
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #2 from Volker Fröhlich volker27@gmx.at 2011-10-11 06:18:50 EDT --- The license file is in the source package twice. One copy is included, that's fine.
Does the unit test work?
You can leave out the "-n grinder-%{version}", because that is exactly what the setup macro expects.
If you're not going for EPEL 4, you can remove defattr.
You should probably only define python_sitelib on systems that don't define it:
http://fedoraproject.org/wiki/Packaging:Python#Macros
It seems to me, python-hashlib is part of the Python package, at least from 2.5 on.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741900
--- Comment #3 from Volker Fröhlich volker27@gmx.at 2011-10-11 06:19:46 EDT --- Whatever happened to the line-breaks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741900
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|743402 |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741900
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |DEFERRED Last Closed| |2011-12-08 09:42:12
--- Comment #4 from Mo Morsi mmorsi@redhat.com 2011-12-08 09:42:12 EST --- I'm closing this out as it turns out we don't need this for aeolus. Anyone who would like to see grinder in Fedora is more than welcome to re-open and use my package as the basis for further development.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla