[Bug 2268133] New: Review Request: python-pytest-home - a temporary home directory fixture.

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

            Bug ID: 2268133
           Summary: Review Request: python-pytest-home - a temporary home
                    directory fixture.
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: thrnciar(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/thrnciar/python-pytest...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/thrnciar/python-pytest...
Description:    A temporary home directory fixture
Fedora Account System Username:thrnciar


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2268133] Review Request: python-pytest-home - a temporary home directory fixture

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Lumír Balhar <lbalhar(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody(a)fedoraproject.org    |lbalhar(a)redhat.com
             Status|NEW                         |ASSIGNED
                 CC|                            |lbalhar(a)redhat.com
              Flags|                            |fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

[Bug 2268133] Review Request: python-pytest-home - a temporary home directory fixture

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/jaraco/p
                   |                            |ytest-home



--- Comment #1 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7111078
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2268133] Review Request: python-pytest-home - a temporary home directory fixture

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Lumír Balhar <lbalhar(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Lumír Balhar <lbalhar(a)redhat.com&gt; ---
Everything looks good to me. Consider adding a comment to explain the build
dependency on git-core.

Package APPROVED.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* MIT License". 24
files
     have unknown license. Detailed output of licensecheck in
     /home/lbalhar/temp/reviews/2268133-python-pytest-home/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.12/site-packages,
     /usr/lib/python3.12
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 996 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-pytest-home-0.5.1-1.fc41.noarch.rpm
          python-pytest-home-0.5.1-1.fc41.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpiyxoub_p')]
checks: 32, packages: 2

python-pytest-home.src: E: spelling-error ('dotfiles', '%description -l en_US
dotfiles -> dot files, dot-files, domiciles')
python-pytest-home.src: E: spelling-error ('dir', '%description -l en_US dir
->
deer, jr, rid')
python3-pytest-home.noarch: E: spelling-error ('dotfiles', '%description -l
en_US dotfiles -> dot files, dot-files, domiciles')
python3-pytest-home.noarch: E: spelling-error ('dir', '%description -l en_US
dir -> deer, jr, rid')
 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 8 filtered, 4
badness; has taken 0.8 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-pytest-home.noarch: E: spelling-error ('dotfiles', '%description -l
en_US dotfiles -> dot files, dot-files, domiciles')
python3-pytest-home.noarch: E: spelling-error ('dir', '%description -l en_US
dir -> deer, jr, rid')
 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 4 filtered, 2
badness; has taken 0.1 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pytest-home/pytest-home-...
:
  CHECKSUM(SHA256) this package     :
8e940e31e5f7682c31543df06b3b0044ccc5dbf82de6141c2147da3857c72719
  CHECKSUM(SHA256) upstream package :
8e940e31e5f7682c31543df06b3b0044ccc5dbf82de6141c2147da3857c72719


Requires
--------
python3-pytest-home (rpmlib, GLIBC filtered):
    python(abi)
    python3.12dist(pytest)



Provides
--------
python3-pytest-home:
    python-pytest-home
    python3-pytest-home
    python3.12-pytest-home
    python3.12dist(pytest-home)
    python3dist(pytest-home)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2268133
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Perl, R, Haskell, PHP, SugarActivity, C/C++, fonts, Java,
Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2268133] Review Request: python-pytest-home - a temporary home directory fixture

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST



--- Comment #3 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pytest-home


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2268133] Review Request: python-pytest-home - a temporary home directory fixture

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-aec7c9ac4b (python-pytest-home-0.5.1-1.fc41) has been submitted as
an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-aec7c9ac4b


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2268133] Review Request: python-pytest-home - a temporary home directory fixture

https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-03-06 13:47:24



--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-aec7c9ac4b (python-pytest-home-0.5.1-1.fc41) has been pushed to the
Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2268133

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...