[Bug 2117384] New: Review Request: python-influxdb-client - client library for the InfluxDB 2.0 and 1.8+
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Bug ID: 2117384 Summary: Review Request: python-influxdb-client - client library for the InfluxDB 2.0 and 1.8+ Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: steve.traylen@cern.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://cern.ch/straylen/rpms/python-influxdb-client/python-influxdb-client.... SRPM URL: https://cern.ch/straylen/rpms/python-influxdb-client/python-influxdb-client-... Description: client library for the InfluxDB 2.0 and 1.8+ Fedora Account System Username: stevetraylen
Note that this is a distinct module and package to the existing https://src.fedoraproject.org/rpms/python-influxdb package which is for older influx databases.
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan@almalinux.org Doc Type|--- |If docs needed, set a value Flags| |needinfo?(steve.traylen@cer | |n.ch)
--- Comment #1 from Jonathan Wright jonathan@almalinux.org ---
%check %py3_check_import influxdb_client
Why not pull the sources from Github so you can run the full/proper test suite?
It also includes the license file.
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2121759
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2121759 [Bug 2121759] Review Request:python-reactivex - ReactiveX (Rx) for Python
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(steve.traylen@cer | |n.ch) |
--- Comment #2 from Steve Traylen steve.traylen@cern.ch --- Will add tests as soon as that dep is available.
The dependencies changed with the release of 1.32.0.
https://bugzilla.redhat.com/show_bug.cgi?id=2117384 Bug 2117384 depends on bug 2121759, which changed state.
Bug 2121759 Summary: Review Request:python-reactivex - ReactiveX (Rx) for Python https://bugzilla.redhat.com/show_bug.cgi?id=2121759
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
--- Comment #3 from Steve Traylen steve.traylen@cern.ch ---
* Tests now running * Updated to latest upstream * Converted to autochangelog.
Spec URL: https://cern.ch/straylen/rpms/python-influxdb-client/python-influxdb-client.... SRPM URL: https://cern.ch/straylen/rpms/python-influxdb-client/python-influxdb-client-...
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
--- Comment #4 from Steve Traylen steve.traylen@cern.ch --- The
#%%doc README.rst
should be uncommented - next time.
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
--- Comment #5 from Steve Traylen steve.traylen@cern.ch --- %doc line corrected.
Spec URL: https://cern.ch/straylen/rpms/python-influxdb-client/python-influxdb-client.... SRPM URL: https://cern.ch/straylen/rpms/python-influxdb-client/python-influxdb-client-...
[fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
--- Comment #6 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1953234 --> https://bugzilla.redhat.com/attachment.cgi?id=1953234&action=edit The .spec file difference from Copr build 5622425 to 5701107
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonathan@almalinu | |x.org)
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(jonathan@almalinu | |x.org) | Status|ASSIGNED |POST
--- Comment #7 from Jonathan Wright jonathan@almalinux.org --- Package is approved!
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 517 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora-review/2117384-python-influxdb- client/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-influxdb-client-1.36.1-1.fc39.noarch.rpm python-influxdb-client-1.36.1-1.fc39.src.rpm ========================================================================================================== rpmlint session starts ========================================================================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_jofrceb')] checks: 31, packages: 2
python3-influxdb-client.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/influxdb_client/service/__init__.py /usr/lib/python3.11/site-packages/influxdb_client/client/__init__.py:/usr/lib/python3.11/site-packages/influxdb_client/client/write/__init__.py =========================================================================== 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.7 s ==========================================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
python3-influxdb-client.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/influxdb_client/service/__init__.py /usr/lib/python3.11/site-packages/influxdb_client/client/__init__.py:/usr/lib/python3.11/site-packages/influxdb_client/client/write/__init__.py 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s
Source checksums ---------------- https://github.com/influxdata/influxdb-client-python/archive/v1.36.1/influxd... : CHECKSUM(SHA256) this package : 3bbcf9e30828262917eb07177a88edf13ec94d43a4fbba5db133b95b850beeda CHECKSUM(SHA256) upstream package : 3bbcf9e30828262917eb07177a88edf13ec94d43a4fbba5db133b95b850beeda
Requires -------- python3-influxdb-client (rpmlib, GLIBC filtered): python(abi) python3.11dist(certifi) python3.11dist(python-dateutil) python3.11dist(reactivex) python3.11dist(setuptools) python3.11dist(urllib3)
Provides -------- python3-influxdb-client: python-influxdb-client python3-influxdb-client python3.11-influxdb-client python3.11dist(influxdb-client) python3dist(influxdb-client)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2117384 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, Perl, SugarActivity, Ocaml, PHP, C/C++, R, Haskell, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
--- Comment #8 from Steve Traylen steve.traylen@cern.ch --- Thanks for the review Jonathan, think you need to sync some email addresses - https://pagure.io/releng/fedora-scm-requests/issue/52213
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-influxdb-client
https://bugzilla.redhat.com/show_bug.cgi?id=2117384
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NEXTRELEASE Status|POST |CLOSED Last Closed| |2023-03-25 16:09:00
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com