[Bug 1276161] New: Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
Bug ID: 1276161 Summary: Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: emmanuel@seyman.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://people.parinux.org/~seyman/fedora/perl-SQL-SplitStatement/perl-SQL-Sp... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-SQL-SplitStatement/perl-SQL-Sp... Description: This is a simple module which tries to split any SQL code, even including non-standard extensions (for the details see the "SUPPORTED DBMSs" section below), into the atomic statements it is composed of.
Fedora Account System Username: eseyman
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- jplesnik's scratch build of perl-SQL-SplitStatement-1.00020-2.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11624840
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok URL and Source0 are ok All tests passed
$ rpm -qp --requires perl-SQL-SplitStatement-1.00020-2.fc24.noarch.rpm | sort | uniq -c 1 /usr/bin/env 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Class::Accessor::Fast) 1 perl(Getopt::Long) 1 perl(List::MoreUtils) 1 perl(Pod::Usage) 1 perl(Regexp::Common) 1 perl(SQL::SplitStatement) 1 perl(SQL::Tokenizer) >= 0.22 1 perl(base) 1 perl(constant) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-SQL-SplitStatement-1.00020-2.fc24.noarch.rpm | sort | uniq -c 1 perl(SQL::SplitStatement) = 1.00020 1 perl-SQL-SplitStatement = 1.00020-2.fc24 Binary provides are Ok.
$ rpmlint perl-SQL-SplitStatement* perl-SQL-SplitStatement.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-SQL-SplitStatement/LICENSE 2 packages and 1 specfiles checked; 1 errors, 0 warnings.
Invalid address was reported to upstream. Otherwise rpmlint is ok.
BuildRequires need to be updated FIX: Please add BRs * perl(base) - lib/SQL/SplitStatement.pm:10 * perl(File::Find) - SQL-SplitStatement-2.00020/t/00-compile.t:10 * perl(strict) - Makefile.PL and tests * perl(warnings) - Makefile.PL and tests * Add version constrain to perl(SQL::Tokenizer) >= 0.22
Description TODO: this part of Description should be changed "(for the details see the "SUPPORTED DBMSs" section below)", because the section is part of man page not Description
Please correct all 'FIX' issues and consider fixing 'TODO' item
Otherwise, the package looks good Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Emmanuel Seyman emmanuel@seyman.fr --- (In reply to Jitka Plesnikova from comment #2):
BuildRequires need to be updated FIX: Please add BRs
Done.
TODO: this part of Description should be changed "(for the details see the "SUPPORTED DBMSs" section below)", because the section is part of man page not Description
Indeed. Done.
Please correct all 'FIX' issues and consider fixing 'TODO' item
Spec URL: http://people.parinux.org/~seyman/fedora/perl-SQL-SplitStatement/perl-SQL-Sp... SRPM URL: http://people.parinux.org/~seyman/fedora/perl-SQL-SplitStatement/perl-SQL-Sp...
Package APPROVED.
Thank you, Jikta. SCM request made.
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1276161
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-SQL-SplitStatement-1.0 | |0020-3.fc24 Resolution|--- |RAWHIDE Last Closed| |2015-11-10 04:30:46
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla