[Bug 1740710] New: Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Bug ID: 1740710
           Summary: Review Request: python-pip-shims - Pip-shims is a set
                    of compatibility access shims to the pip internal API
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora...
Description: The authors of pip do not condone the use of this package.
Relying on pip's internals is a dangerous idea for your software as 
they are broken intentionally and regularly.
This package may not always be completely updated up PyPI,
so relying on it may break your code! User beware!
Fedora Account System Username: pkopkan

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Petr Viktorin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Petr Viktorin  ---
That description is not really convincing. What does this do? What's the reason
to have this in Fedora?

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Miro Hrončok  ---
URL:            https://github.com/sarugaku/requirementslib

?

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

--- Comment #3 from Patrik Kopkan  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora...

Is this description better?

This is library used by pipenv. Author recommends that nothing else than pipenv
should depend on this.

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Petr Viktorin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #4 from Petr Viktorin  ---
Why the commented-out "#Source0:? If that should stay in, please comment on
why.
Is the "Requires: python3-pip" necessary? Does the generator not find it?

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

--- Comment #5 from Petr Viktorin  ---
> Is this description better?

Yes, it is. It still suggests unbundling might not be the highest priority
here, but that doesn't block the review :)

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

--- Comment #6 from Petr Viktorin  ---

rpmlint warns on:
- the commented Sources line contains macros
- The %description has a typo, so the _description macro is not expanded (!)

(rpmlint sometimes actually finds bugs!)

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[X]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "ISC License". 31 files have unknown
     license.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
     names).
[X]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
     "python3-pip" seems unnecessary
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[X]: A package which is used by another package via an egg interface should
     provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
     architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint (see above)
-------------------------
Checking: python3-pip-shims-0.3.2-1.fc31.noarch.rpm
          python-pip-shims-0.3.2-1.fc31.src.rpm
python3-pip-shims.noarch: W: spelling-error %description -l en_US pipenv ->
pipeline
python-pip-shims.src: W: spelling-error %description -l en_US desription ->
description, prescription, desertion
python-pip-shims.src:10: W: macro-in-comment %{version}
python-pip-shims.src:10: W: macro-in-comment %{version}
python-pip-shims.src: E: specfile-error warning: Macro expanded in comment on
line 10: %{version}.tar.gz#/pip-shims-%{version}.tar.gz
python-pip-shims.src: E: specfile-error 
python-pip-shims.src: E: specfile-error warning: Macro expanded in comment on
line 10: %{version}.tar.gz#/pip-shims-%{version}.tar.gz
2 packages and 0 specfiles checked; 3 errors, 5 warnings.

Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
python3-pip-shims.noarch: W: spelling-error %description -l en_US pipenv ->
pipeline
python3-pip-shims.noarch: W: invalid-url URL:
https://github.com/sarugaku/pip-shims <urlopen error [Errno -2] Name or service
not known>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

(I had no internet when I checked)

Source checksums
----------------
https://github.com/sarugaku/pip-shims/archive/0.3.2/pip-shims-0.3.2.tar.gz :
  CHECKSUM(SHA256) this package     :
4009b5359e9f4df3c7b0203615598e01128dd3e645c437a80bfc663c03494d71
  CHECKSUM(SHA256) upstream package :
4009b5359e9f4df3c7b0203615598e01128dd3e645c437a80bfc663c03494d71

Requires
--------
python3-pip-shims (rpmlib, GLIBC filtered):
    python(abi)
    python3-pip
    python3.7dist(pip)
    python3.7dist(setuptools)
    python3.7dist(six)
    python3.7dist(wheel)

Provides
--------
python3-pip-shims:
    python-pip-shims
    python3-pip-shims
    python3.7dist(pip-shims)
    python3dist(pip-shims)

Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09
Command line :/usr/bin/fedora-review -b 1740710
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: Perl, PHP, fonts, Ocaml, Haskell, R, SugarActivity, Java,
C/C++
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Petr Viktorin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Patrik Kopkan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #7 from Patrik Kopkan  ---
rpmlint python3-pip-shims-0.3.2-1.fc31.noarch.rpm
python3-pip-shims.noarch: W: spelling-error %description -l en_US pipenv ->
pipeline

rpm -qi python3-pip-shims-0.3.2-1.fc31.noarch.rpm 
Name        : python3-pip-shims
Version     : 0.3.2
Release     : 1.fc31
Architecture: noarch
Install Date: (not installed)
Group       : Unspecified
Size        : 55855
License     : ISC
Signature   : (none)
Source RPM  : python-pip-shims-0.3.2-1.fc31.src.rpm
Build Date  : Wed 14 Aug 2019 02:37:04 PM CEST
Build Host  : localhost.localdomain
Relocations : (not relocatable)
URL         : https://github.com/sarugaku/pip-shims
Summary     : Pip-shims is a set of compatibility access shims to the pip
internal API
Description :
 This is library used by pipenv. Author recommends that
nothing else than pipenv should depend on this.

Left in expand unwanted space. How the description part should look? Is it ok
to break line after colon to have one pharagraph or
should be some text after colon?

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

--- Comment #8 from Patrik Kopkan  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fedora...

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Petr Viktorin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #9 from Petr Viktorin  ---
That fixes the problems!

Package approved! Apologies for the delay.

Rpmlint
-------
Checking: python3-pip-shims-0.3.2-1.fc32.noarch.rpm
          python-pip-shims-0.3.2-1.fc32.src.rpm
python3-pip-shims.noarch: W: spelling-error %description -l en_US pipenv ->
pipeline
python-pip-shims.src: W: spelling-error %description -l en_US pipenv ->
pipeline
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

("pipenv" is the package name)

Rpmlint (installed packages)
----------------------------
[...perl warnings...]
python3-pip-shims.noarch: W: spelling-error %description -l en_US pipenv ->
pipeline
python3-pip-shims.noarch: W: invalid-url URL:
https://github.com/sarugaku/pip-shims <urlopen error [Errno -2] Name or service
not known>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

("pipenv" is the package name; no internet access)

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

--- Comment #10 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pip-shims

[Bug 1740710] Review Request: python-pip-shims - Pip-shims is a set of compatibility access shims to the pip internal API

https://bugzilla.redhat.com/show_bug.cgi?id=1740710

Patrik Kopkan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
   Fixed In Version|                            |0.3.2-1.fc32
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2019-08-26 16:39:39

--- Comment #11 from Patrik Kopkan  ---
Built https://koji.fedoraproject.org/koji/taskinfo?taskID=37299367