Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubywarrior - Game written in Ruby for learning Ruby and artificial intelligence
https://bugzilla.redhat.com/show_bug.cgi?id=818730
Summary: Review Request: rubywarrior - Game written in Ruby for learning Ruby and artificial intelligence Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jonc_mailbox@yahoo.ca QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://142.204.133.82/pkg/rubywarrior.spec SRPM URL: http://142.204.133.82/pkg/rubywarrior-0.1.2-2.fc17.src.rpm
Description:
You play as a warrior climbing a tall tower. On each floor you need to write a Ruby script to instruct the warrior to do certain tasks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818730
Chris Tyler chris@tylers.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@tylers.info
--- Comment #1 from Chris Tyler chris@tylers.info 2012-05-04 16:31:06 EDT --- Informal review while we await a sponsor...
N MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1]
*** Please post rpmlint output.
Y MUST: The package must be named according to the Package Naming Guidelines . Y MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . Y MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. N MUST: The License field in the package spec file must match the actual license. [3]
*** The license on github is MIT, the spec file says GPLv3
Y MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] Y MUST: The spec file must be written in American English. [5] Y MUST: The spec file for the package MUST be legible. [6] N MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
*** The Source0: field should point to a reliable upstream URL - the one in the spec file cannot be retrieved. To get a specific commit, use something like https://github.com/ryanb/ruby-warrior/tarball/94dc735 (for commit 94dc735) *** Additions to the source should be in other files, e.g., Source1: waterbear.desktop
...stop. Fix these up and I'll restart the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818730
--- Comment #2 from Jon Chiappetta jonc_mailbox@yahoo.ca 2012-05-10 16:39:59 EDT --- Below are new source RPMs of rubywarrior with rpmlint output:
Spec URL: http://142.204.133.82/pkg/rubywarrior.spec SRPM URL: http://142.204.133.82/pkg/rubywarrior-0.1.2-3.fc17.src.rpm
$ rpmlint rubywarrior-0.1.2-3.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818730
Jon Chiappetta jonc_mailbox@yahoo.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818730
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu --- I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.
URLs above are 404.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818730
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818730
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonc_mailbox@yaho | |o.ca)
https://bugzilla.redhat.com/show_bug.cgi?id=818730
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |james.hogarth@gmail.com Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(jonc_mailbox@yaho | |o.ca) | Last Closed| |2015-12-03 23:22:57
--- Comment #4 from James Hogarth james.hogarth@gmail.com --- Since there has been no response from the requester to the needs info in over a year closing this ticket as per the stalled review policy.
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org