https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Bug ID: 1336168 Summary: Review Request: git-lfs - Git extension for versioning large files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ignatenko@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/git-lfs.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/git-lfs-1.2.0-1.fc25.src.... Description: Git Large File Storage (LFS) replaces large files such as audio samples, videos, datasets, and graphics with text pointers inside Git, while storing the file contents on a remote server. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |git-lfs
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1336159 | |(golang-github-rubyist-trac | |erx), 1336161, 1336164 | |(golang-github-bgentry-go-n | |etrc), 1336166 | |(golang-github-technoweenie | |-assert)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1336159 [Bug 1336159] Review Request: golang-github-rubyist-tracerx - Output tracing information in your Go app based on environment variables https://bugzilla.redhat.com/show_bug.cgi?id=1336161 [Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go https://bugzilla.redhat.com/show_bug.cgi?id=1336164 [Bug 1336164] Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language https://bugzilla.redhat.com/show_bug.cgi?id=1336166 [Bug 1336166] Review Request: golang-github-technoweenie-assert - Asserts to Go testomg
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Sascha Spreitzer sspreitz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sspreitz@redhat.com Assignee|nobody@fedoraproject.org |sspreitz@redhat.com Flags| |fedora-review?
--- Comment #1 from Sascha Spreitzer sspreitz@redhat.com --- Hi Igor
I will be reviewing your request.
Kind regards Sascha
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(sspreitz@redhat.c | |om)
--- Comment #2 from Igor Gnatenko ignatenko@redhat.com --- (In reply to Sascha Spreitzer from comment #1)
Hi Igor
I will be reviewing your request.
It's good, what about other packages? ;)
Kind regards Sascha
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jchaloup@redhat.com
--- Comment #3 from Jan Chaloupka jchaloup@redhat.com --- Summary: - please provide %{commit}, %{shortcommit}, %{provider} and the usual macros for Go packages. They are handful (and needed) for tooling running over Go projects packaged in Fedora. - as long as the package is for Fedora only, BuildRequires: compiler(go-compiler) is fine. It will not work for epel6, epel7 and RHEL7 as compiler(go-compiler) is not defined there. - provide devel and unit-test subpackages as well (for analysis carried over Go projects in distribution) - to build from de-bundled dependencies, all imports prefixed with "github.com/github/git-lfs/vendor/_nuts/" must be updated. (Remove the prefix). U can use: sed -i "s/github.com/github/git-lfs/vendor/_nuts///" $(find . -name '*.go')
After removing the vendor prefix, the following list of deps remains:
BuildRequires: golang(github.com/ThomsonReutersEikon/go-ntlm/ntlm) BuildRequires: golang(github.com/bgentry/go-netrc/netrc) BuildRequires: golang(github.com/cheggaaa/pb) BuildRequires: golang(github.com/kr/pty) BuildRequires: golang(github.com/olekukonko/ts) BuildRequires: golang(github.com/rubyist/tracerx) BuildRequires: golang(github.com/spf13/cobra)
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I've tried to update this to 1.5.5 [1,2]. Bug 1336166 can be dropped because it's no longer a dependency. It will newly require golang-github-xeipuuv-gojsonschema [3], golang-github-xeipuuv-gojsonpointer [4], and golang-github-xeipuuv-gojsonreference [5].
Since those last three are still in testing, my copr build will probably fail, but the queue is a bit weird today.
[1] https://gitlab.com/QuLogic/rpmbuild-specs/commit/9ca0fd8b1ed92c993e053641dfd... [2] https://copr.fedorainfracloud.org/coprs/qulogic/git-lfs/build/511065/ [3] https://bugzilla.redhat.com/show_bug.cgi?id=1405074 [4] https://bugzilla.redhat.com/show_bug.cgi?id=1405067 [5] https://bugzilla.redhat.com/show_bug.cgi?id=1405072
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@gmail.com Flags| |needinfo?(ignatenko@redhat. | |com)
--- Comment #5 from James Hogarth james.hogarth@gmail.com --- Igor are you still planning on packaging this?
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Warren Togami wtogami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wtogami@gmail.com
--- Comment #6 from Warren Togami wtogami@gmail.com --- Any update on this? git-lfs is v2.0.2 upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1336166 | |(golang-github-technoweenie | |-assert) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1336166 [Bug 1336166] Review Request: golang-github-technoweenie-assert - Asserts to Go testomg
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
--- Comment #7 from Elliott Sales de Andrade quantum.analyst@gmail.com --- git-lfs v2.0.1 is available in my copr I linked above. 2.0.2 currently fails to build on F25 as it appears to use a function from Go 1.8.
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Sascha Spreitzer sspreitz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|sspreitz@redhat.com |nobody@fedoraproject.org Flags|needinfo?(sspreitz@redhat.c | |om) | |needinfo?(ignatenko@redhat. | |com) |
--- Comment #8 from Sascha Spreitzer sspreitz@redhat.com --- Hi
I am sorry i have to step down on this package review, due to lack of time.
Kind regards Sascha
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ignatenko@redhat. | |com)
--- Comment #9 from Elliott Sales de Andrade quantum.analyst@gmail.com --- 2.0.2 spec with patch to build on Go 1.7 is here: https://gitlab.com/qulogic-rpms/git-lfs/tree/master/git-lfs
Are you going to continue with this request, Igor?
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ignatenko@redhat. | |com) |
--- Comment #10 from Igor Gnatenko ignatenko@redhat.com --- Sorry, but golang packaging just cumbersome and I'm not interested in being POC for any of golang packages.
Sorry, guys. Still happy to co-maintain, but not primary maintainer.
Feel free to takeover this review request (note that you don't need to create new one, but just give direct links for specs/srpms here and continue review).
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
--- Comment #11 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Here's an updated build spec:
Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x8... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x8...
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
clime@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |clime@redhat.com Assignee|nobody@fedoraproject.org |clime@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
--- Comment #12 from clime@redhat.com --- We will need to resolve blockers first:
https://bugzilla.redhat.com/show_bug.cgi?id=1336161
and
https://bugzilla.redhat.com/show_bug.cgi?id=1336161
https://bugzilla.redhat.com/show_bug.cgi?id=1336168 Bug 1336168 depends on bug 1336159, which changed state.
Bug 1336159 Summary: Review Request: golang-github-rubyist-tracerx - Output tracing information in your Go app based on environment variables https://bugzilla.redhat.com/show_bug.cgi?id=1336159
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1486510
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1486510 [Bug 1486510] Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1336168 Bug 1336168 depends on bug 1336164, which changed state.
Bug 1336164 Summary: Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language https://bugzilla.redhat.com/show_bug.cgi?id=1336164
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1486511
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1486511 [Bug 1486511] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1336168 Bug 1336168 depends on bug 1336161, which changed state.
Bug 1336161 Summary: Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go https://bugzilla.redhat.com/show_bug.cgi?id=1336161
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed| |2017-08-31 18:07:22
--- Comment #13 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Replaced by new RR.
*** This bug has been marked as a duplicate of bug 1487430 ***
https://bugzilla.redhat.com/show_bug.cgi?id=1336168
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|git-lfs |
https://bugzilla.redhat.com/show_bug.cgi?id=1336168 Bug 1336168 depends on bug 1486511, which changed state.
Bug 1486511 Summary: Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go https://bugzilla.redhat.com/show_bug.cgi?id=1486511
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1336168 Bug 1336168 depends on bug 1486510, which changed state.
Bug 1486510 Summary: Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language https://bugzilla.redhat.com/show_bug.cgi?id=1486510
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org