[Bug 1216279] New: Review Request: cppformat - Small, safe and fast formating library for C++ - package-review

List overview All Threads
Download

newer

[Bug 1216279] New: Review Request: cppformat - Small, safe and fast formating library for C++

older

[Bug 1211086] New: Review Request:...

[Bug 1277203] New: Review Request:...

Red Hat Bugzilla

28 Apr 2015 28 Apr '15

9:03 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Bug ID: 1216279 Summary: Review Request: cppformat - Small, safe and fast formating library for C++ Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: davejohansen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://daveisfera.fedorapeople.org/cppformat_1.1.0/cppformat.spec SRPM URL: https://daveisfera.fedorapeople.org/cppformat_1.1.0/cppformat-1.1.0-1.fc21.s... Description: cppformat is a safe alternative to printf and a fast alternative to IOStreams. Fedora Account System Username: daveisfera

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

6 May 6 May

3:22 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) bugs.michael@gmx.net ---

...

License: BSD

https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

...

Patch0: cppformat_so_name.patch Patch1: cppformat_lib64.patch

https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines

...

%files doc %doc doc/html/

...

%package doc Requires: %{name}%{?_isa} = %{version}-%{release}

Even if the guidelines don't say anything about it [yet], please keep plain documentation packages free from superfluous dependencies. This -doc package certainly does _not_ need the base library package to be installed. It is much more convenient, if documentation packages can be installed without pulling in unnecessary dependency-chains.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:32 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #2 from Dave Johansen davejohansen@gmail.com --- I fixed all of the issues below with the details below. The update .spec and source .rpm can be found at the same links as before.

(In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #1)

...

...
License: BSD

https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

I extracted the LICENSE from README.rst and included it in the base package (please let me know if it's need to be in the -devel package). I also emailed upstream to request that it be added to the source distribution for a future release.

...

...
Patch0: cppformat_so_name.patch Patch1: cppformat_lib64.patch

https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines

I added references to the commits where these issues have been fixed upstream for a future release.

...

...
%files doc %doc doc/html/

...
%package doc Requires: %{name}%{?_isa} = %{version}-%{release}

Even if the guidelines don't say anything about it [yet], please keep plain documentation packages free from superfluous dependencies. This -doc package certainly does _not_ need the base library package to be installed. It is much more convenient, if documentation packages can be installed without pulling in unnecessary dependency-chains.

Sorry, this was a copy and paste error from the -devel package.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Jul 8 Jul

2:38 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Antonio Trande anto.trande@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9 Jul 9 Jul

5:30 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #3 from Antonio Trande anto.trande@gmail.com --- - [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files

doc/html/_static/bootstrap-3.2.0/fonts/glyphicons-halflings-regular.ttf is a font file already in Fedora (glyphicons-halflings-fonts RPM).

- cppformat.i686: W: unused-direct-shlib-dependency /usr/lib/libformat.so.1.1.0 /lib/libm.so.6

See https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/C...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Jul 10 Jul

9:58 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #4 from Dave Johansen davejohansen@gmail.com --- Both of those issues should now be resolved.

The latest version of the .spec and source .rpm can be found at: Spec URL: https://daveisfera.fedorapeople.org/cppformat_1.1.0/cppformat.spec SRPM URL: https://daveisfera.fedorapeople.org/cppformat_1.1.0/cppformat-1.1.0-1.fc21.s...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11 Jul 11 Jul

3:22 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #5 from Antonio Trande anto.trande@gmail.com --- (In reply to Dave Johansen from comment #4)

...

Both of those issues should now be resolved.

The latest version of the .spec and source .rpm can be found at: Spec URL: https://daveisfera.fedorapeople.org/cppformat_1.1.0/cppformat.spec SRPM URL: https://daveisfera.fedorapeople.org/cppformat_1.1.0/cppformat-1.1.0-1.fc21. src.rpm

1) # Extract the LICENSE (fixed upstream see https://github.com/cppformat/cppformat/commit/fde90aa551cb3cf77624b72a166144... ) grep "^License" -A 25 ~/rpmbuild/BUILD/cppformat-1.1.0/README.rst | tail -n 21

...

LICENSE

# Remove the packaged font find -name "*.ttf" -delete

These two commands don't work:

+ grep '^License' -A 25 /builddir/rpmbuild/BUILD/cppformat-1.1.0/README.rst + tail -n 21 grep: /builddir/rpmbuild/BUILD/cppformat-1.1.0/README.rst: No such file or directory

README.rst is not found; try

grep "^License" -A 25 README.rst | tail -n 21 > LICENSE

+ find -name '*.ttf' -delete + exit 0

doc/html/_static/bootstrap-3.2.0/fonts/glyphicons-halflings-regular.ttf is still there.

Are you sure it's sufficient remove it? Once done, is html documentation correctly displayable?

2) -doc subpackage is a noarch package.

3) -doc subpackage does not provide its own LICENSE.python file.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

14 Jul 14 Jul

8:47 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #6 from Dave Johansen davejohansen@gmail.com --- (In reply to Antonio Trande from comment #5)

...

These two commands don't work:

grep '^License' -A 25 /builddir/rpmbuild/BUILD/cppformat-1.1.0/README.rst

tail -n 21

grep: /builddir/rpmbuild/BUILD/cppformat-1.1.0/README.rst: No such file or directory

README.rst is not found; try

grep "^License" -A 25 README.rst | tail -n 21 > LICENSE

Sorry, copy and paste error that I missed there. It's fixed now.

...

find -name '*.ttf' -delete

Are you sure it's sufficient remove it? Once done, is html documentation correctly displayable?

It appears that it would display but not with the correct font. It looks like there's a bit of a mixed opinion, but just leaving the font is acceptable and done by several existing packages: https://lists.fedoraproject.org/pipermail/devel/2015-July/212293.html

...

-doc subpackage is a noarch package.

Fixed arch for -doc.

...

-doc subpackage does not provide its own LICENSE.python file.

Added LICENSE.python to -doc.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Jul 16 Jul

12:13 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #7 from Antonio Trande anto.trande@gmail.com --- - Exist some hidden directories in the -doc package. Please check if they can be removed.

- Source0 link is not valid; use this form:

https://github.com/cppformat/cppformat/archive/1.1.0.zip#/%%7Bname%7D-%%7Bve...

- cppformat.x86_64: W: private-shared-object-provides /usr/lib64/libformat.so.1.1.0 libformat.so.1()(64bit)

See https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/C...

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/sagitter/1216279-cppformat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files

See comment#6.

[-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cppformat-doc [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: cppformat-1.1.0-1.fc23.x86_64.rpm cppformat-devel-1.1.0-1.fc23.x86_64.rpm cppformat-doc-1.1.0-1.fc23.noarch.rpm cppformat-1.1.0-1.fc23.src.rpm cppformat.x86_64: W: spelling-error %description -l en_US printf -> print, prints, print f cppformat.x86_64: W: no-documentation cppformat-devel.x86_64: W: only-non-binary-in-usr-lib cppformat-devel.x86_64: W: no-documentation cppformat-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cppformat-doc/html/_static/jquery.js cppformat-doc.noarch: W: hidden-file-or-dir /usr/share/doc/cppformat-doc/html/.buildinfo cppformat-doc.noarch: W: hidden-file-or-dir /usr/share/doc/cppformat-doc/html/.doctrees cppformat-doc.noarch: W: hidden-file-or-dir /usr/share/doc/cppformat-doc/html/.doctrees cppformat.src: W: spelling-error %description -l en_US printf -> print, prints, print f cppformat.src: W: invalid-url Source0: https://github.com/cppformat/cppformat/releases/download/1.1.0/cppformat-1.1... HTTP Error 403: Forbidden 4 packages and 0 specfiles checked; 0 errors, 10 warnings.

Rpmlint (debuginfo) ------------------- Checking: cppformat-debuginfo-1.1.0-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory cppformat.x86_64: W: private-shared-object-provides /usr/lib64/libformat.so.1.1.0 libformat.so.1()(64bit) cppformat.x86_64: W: no-documentation cppformat-devel.x86_64: W: only-non-binary-in-usr-lib cppformat-devel.x86_64: W: no-documentation cppformat-doc.noarch: W: hidden-file-or-dir /usr/share/doc/cppformat-doc/html/.doctrees cppformat-doc.noarch: W: hidden-file-or-dir /usr/share/doc/cppformat-doc/html/.doctrees cppformat-doc.noarch: W: hidden-file-or-dir /usr/share/doc/cppformat-doc/html/.buildinfo cppformat-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cppformat-doc/html/_static/jquery.js 4 packages and 0 specfiles checked; 0 errors, 8 warnings.

Requires -------- cppformat (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH)

cppformat-devel (rpmlib, GLIBC filtered): cppformat(x86-64) libformat.so.1()(64bit)

cppformat-doc (rpmlib, GLIBC filtered):

Provides -------- cppformat: cppformat cppformat(x86-64) libformat.so.1()(64bit)

cppformat-devel: cppformat-devel cppformat-devel(x86-64)

cppformat-doc: cppformat-doc

Source checksums ---------------- https://github.com/cppformat/cppformat/releases/download/1.1.0/cppformat-1.1... : CHECKSUM(SHA256) this package : bfa5db9d5bafe079b711981c336ec33b3980715aadf89efc7855aca507845a0e CHECKSUM(SHA256) upstream package : bfa5db9d5bafe079b711981c336ec33b3980715aadf89efc7855aca507845a0e

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1216279 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Aug 15 Aug

11:15 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #8 from Dave Johansen davejohansen@gmail.com --- (In reply to Antonio Trande from comment #7)

...

Exist some hidden directories in the -doc package. Please check if they can be removed.

I removed them and notified upstream.

...

Source0 link is not valid; use this form:

https://github.com/cppformat/cppformat/archive/1.1.0.zip#/%%7Bname%7D-%%7Bve.... zip

The link is actually valid. It's just that github doesn't like the way that rpmlint does the request. I would switch to the recommended URL but the URL I'm using right now is a release that contains the built documentation. I'm watching on packaging the requirements to build the packaging in Fedora, but for now the current URL is probably the beset option.

...

cppformat.x86_64: W: private-shared-object-provides

/usr/lib64/libformat.so.1.1.0 libformat.so.1()(64bit)

See https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/ Common_Rpmlint_Issues#private-shared-object-provides

I believe that this is actually a false warning. I opened a bugzilla (see https://bugzilla.redhat.com/show_bug.cgi?id=1253917 ).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Aug 30 Aug

10:13 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #9 from Dave Johansen davejohansen@gmail.com --- Is there anything else that needs to be done for this to be approved?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

31 Aug 31 Aug

4:37 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Antonio Trande anto.trande@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #10 from Antonio Trande anto.trande@gmail.com --- Package approved.

Note: The'private-shared-object-provides' issue is not solved yet. See https://bugzilla.redhat.com/show_bug.cgi?id=1253917

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/sagitter/1216279-cppformat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cppformat-doc [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Rpmlint ------- Checking: cppformat-1.1.0-1.fc24.x86_64.rpm cppformat-devel-1.1.0-1.fc24.x86_64.rpm cppformat-doc-1.1.0-1.fc24.noarch.rpm cppformat-1.1.0-1.fc24.src.rpm cppformat.x86_64: W: spelling-error %description -l en_US printf -> print, prints, print f cppformat.x86_64: W: no-documentation cppformat-devel.x86_64: W: only-non-binary-in-usr-lib cppformat-devel.x86_64: W: no-documentation cppformat-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cppformat-doc/html/_static/jquery.js cppformat.src: W: spelling-error %description -l en_US printf -> print, prints, print f cppformat.src: W: invalid-url Source0: https://github.com/cppformat/cppformat/releases/download/1.1.0/cppformat-1.1... HTTP Error 403: Forbidden 4 packages and 0 specfiles checked; 0 errors, 7 warnings.

Rpmlint (debuginfo) ------------------- Checking: cppformat-debuginfo-1.1.0-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

cppformat-devel (rpmlib, GLIBC filtered): cppformat(x86-64) libformat.so.1()(64bit)

cppformat-doc (rpmlib, GLIBC filtered):

Provides -------- cppformat: cppformat cppformat(x86-64) libformat.so.1()(64bit)

cppformat-devel: cppformat-devel cppformat-devel(x86-64)

cppformat-doc: cppformat-doc

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2 Sep 2 Sep

5:52 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Dave Johansen davejohansen@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #11 from Dave Johansen davejohansen@gmail.com --- New Package SCM Request ======================= Package Name: cppformat Short Description: Small, safe and fast formatting library for C++ Upstream URL: https://github.com/cppformat/cppformat Owners: daveisfera Branches: f21 f22 f23 el6 epel7 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Sep 3 Sep

8:21 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:21 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Sep 6 Sep

12:39 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7966

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:39 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:39 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15219

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:39 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15221

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Sep 7 Sep

1:19 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15220

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1:21 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15221

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:50 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15219

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7967

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:08 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #20 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7966

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Sep 10 Sep

11:25 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #21 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15583

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:25 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED

--- Comment #21 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15583

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:25 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #22 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15585

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:27 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #23 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8033

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:28 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #24 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8034

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11 Sep 11 Sep

2:52 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #25 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15583

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:54 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #26 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15585

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:33 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #27 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8033

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:59 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #28 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8034

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Sep 12 Sep

4:25 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #29 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update cppformat'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15584

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Nov 1 Nov

3:53 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #30 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:53 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:22 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #31 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:21 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #32 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Nov 3 Nov

9:24 a.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #33 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Nov 5 Nov

12:56 p.m.

New subject: [Bug 1216279] Review Request: cppformat - Small, safe and fast formating library for C++

https://bugzilla.redhat.com/show_bug.cgi?id=1216279

--- Comment #34 from Fedora Update System updates@fedoraproject.org --- cppformat-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3548

Age (days ago)

3738

Last active (days ago)

package-review@lists.fedoraproject.org

39 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla