[Bug 2276780] New: Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

            Bug ID: 2276780
           Summary: Review Request: python-drain3 - Persistent & streaming
                    log template miner
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: msuchy(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/msuchy/package-review/...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/msuchy/package-review/...
Description: 
Drain3 is an online log template miner that can extract templates (clusters)
from a stream of log messages in a timely manner. It employs a parse tree with
fixed depth to guide the log group search process, which effectively avoids
constructing a very deep and unbalanced tree.
Fedora Account System Username: msuchy

I have decided to package snapshot version of Drain3 because the last release
was done long ago and would be pain to satisfy the dependencies.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Jakub Kadlčík <jkadlcik(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|nobody(a)fedoraproject.org    |jkadlcik(a)redhat.com
             Status|NEW                         |ASSIGNED




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780



--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
>  %global commit 76d12defdeec14da3794d451875b781669f62acf
>  Version:        0.9.11 
Should we point the package to a git tag instead of a commit, since it is
available? Also, this commit doesn't seem to be the one corresponding with the
0.9.11 release. I would expect 78d3cae4bcac329c4e4f275d416562e10c5c446e


>  #%%autosetup -p1 -n drain3-%%{version}
>  find 
Probably some leftover from debugging

>  # For official Fedora packages, including files with '*'
> +auto is not allowed
>  # Replace it with a list of relevant Python modules/globs and list extra files in
> %%files
>  %pyproject_save_files '*' +auto 
Should probably be 
%pyproject_save_files 'drain3'


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780



--- Comment #2 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
The fedora-review tool also complained about:

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780



--- Comment #3 from Miroslav Suchý <msuchy(a)redhat.com&gt; ---
>  Should we point the package to a git tag instead of a commit, since
> it is available?  
No. The 0.9.11 is two years old release. Therefore I packaged last commit. I
put a comment to spec to explain it.

I believe that I resolved all other issues (thank you for them).

Spec URL:
https://download.copr.fedorainfracloud.org/results/msuchy/package-review/...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/msuchy/package-review/...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780



--- Comment #4 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share, /usr, /usr/lib/python3.12,
     /usr/lib, /usr/share/licenses, /usr/lib/python3.12/site-packages,
     /usr/share/doc
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr, /usr/lib/python3.12,
     /usr/lib, /usr/share/licenses, /usr/share, /usr/lib/python3.12/site-
     packages, /usr/share/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 19325 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-drain3-0.9.11-20240424git76d12de.1.fc41.noarch.rpm
          python-drain3-0.9.11-20240424git76d12de.1.fc41.src.rpm
============================================================================================================
rpmlint session starts
===========================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmptmm8n2a6')]
checks: 32, packages: 2

======================================================================= 2
packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness;
has taken 0.8 s
======================================================================




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/logpai/Drain3/archive/76d12defdeec14da3794d451875b7816...
:
  CHECKSUM(SHA256) this package     :
32915d64a2b5637f9d58cca33095bc147c9cc754e69b718a011ca30a2d8aa4c5
  CHECKSUM(SHA256) upstream package :
32915d64a2b5637f9d58cca33095bc147c9cc754e69b718a011ca30a2d8aa4c5


Requires
--------
python3-drain3 (rpmlib, GLIBC filtered):
    python(abi)
    python3.12dist(cachetools)
    python3.12dist(jsonpickle)



Provides
--------
python3-drain3:
    python-drain3
    python3-drain3
    python3.12-drain3
    python3.12dist(drain3)
    python3dist(drain3)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2276780
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: SugarActivity, Java, R, PHP, C/C++, fonts, Perl, Haskell,
Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Jakub Kadlčík <jkadlcik(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST



--- Comment #5 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-drain3


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-de8f7576e2 (python-drain3-0.9.11-20240424git76d12de.1.fc40) has
been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-de8f7576e2


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-de8f7576e2 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-de8f7576e2 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-de8f7576e2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276780] Review Request: python-drain3 - Persistent & streaming log template miner

https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-05-12 04:17:10



--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-de8f7576e2 (python-drain3-0.9.11-20240424git76d12de.1.fc40) has
been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276780

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...