https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Bug ID: 1420100 Summary: Review Request: perl-Mail-Transport - Email message exchange code Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: tcallawa@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://spot.fedorapeople.org/perl-Mail-Transport.spec SRPM URL: https://spot.fedorapeople.org/perl-Mail-Transport-3.000-1.fc26.src.rpm Description: Email message exchange code, formerly part of the Mail::Box package. Fedora Account System Username: spot
Note: This component used to be part of perl-Mail-Box, but was split off in 3.000.
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1420099
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1420099 [Bug 1420099] Review Request: perl-Mail-Message
https://bugzilla.redhat.com/show_bug.cgi?id=1420100 Bug 1420100 depends on bug 1420099, which changed state.
Bug 1420099 Summary: Review Request: perl-Mail-Message - MIME message handling https://bugzilla.redhat.com/show_bug.cgi?id=1420099
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- I can't build the package from source due to conflict between perl-Mail-Message-3.000-3.fc26.noarch and perl-Mail-Box-2.120-2.fc26.noarch
https://koji.fedoraproject.org/koji/taskinfo?taskID=17969963
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- You should create sub-packages for following modules: * Mail::Message * Mail::Transport * Mail::Box::IMAP4 * Mail::Box::POP3 * Mail::Box::Dbx
before update to Mail-Box-3.001 to prevent these conflicts.
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
--- Comment #3 from Tom "spot" Callaway tcallawa@redhat.com --- perl-Mail-Box-2.120-3.fc26 has the subpackages split out.
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
$ rpm -qp --requires perl-Mail-Transport-3.000-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(Carp) 1 perl(Errno) 1 perl(File::Spec) 1 perl(Mail::Reporter) 1 perl(Mail::Transport) 1 perl(Mail::Transport::Send) 1 perl(Net::SMTP) 1 perl(base) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add run-requires - perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75
$ rpm -qp --provides perl-Mail-Transport-3.000-1.fc26.noarch.rpm | sort | uniq -c 1 perl(Mail::Transport) = 3.000 1 perl(Mail::Transport::Exim) = 3.000 1 perl(Mail::Transport::Mailx) = 3.000 1 perl(Mail::Transport::Qmail) = 3.000 1 perl(Mail::Transport::Receive) = 3.000 1 perl(Mail::Transport::SMTP) = 3.000 1 perl(Mail::Transport::Send) = 3.000 1 perl(Mail::Transport::Sendmail) = 3.000 1 perl-Mail-Transport = 3.000-1.fc26 Binary provides are Ok.
$ rpmlint ./perl-Mail-Transport* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok
BuildRequires FIX: Please add following build-requires: - coreutils - because 'rm' is used in spec file - findutils - 'find' is used in spec file - make - is used in spec file - perl or %{__perl} - it is used in spec file - perl(base) - Mail-Transport-3.000/lib/Mail/Transport.pm:12 - perl(IO::Handle) - Mail-Transport-3.000/Makefile.PL:5 - perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75 - perl(strict) - modules and tests - perl(Test::More) - tests - perl(vars) - modules - perl(warnings) - modules and tests
FIX: Please remove __requires_exclude of Mail::SpamAssassin, it is not needed. TODO: It will be better placed %{?perl_default_filter} before %description.
If you want to add the package to EPEL, please ignore these two TODO TODO: The easier way to remove .packlist is used NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be used in all Fedoras. The command is %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras.
Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file.
Not approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com Flags| |needinfo?(tcallawa@redhat.c | |om)
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Any progress?
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1431128
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1431128 [Bug 1431128] Upgrade perl-Mail-Box to 3.001
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tcallawa@redhat.c | |om) |
--- Comment #6 from Tom "spot" Callaway tcallawa@redhat.com --- Sorry. Been traveling.
All non-EPEL items fixed.
New SRPM: https://spot.fedorapeople.org/perl-Mail-Transport-3.000-2.fc26.src.rpm New SPEC: https://spot.fedorapeople.org/perl-Mail-Transport.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Jitka Plesnikova jplesnik@redhat.com ---
FIX: Please add run-requires
- perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75
+Requires: perl(IO::Lines) Ok.
FIX: Please add following build-requires:
- coreutils - because 'rm' is used in spec file
- findutils - 'find' is used in spec file
- make - is used in spec file
- perl or %{__perl} - it is used in spec file
- perl(base) - Mail-Transport-3.000/lib/Mail/Transport.pm:12
- perl(IO::Handle) - Mail-Transport-3.000/Makefile.PL:5
- perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75
- perl(strict) - modules and tests
- perl(Test::More) - tests
- perl(vars) - modules
- perl(warnings) - modules and tests
+BuildRequires: perl +BuildRequires: perl(base) +BuildRequires: perl(IO::Handle) +BuildRequires: perl(IO::Lines) +BuildRequires: perl(strict) +BuildRequires: perl(Test::More) +BuildRequires: perl(vars) +BuildRequires: perl(warnings) +BuildRequires: coreutils +BuildRequires: findutils +BuildRequires: make Ok.
FIX: Please remove __requires_exclude of Mail::SpamAssassin, it is not needed.
-#%%global __requires_exclude %%{?__requires_exclude:%%__requires_exclude|}^perl\(Mail::SpamAssassin[:\)] Ok.
TODO: It will be better placed %{?perl_default_filter} before %description.
Ok.
TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
Please consider fixing 'TODO' item.
Otherwise package looks good. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Mail-Transport
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Mail-Box-3.002-1.fc26 perl-Mail-Transport-3.000-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fda53d1ef7
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Mail-Box-3.002-1.fc26, perl-Mail-Transport-3.000-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fda53d1ef7
https://bugzilla.redhat.com/show_bug.cgi?id=1420100
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-06-09 15:23:45
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Mail-Box-3.002-1.fc26, perl-Mail-Transport-3.000-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com