https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Bug ID: 1372454 Summary: Review Request: bwrap-oci - run OCI containers with bubblewrap Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: gscrivan@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/projectatomic/bwrap-oci/blob/master/bwrap-oci.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/gscrivano/bwrap-oci/fedora-2...
Description: run an OCI container through bubblewrap.
Fedora Account System Username: gscrivano
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ignatenko@redhat.com Flags| |fedora-review?
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com --- 1. Spec is not downloadable 2. SourceURL is unreachable
%global commit0 06ed9c9054db435ae33f0c917a2d5e7d3e40e6fa
drop this, as you don't build from commit
Source0: https://github.com/projectatomic/%%7Bname%7D/archive/%%7Bname%7D-%%7Bversion...
%global rel 3 Source0: %{url}/archive/%{name}-%{version}-%{rel}.tar.gz
BuildRequires: git
not really
BuildRequires: docbook-style-xsl
looks like you don't need it
BuildRequires: libxslt
looks like you don't need it
BuildRequires: json-glib-devel
BuildRequires: pkgconfig(json-glib-1.0)
%autosetup -Sgit -n %{name}-%{version}
%autosetup -n %{name}-%{name}-%{version}-%{rel}
make %{?_smp_mflags}
%make_build
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p -c"
%make_install INSTALL="install -p"
find $RPM_BUILD_ROOT -name '*.la' -delete
not needed, you don't have any libtool files
%{_mandir}/man1/*
%%{_mandir}/man1/%{name}.1*
%{_bindir}/bwrap-oci
%{_bindir}/%{name}
* Missing BuildRequires: gcc * Missing BuildRequires: pkgconfig(gio-unix-2.0) * My recommendation - stop using tito ASAP, otherwise you will stick to it and always will have to do double work.
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
--- Comment #2 from Igor Gnatenko ignatenko@redhat.com --- Also no changelog.
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
--- Comment #3 from Giuseppe Scrivano gscrivan@redhat.com --- Thanks for the quick review, I have updated the spec file with your comments:
https://raw.githubusercontent.com/projectatomic/bwrap-oci/master/bwrap-oci.s...
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Summary|Review Request: bwrap-oci - |Review Request: bwrap-oci - |run OCI containers with |Run OCI containers with |bubblewrap |bubblewrap Flags|fedora-review? |fedora-review+
--- Comment #4 from Igor Gnatenko ignatenko@redhat.com --- Things which are still not fixed. * %{_mandir}/man1/* * %{_bindir}/bwrap-oci * Summary: Core execution tool for unprivileged containers
P.S. Summary is copied from bubblewrap, but it's different project. Change it to "Run OCI containers with bubblewrap"
Just fix this stuff during import.
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Assignee|ignatenko@redhat.com |nobody@fedoraproject.org
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |NEW
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Patrick Uiterwijk puiterwijk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puiterwijk@redhat.com Blocks|177841 (FE-NEEDSPONSOR) | Assignee|nobody@fedoraproject.org |puiterwijk@redhat.com
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/bwrap-oci
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Giuseppe Scrivano gscrivan@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2016-09-02 10:38:05
https://bugzilla.redhat.com/show_bug.cgi?id=1372454
Daniel Walsh dwalsh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dwalsh@redhat.com
--- Comment #6 from Daniel Walsh dwalsh@redhat.com --- Good job.
package-review@lists.fedoraproject.org