Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: chromaprint - Library implementing the AcoustID fingerprinting
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Summary: Review Request: chromaprint - Library implementing the AcoustID fingerprinting Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ismael@olea.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://olea.org/tmp/chromaprint-rpms/chromaprint.spec SRPM URL: http://olea.org/tmp/chromaprint-rpms/chromaprint-0.5-2.fc15.src.rpm
Description: Chromaprint library is the core component of the AcoustID project. It's a client-side library that implements a custom algorithm for extracting fingerprints from raw audio sources.
The library exposes a simple C API and the package also includes bindings for the Python language. The documentation for the C API can be found in the main header file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Alex Lancaster alexl@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |chromaprint
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Nikos Roussos nikos@autoverse.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nikos@autoverse.net AssignedTo|nobody@fedoraproject.org |nikos@autoverse.net Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #1 from Nikos Roussos nikos@autoverse.net 2011-12-04 15:54:51 EST --- Is there any reason why you use the %{__rm} macro. According to the Packaging Guidelines this should be avoided.
On the contrary you should use the %{__python} macro instead of python.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #2 from Ismael Olea ismael@olea.org 2011-12-05 13:06:27 EST ---
Both things are fixed.
Uploading the updates: Spec URL: http://olea.org/tmp/chromaprint-rpms/chromaprint.spec SRPM URL: http://olea.org/tmp/chromaprint-rpms/chromaprint-0.5-3.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #3 from Nikos Roussos nikos@autoverse.net 2011-12-06 05:02:33 EST --- It seems ok. Here is the review
+: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clarification needed N: not applicable
MUST: [+] rpmlint output: shown in comment: none [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: LGPLv2+ [+] license field matches the actual license. [+] license file is included in %doc: COPYING.txt [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches [+] package builds on at least one primary arch: Tested F16 x86_64 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [+] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [N] no runtime dependencies in %doc [+] header files in -devel [N] static libraries in -static [+] .so in -devel [+] -devel requires main package [+] package contains no libtool archives [N] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8
SHOULD: [N] query upstream for license text [=] description and summary contains available translations [+] package builds in mock [=] package builds on all supported arches: Tested x86_64 [+] package functions as described: [N] sane scriptlets [+] subpackages require the main package [+] placement of pkgconfig files [+] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts
*** APPROVED ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #4 from Christoph Wickert cwickert@fedoraproject.org 2011-12-06 05:16:32 EST --- Requires: libchromaprint = %{version}-%{release}
should be
Requires: libchromaprint%{?_isa} = %{version}-%{release}
See https://fedoraproject.org/wiki/Packaging:Guidelines#Requires
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #5 from Christoph Wickert cwickert@fedoraproject.org 2011-12-06 05:22:49 EST --- %{__python} setup.py install --root=%{buildroot}
should be
%{__python} setup.py install -O1 --skip-build --root %{buildroot}
The rest looks good to me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #6 from Christoph Wickert cwickert@fedoraproject.org 2011-12-06 05:24:19 EST --- Nikos, please don't forget to set a review to "assigned" when you take it over and to set "fedora-review+" when you are done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Nikos Roussos nikos@autoverse.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Nikos Roussos nikos@autoverse.net 2011-12-06 05:35:06 EST --- Sorry Christoph, you 're right!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #8 from Ismael Olea ismael@olea.org 2011-12-07 12:27:53 EST ---
@Christoph: Just added your suggestions.
Thanks both!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #9 from Ismael Olea ismael@olea.org 2011-12-07 12:30:37 EST --- New Package SCM Request ======================= Package Name: chromaprint Short Description: Library implementing the AcoustID fingerprinting Owners: olea Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Ismael Olea ismael@olea.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #10 from Jon Ciesla limburgher@gmail.com 2011-12-07 12:47:16 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-12-09 16:24:43 EST --- chromaprint-0.5-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/chromaprint-0.5-4.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-12-09 16:24:55 EST --- chromaprint-0.5-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/chromaprint-0.5-4.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-12-11 16:49:46 EST --- chromaprint-0.5-4.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |chromaprint-0.5-4.fc16 Resolution| |ERRATA Last Closed| |2011-12-12 17:03:24
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-12-12 17:03:24 EST --- chromaprint-0.5-4.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755066
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|chromaprint-0.5-4.fc16 |chromaprint-0.5-4.fc15
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-12-21 12:09:34 EST --- chromaprint-0.5-4.fc15 has been pushed to the Fedora 15 stable repository.
package-review@lists.fedoraproject.org