Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-rack - Common API for connecting web frameworks, web servers and layers of software
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Summary: Review Request: rubygem-rack - Common API for connecting web frameworks, web servers and layers of software Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kanarip@kanarip.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-rack.spec SRPM URL: http://www.kanarip.com/custom/f9/SRPMS/rubygem-rack-0.4.0-1.fc9.src.rpm
Description: Rack provides a common API for connecting web frameworks, web servers and layers of software in between
rpmlint: silent
koji scratch builds:
- dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=922924 - dist-f9-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=922926 - dist-f10-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=922928 - dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=922930
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |470696
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-11-09 09:10:34 EDT --- For 0.4.0-1
* ruby(abi) dependency - Please check https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
* Unused macro - %ruby_sitelib does not to be used anywhere.
* Dependency - Please check if all needed Requires are added properly. ! For example, lib/rack/handler/mongrel.rb contains ---------------------------------------------------------- 1 require 'mongrel' 2 require 'stringio' ---------------------------------------------------------- So this file has "Requires: rubygem(mongrel)". However I don't know if this file itself is just optional or not. Anyway please check if all dependencies are correctly added.
* %gemdir/bin - I guess files under %gemdir/bin must be moved into %_bindir (ref: rubygem-mongrel.spec)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #2 from Jeroen van Meeuwen kanarip@kanarip.com 2008-11-09 09:28:39 EDT --- (In reply to comment #1)
For 0.4.0-1
- ruby(abi) dependency
Stupid /me, I always somehow forget this one. Fixed.
- Unused macro
- %ruby_sitelib does not to be used anywhere.
Fixed.
- Dependency
- Please check if all needed Requires are added properly. ! For example, lib/rack/handler/mongrel.rb contains
1 require 'mongrel' 2 require 'stringio'
So this file has "Requires: rubygem(mongrel)". However I don't know if this file itself is just optional or not. Anyway please check if all dependencies are correctly added.
This is entirely optional, it is one of the handlers -rack can cope with (amongst others; fastcgi and webrick)
- %gemdir/bin
- I guess files under %gemdir/bin must be moved into %_bindir (ref: rubygem-mongrel.spec)
Fixed.
New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-rack.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/rubygem-rack-0.4.0-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-11-10 02:28:46 EDT --- Well, * In comments and %changelog, please use %% instead of % so that macros won't be expanded. (Please fix this on Fedora CVS)
Other things are okay. --------------------------------------------------------------------- This package (rubygem-rack) is APPROVED by mtasaka ---------------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(kanarip@kanarip.c | |om)
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-11-20 09:47:55 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-11-27 03:00:43 EDT --- ping again?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(kanarip@kanarip.c | |om) |
--- Comment #6 from Jeroen van Meeuwen kanarip@kanarip.com 2008-11-27 11:37:29 EDT --- Sorry this one has slipped through the cracks; I've resolved the %% issue now ;-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Jeroen van Meeuwen kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Jeroen van Meeuwen kanarip@kanarip.com 2008-11-27 11:37:48 EDT --- New Package CVS Request ======================= Package Name: rubygem-rack Short Description: Common API for connecting web frameworks, web servers and layers of software Owners: kanarip Branches: EL-4 EL-5 F-9 F-10 devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2008-12-01 15:43:54 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2008-12-07 11:08:27 EDT --- For F-10/9 please submit push requests on bodhi: https://admin.fedoraproject.org/updates/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2008-12-08 07:40:57 EDT --- rubygem-rack-0.4.0-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/rubygem-rack-0.4.0-2.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2008-12-08 07:42:18 EDT --- rubygem-rack-0.4.0-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/rubygem-rack-0.4.0-2.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2008-12-09 06:36:12 EDT --- rubygem-rack-0.4.0-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470694
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2008-12-09 06:37:45 EDT --- rubygem-rack-0.4.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org