[Bug 1305154] New: Review Request: python-notario - A dictionary validator - package-review

List overview All Threads
Download

newer

[Bug 1305154] New: Review Request: python-notario - A dictionary validator

older

[Bug 1307130] New: Review Request:...

[Bug 1309795] New: Review Request:...

Red Hat Bugzilla

5 Feb 2016 5 Feb '16

9:30 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Bug ID: 1305154 Summary: Review Request: python-notario - A dictionary validator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ktdreyer@ktdreyer.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://fedorapeople.org/cgit/ktdreyer/public_git/python-notario.git/plain/p... SRPM URL: https://ktdreyer.fedorapeople.org/reviews/python-notario-0.0.8-1.fc24.src.rp... Description: Notario is flexible and succinct Python dictionary validator with the ability to validate against both keys and values. Schemas are smaller and readable representations of data being validated.

Fedora Account System Username: ktdreyer

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

5 Feb 5 Feb

9:31 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #1 from Ken Dreyer ktdreyer@ktdreyer.com --- Rawhide (F24) scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12894211

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Feb 15 Feb

8:10 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #2 from Ken Dreyer ktdreyer@ktdreyer.com --- Changes from earlier version:

- Update to latest upstream release - Fall back to older python macros. The newer python macros are only available in EPEL 7, not RHEL 7 (see rhbz#1306861). Add fallbacks so we can still build and install on RHEL 7. - Use HTTPS upstream URLs.

Spec URL: https://ktdreyer.fedorapeople.org/reviews/python-notario.spec SRPM: URL: https://ktdreyer.fedorapeople.org/reviews/python-notario-0.0.9-1.fc24.src.rp...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Mar 1 Mar

5:16 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #3 from Ken Dreyer ktdreyer@ktdreyer.com --- New version:

* Tue Mar 01 2016 Ken Dreyer ktdreyer@ktdreyer.com - 0.0.11-1 - Update to latest upstream release - Drop older python macros.

Spec URL: https://ktdreyer.fedorapeople.org/reviews/python-notario.spec SRPM: URL: https://ktdreyer.fedorapeople.org/reviews/python-notario-0.0.11-1.fc25.src.r...

Exact changes in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/python-notario.git/commit/...

Rawhide (F25) scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13190025

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:18 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- ktdreyer's scratch build of python-notario-0.0.11-1.fc25.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13190025

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:18 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Boris Ranto branto@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2 Mar 2 Mar

10:10 a.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #5 from Boris Ranto branto@redhat.com --- Ken, there are just two minor things:

- we should use %global instead of %define in the .spec file (you use %define srcname notario)

- rpmlint (spell check) complains that Schemas should be Schemes

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:54 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Ken Dreyer ktdreyer@ktdreyer.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

--- Comment #6 from Ken Dreyer ktdreyer@ktdreyer.com --- Thanks for the %global catch. I've fixed it in this latest version. (I think the rpmlint spelling check thing is a false positive; Google indicates that schemas is an acceptable plural form of schema).

* Wed Mar 02 2016 Ken Dreyer ktdreyer@ktdreyer.com - 0.0.11-2 - Use %%global macro instead of %%define (rhbz#1305154)

Spec URL: https://ktdreyer.fedorapeople.org/reviews/python-notario.spec SRPM: URL: https://ktdreyer.fedorapeople.org/reviews/python-notario-0.0.11-2.fc25.src.r...

Exact changes in Git: https://fedorapeople.org/cgit/ktdreyer/public_git/python-notario.git/commit/...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:54 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #7 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- ktdreyer's scratch build of python-notario-0.0.11-2.fc25.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13203753

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Mar 3 Mar

10:39 a.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Boris Ranto branto@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #8 from Boris Ranto branto@redhat.com --- Yeah, it looks like schemas is a false positive, still a better one than what it suggested for what 'validator' should (see the rpmlint part of the review report if you want to know :-) ).

I'm attaching the review report:

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)" [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.5/site-packages, /usr/lib/python3.5 -- both owned by python [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.5/site- packages, /usr/lib/python3.5 -- owned by python [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-notario , python3-notario [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define srcname notario [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: python2-notario-0.0.11-1.fc25.noarch.rpm python3-notario-0.0.11-1.fc25.noarch.rpm python-notario-0.0.11-1.fc25.src.rpm python2-notario.noarch: W: spelling-error Summary(en_US) validator -> lavatorial python2-notario.noarch: W: spelling-error %description -l en_US validator -> lavatorial python2-notario.noarch: W: spelling-error %description -l en_US Schemas -> Schema, Sachems, Schemes python3-notario.noarch: W: spelling-error Summary(en_US) validator -> lavatorial python3-notario.noarch: W: spelling-error %description -l en_US validator -> lavatorial python3-notario.noarch: W: spelling-error %description -l en_US Schemas -> Schema, Sachems, Schemes python-notario.src: W: spelling-error Summary(en_US) validator -> lavatorial python-notario.src: W: spelling-error %description -l en_US validator -> lavatorial python-notario.src: W: spelling-error %description -l en_US Schemas -> Schema, Sachems, Schemes 3 packages and 0 specfiles checked; 0 errors, 9 warnings.

Rpmlint (installed packages) ---------------------------- python3-notario.noarch: W: spelling-error Summary(en_US) validator -> lavatorial python3-notario.noarch: W: spelling-error %description -l en_US validator -> lavatorial python3-notario.noarch: W: spelling-error %description -l en_US Schemas -> Schema, Sachems, Schemes python2-notario.noarch: W: spelling-error Summary(en_US) validator -> lavatorial python2-notario.noarch: W: spelling-error %description -l en_US validator -> lavatorial python2-notario.noarch: W: spelling-error %description -l en_US Schemas -> Schema, Sachems, Schemes 2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Requires -------- python3-notario (rpmlib, GLIBC filtered): python(abi) python3

python2-notario (rpmlib, GLIBC filtered): python(abi)

Provides -------- python3-notario: python3-notario

python2-notario: python-notario python2-notario

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:47 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #9 from Ken Dreyer ktdreyer@ktdreyer.com --- Thanks for the review!

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:47 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-notario

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-notario-0.0.11-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dbfb46187d

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:57 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-notario-0.0.11-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dbfb46187d

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:57 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-notario-0.0.11-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7769ab249d

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Mar 8 Mar

3:42 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:44 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Ken Dreyer ktdreyer@ktdreyer.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1315816

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1315816 [Bug 1315816] Review Request: python-pecan-notario - JSON validation for Pecan with Notario

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Mar 10 Mar

12:21 a.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-notario-0.0.11-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7769ab249d

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Mar 12 Mar

12:49 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-notario-0.0.11-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:50 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:50 p.m.

New subject: [Bug 1305154] Review Request: python-notario - A dictionary validator

https://bugzilla.redhat.com/show_bug.cgi?id=1305154

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-notario-0.0.11-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3565

Age (days ago)

3601

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla