[Bug 2074652] New: Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Bug ID: 2074652
           Summary: Review Request: python-sphinx-theme-builder -
                    Streamline the Sphinx theme development workflow
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://jjames.fedorapeople.org/python-sphinx-theme-builder/python-sphinx-th...
SRPM URL:
https://jjames.fedorapeople.org/python-sphinx-theme-builder/python-sphinx-th...
Fedora Account System Username: jjames
Description: A tool for authoring Sphinx themes with a simple (opinionated)
workflow.

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Jerry James  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
         Depends On|                            |2074647, 2074651

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2074647
[Bug 2074647] Review Request: python-pep621 - PEP 621 metadata parsing
https://bugzilla.redhat.com/show_bug.cgi?id=2074651
[Bug 2074651] Review Request: python-sphinx-autobuild - Autobuild a Sphinx
directory when a change is detected

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Dominik 'Rathann' Mierzejewski  ---
Taking review.

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #2 from Dominik 'Rathann' Mierzejewski  ---
Licensing:
Most of the code is under MIT license (no headers in files though), but
src/sphinx_theme_builder/_internal/passthrough.py is under BSD 3-Clause
License, so please mention this in a comment next to the License: field and
update it.

Source matches upstream:
$ sha512sum sphinx-theme-builder-0.2.0a14.tar.gz
sphinx-theme-builder-0.2.0a14.tar.gz.orig 
15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9
 sphinx-theme-builder-0.2.0a14.tar.gz
15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9
 sphinx-theme-builder-0.2.0a14.tar.gz.orig

Builds fine in mock.
Internal testsuite passes.
Spec is clean and legible.
rpmlint clean.

Requires and provides are sane:
$ rpm -qpR python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm ; echo ;
rpm -qp --provides python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm 
/usr/bin/python3
python(abi) = 3.10
python3.10dist(nodeenv)
python3.10dist(packaging)
python3.10dist(pep621)
python3.10dist(rich)
python3.10dist(setuptools)
python3.10dist(tomli)

python-sphinx-theme-builder = 0.2.0-0.1.a14.fc37
python3-sphinx-theme-builder = 0.2.0-0.1.a14.fc37
python3.10-sphinx-theme-builder = 0.2.0-0.1.a14.fc37
python3.10dist(sphinx-theme-builder) = 0.2~a14
python3dist(sphinx-theme-builder) = 0.2~a14

You can fix the minor licensing issue when importing, package approved.

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

--- Comment #3 from Jerry James  ---
Thank you for the review!  I will fix the license issue as you described.

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-sphinx-theme-builder

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-2022-9161e75532 has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #6 from Fedora Update System  ---
FEDORA-2022-9161e75532 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing
--advisory=FEDORA-2022-9161e75532`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-9161e75532

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652
Bug 2074652 depends on bug 2074647, which changed state.

Bug 2074647 Summary: Review Request: python-pep621 - PEP 621 metadata parsing
https://bugzilla.redhat.com/show_bug.cgi?id=2074647

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652
Bug 2074652 depends on bug 2074651, which changed state.

Bug 2074651 Summary: Review Request: python-sphinx-autobuild - Autobuild a Sphinx directory when a change is detected
https://bugzilla.redhat.com/show_bug.cgi?id=2074651

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 2074652] Review Request: python-sphinx-theme-builder - Streamline the Sphinx theme development workflow

https://bugzilla.redhat.com/show_bug.cgi?id=2074652

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-05-07 04:12:50

--- Comment #7 from Fedora Update System  ---
FEDORA-2022-9161e75532 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.