[Bug 561253] New: Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ibus-xkbc - The XKBC engine for IBus input platform

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Summary: Review Request: ibus-xkbc - The XKBC engine for IBus
                    input platform
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec
SRPM URL:
http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-1.fc12.sr...
Description: The XKBC engine for IBus platform. 
It provides keyboard layout emulation input method.

This is my first package, and please sponsor me.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Peng Wu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #1 from Peng Huang  2010-02-03 03:15:21 EST ---
Build failed in koji.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1960480

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Peng Huang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #2 from Jens Petersen  2010-02-03 03:36:48 EST ---
Ok once package is ready, happy to do final review and sponsor you.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #3 from Peng Wu  2010-02-03 04:31:15 EST ---
Modified spec file, and re-build against dist-f12, build succeeded:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1960564

Thanks for the help and review.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #4 from Jens Petersen  2010-02-03 19:41:16 EST ---
You need to post the new spec file and bumped srpm for every update...

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #5 from Peng Wu  2010-02-04 01:22:36 EST ---
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec
SRPM URL:
http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-2.fc12.sr...

Thanks for the reviews.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #6 from Peng Huang  2010-02-04 02:47:20 EST ---
Package Review

+ package builds in mock (rawhide noarch).
http://koji.fedoraproject.org/koji/taskinfo?taskID=1962396
+ rpmlint is no errors and warnings
+ source files match upstream url
939e3d5f68946dfecedb737954f15c24  ibus-xkbc-1.2.0.20100115.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package does not contain code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ No update-gtk-immodules scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no Desktop files.
+ Package   => ibus-xkbc-1.2.0.20100115-2.fc13.noarch.rpm

Provide:
ibus-xkbc = 1.2.0.20100115-2.fc13

Requires:
/bin/bash  
ibus >= 1.2.0
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

Approved

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #7 from Peng Wu  2010-02-04 03:42:59 EST ---
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec
SRPM URL:
http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-3.fc12.sr...

Updated source package.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #8 from Peng Wu  2010-02-04 04:15:25 EST ---
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec
SRPM URL:
http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-4.fc12.sr...

Sorry for missing the changed detail of the previous changes, so add it to the
change log,
and also post it here.
Thanks for review.

This time fixes the change log continuation, and the new entire change log is:
* Wed Feb 04 2010 Peng Wu  - 1.2.0.20100115-4
- Fixes change logs continuation.

* Wed Feb 04 2010 Peng Wu  - 1.2.0.20100115-3
- Correct home page url.

* Wed Feb 04 2010 Peng Wu  - 1.2.0.20100115-2
- Fixes koji build for F-13.

* Wed Feb 03 2010 Peng Wu  - 1.2.0.20100115-1
- The first version.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|177841(FE-NEEDSPONSOR)      |
         AssignedTo|[e-mail]           |[e-mail]
               Flag|                            |fedora-review+

--- Comment #9 from Jens Petersen  2010-02-04 04:26:47 EST ---
Thanks, taking over final review for sponsorship.

I tested the package and it seems to work pretty well.

I don't see any problems with the package and have verified
the review above on the latest package.

Package is APPROVED and I am sponsoring pwu.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #10 from Peng Wu  2010-02-04 21:57:42 EST ---
Welcome.

And re-factor the change log of rpm spec.
New package is here.
Spec URL: http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc.spec
SRPM URL:
http://novel-pinyin.sourceforge.net/SRPMS/ibus-xkbc-1.2.0.20100115-3.fc12.sr...

And new change log:
%changelog
* Wed Feb 04 2010 Peng Wu  - 1.2.0.20100115-3
- Correct home page url.

* Wed Feb 04 2010 Peng Wu  - 1.2.0.20100115-2
- Fixes koji build for F-13.

* Fri Oct 30 2009 Naoyuki Ishimura  - 0.1.0-1
- The first version.

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Peng Wu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #11 from Peng Wu  2010-02-04 22:06:07 EST ---
New Package CVS Request
=======================
Package Name: ibus-xkbc
Short Description: The XKBC engine for IBus input platform
Owners: pwu
Branches: F-12 F-13
InitialCC: petersen phuang i18n-team

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #12 from Jens Petersen  2010-02-05 05:42:45 EST ---
No F-13 branches yet.

cvs admin done

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #13 from Peng Wu  2010-02-07 22:18:12 EST ---
Package is imported by koji, by using the following command:

$./common/cvs-import.sh ../ibus-xkbc-1.2.0.20100115-3.fc12.src.rpm 
$./common/cvs-import.sh -b F-12 ../ibus-xkbc-1.2.0.20100115-3.fc12.src.rpm

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Peng Wu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #14 from Fedora Update System  2010-03-21 23:00:47 EDT ---
ibus-xkbc-1.2.0.20100115-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/ibus-xkbc-1.2.0.20100115-3.fc12

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |ibus-xkbc-1.2.0.20100115-3.
                   |                            |fc12
         Resolution|NEXTRELEASE                 |ERRATA

[Bug 561253] Review Request: ibus-xkbc - The XKBC engine for IBus input platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=561253

--- Comment #15 from Fedora Update System  2010-03-31 21:51:06 EDT ---
ibus-xkbc-1.2.0.20100115-3.fc12 has been pushed to the Fedora 12 stable
repository.  If problems still persist, please make note of it in this bug
report.