[Bug 1241088] New: Review Request: python-oslo-reports - Oslo reports library - package-review

List overview All Threads
Download

newer

[Bug 1241088] New: Review Request: python-oslo-reports - Oslo reports library

older

[Bug 952989] New: Review Request:...

[Bug 1259075] New: Review Request:...

Red Hat Bugzilla

8 Jul 2015 8 Jul '15

7:17 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Bug ID: 1241088 Summary: Review Request: python-oslo-reports - Oslo reports library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lbezdick@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://fedorapeople.org/~social/python-oslo-reports.spec SRPM URL: https://fedorapeople.org/~social/python-oslo-reports-0.2.0-1.fc22.src.rpm Description: Oslo reports library Fedora Account System Username: social

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

8 Jul 8 Jul

7:18 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar karlthered@gmail.com changed:

--- Comment #1 from Haïkel Guémar karlthered@gmail.com --- Note that approval will be delayed up until F23 is branched (next week)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

14 Jul 14 Jul

5:14 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Thomas Oulevey thomas.oulevey@cern.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.oulevey@cern.ch

--- Comment #2 from Thomas Oulevey thomas.oulevey@cern.ch --- This package looks good.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Jul 15 Jul

3:38 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

--- Comment #3 from Haïkel Guémar karlthered@gmail.com --- Please replace this line "%{python2_sitelib}" by %{python2_sitelib}/%{pypi_name}-%{version}-py*.*.egg-info

Should be good after that.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:03 p.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

hguemar@redhat.com changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Aug 12 Aug

2:42 p.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar karlthered@gmail.com changed:

--- Comment #4 from Haïkel Guémar karlthered@gmail.com --- This should be fine, too: %{python2_sitelib}/.*.egg-info (the current line means that your package is owning the whole site-package directory)

BuildRequires: python-setuptools is missing

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Aug 18 Aug

1:28 p.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Alan Pevec apevec@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |apevec@gmail.com

--- Comment #5 from Alan Pevec apevec@gmail.com --- python3 subpackage is now mandatory: https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support Also latest release is https://pypi.python.org/pypi/oslo.reports/0.4.0

While under review, RDO Liberyt dist-git will be: https://github.com/openstack-packages/python-oslo-reports/tree/rdo-liberty

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Sep 5 Sep

5:37 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar karlthered@gmail.com changed:

--- Comment #6 from Haïkel Guémar karlthered@gmail.com --- @Lukas: could you update this review, please?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

14 Sep 14 Sep

7:01 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

--- Comment #7 from Lukas Bezdicka lbezdick@redhat.com --- Spec URL: https://fedorapeople.org/~social/python-oslo-reports.spec SRPM URL: https://fedorapeople.org/~social/python-oslo-reports-0.5.0-1.fc22.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:01 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

--- Comment #8 from Lukas Bezdicka lbezdick@redhat.com --- SRPM URL: https://fedorapeople.org/~social/python-oslo-reports-0.5.0-1.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:32 p.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar karlthered@gmail.com changed:

--- Comment #9 from Haïkel Guémar karlthered@gmail.com --- Four issues that must be fixed: * missing requirements for python3, please disable python3 subpackage until it's fixed %global with_python3 0 * missing dist tag Release: 1%{?dist} * Drop %{python2_sitelib} and %{python3_sitelib} from %files as they should not be owned by python modules packages. * It also needs a changelog entry.

These are the last mile before approval.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Sep 15 Sep

6:35 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Lukas Bezdicka lbezdick@redhat.com changed:

--- Comment #10 from Lukas Bezdicka lbezdick@redhat.com --- Spec URL: https://fedorapeople.org/~social/python-oslo-reports.spec SRPM URL: https://fedorapeople.org/~social/python-oslo-reports-0.5.0-1.fc22.src.rpm

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Sep 16 Sep

3:42 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar karlthered@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #11 from Haïkel Guémar karlthered@gmail.com --- Two changes before import: * please disable python3 subpackage before import (missing python3-oslo-serialization) * change Source0 to https://pypi.python.org/packages/source/o/%%7Bpypi_name%7D/%%7Bpypi_name%7D-... for consistency with other oslo package

I hereby approve this package into Fedora Packages Collection, please submit a SCM request.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/haikel/1241088-python-oslo-reports/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -oslo-reports , python2-oslo-reports-doc , python3-oslo-reports [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM.

Installation errors ------------------- INFO: mock.py version 1.2.10 starting (python version = 2.7.8)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.10 INFO: Mock Version: 1.2.10 Finish: chroot init INFO: installing package(s): /home/haikel/1241088-python-oslo-reports/results/python2-oslo-reports-0.5.0-1.fc24.noarch.rpm /home/haikel/1241088-python-oslo-reports/results/python2-oslo-reports-doc-0.5.0-1.fc24.noarch.rpm /home/haikel/1241088-python-oslo-reports/results/python3-oslo-reports-0.5.0-1.fc24.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 23 install /home/haikel/1241088-python-oslo-reports/results/python2-oslo-reports-0.5.0-1.fc24.noarch.rpm /home/haikel/1241088-python-oslo-reports/results/python2-oslo-reports-doc-0.5.0-1.fc24.noarch.rpm /home/haikel/1241088-python-oslo-reports/results/python3-oslo-reports-0.5.0-1.fc24.noarch.rpm --setopt=tsflags=nocontexts

Rpmlint ------- Checking: python2-oslo-reports-0.5.0-1.fc24.noarch.rpm python2-oslo-reports-doc-0.5.0-1.fc24.noarch.rpm python3-oslo-reports-0.5.0-1.fc24.noarch.rpm python-oslo-reports-0.5.0-1.fc24.src.rpm python2-oslo-reports.noarch: W: spelling-error Summary(en_US) Openstack -> Open stack, Open-stack, Opens tack python3-oslo-reports.noarch: W: spelling-error Summary(en_US) Openstack -> Open stack, Open-stack, Opens tack python-oslo-reports.src: W: spelling-error Summary(en_US) Openstack -> Open stack, Open-stack, Opens tack 4 packages and 0 specfiles checked; 0 errors, 3 warnings.

Requires -------- python2-oslo-reports-doc (rpmlib, GLIBC filtered):

python3-oslo-reports (rpmlib, GLIBC filtered): python(abi) python3-babel python3-jinja2 python3-oslo-i18n python3-oslo-serialization python3-oslo-utils python3-psutil python3-six

python2-oslo-reports (rpmlib, GLIBC filtered): python(abi) python-babel python-jinja2 python-oslo-i18n python-oslo-serialization python-oslo-utils python-psutil python-six

Provides -------- python2-oslo-reports-doc: python2-oslo-reports-doc

python3-oslo-reports: python3-oslo-reports

python2-oslo-reports: python-oslo-reports python2-oslo-reports

Source checksums ---------------- http://tarballs.openstack.org/oslo.reports/oslo.reports-0.5.0.tar.gz : CHECKSUM(SHA256) this package : acc8a11422536fccbd1eda4af6b70c219e994ebcf357719480d82981f518672f CHECKSUM(SHA256) upstream package : acc8a11422536fccbd1eda4af6b70c219e994ebcf357719480d82981f518672f

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1241088 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:45 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Lukas Bezdicka social@v3.sk changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |social@v3.sk

--- Comment #12 from Lukas Bezdicka social@v3.sk --- Package Change Request ====================== Package Name: python-oslo-reports New Branches: Owners: social apevec chandankumar InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:21 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Lukas Bezdicka social@v3.sk changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

17 Sep 17 Sep

7:52 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

--- Comment #13 from Jon Ciesla limburgher@gmail.com --- If this is a new package, please use a new package request.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:52 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:09 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

--- Comment #14 from Lukas Bezdicka lbezdick@redhat.com --- New Package SCM Request ======================= Package Name: python-oslo-reports Short Description: Oslo reports library Upstream URL: http://launchpad.net/oslo Owners: social apevec chandankumar Branches: InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:10 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Lukas Bezdicka social@v3.sk changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:25 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:25 a.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

--- Comment #15 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Sep 30 Sep

12:14 p.m.

New subject: [Bug 1241088] Review Request: python-oslo-reports - Oslo reports library

https://bugzilla.redhat.com/show_bug.cgi?id=1241088

Haïkel Guémar karlthered@gmail.com changed:

--- Comment #16 from Haïkel Guémar karlthered@gmail.com --- http://koji.fedoraproject.org/koji/packageinfo?packageID=20989

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3582

Age (days ago)

3666

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla