[Bug 709791] New: Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

https://bugzilla.redhat.com/show_bug.cgi?id=709791

Summary: Review Suggestions for Tomcat - Apache Servlet/JSP
                    Engine, RI for Servlet 3.0/JSP 2.2 API
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

The bindir definition can be shortened by replacing 
%{_datadir}/%{name}
with 
%{homedir}

Might want to replace "tomcat" with %{name} in the add user and group block:

# add the tomcat user and group
%{_sbindir}/groupadd -g %{tcuid} -r tomcat 2>/dev/null || :
%{_sbindir}/useradd -c "Apache Tomcat" -u %{tcuid} -g tomcat \
    -s /bin/nologin -r -d %{homedir} tomcat 2>/dev/null || :

In the line:
%{_javadir}/%{name}/%{name}-el-%{elspec}-api.jar

%{_javadir}/%{name} can be replaced with:
%{libdir}?

[Bug 709791] Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709791

--- Comment #1 from Ole  2011-06-01 12:08:12 EDT ---
Created attachment 502313
  --> https://bugzilla.redhat.com/attachment.cgi?id=502313
Patch with review modifications

[Bug 709791] Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709791

--- Comment #2 from Ole  2011-06-01 12:15:33 EDT ---
The original spec defined in:
https://bugzilla.redhat.com/show_bug.cgi?id=700199

[Bug 709791] Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709791

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail],
                   |                            |[e-mail]
                   |                            |raproject.org
          Component|Package Review              |tomcat
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #3 from Alexander Kurtakov  2011-06-01 13:35:40 EDT ---
Wrong component - this should have been filed against tomcat itself.
Also providing a git formatted patch that the maintainer can just git am
your_patch would be helpful.

[Bug 709791] Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709791

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-06-08 07:20:50

--- Comment #4 from Alexander Kurtakov  2011-06-08 07:20:50 EDT ---
Looks like Ivan applied it in
http://pkgs.fedoraproject.org/gitweb/?p=tomcat.git;a=commitdiff;h=ca271e5d85...
Closing.

[Bug 709791] Review Suggestions for Tomcat - Apache Servlet/JSP Engine, RI for Servlet 3.0/JSP 2.2 API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709791

--- Comment #5 from Ivan Afonichev  2011-06-08 07:29:54 EDT ---
I'm not sure that setting username to variable is a good idea
tomcat6 and tomcat5 are using tomcat username
httpd is using apache username...