Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: Bashmount
https://bugzilla.redhat.com/show_bug.cgi?id=766604
Summary: Review Request: Bashmount Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: yevlempy@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://yevlempy.fedorapeople.org/bashmount.spec SRPM URL: http://yevlempy.fedorapeople.org/bashmount-1.6.0-1.fc15.src.rpm Description: Hi, i just packaged bashmount which is a menu-driven bash script that uses udisks to easily mount, unmount or eject removable devices without dependencies on any GUI or desktop environments. Its my first package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
Buland Kumar Singh i.am.fedora.bk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.am.fedora.bk@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
Cédric OLIVIER cedric.olivier@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cedric.olivier@free.fr
--- Comment #1 from Cédric OLIVIER cedric.olivier@free.fr 2011-12-12 13:35:02 EST ---
* Could you move %defattr at the top of %files (it's a cosmetic change, but %defattr tends to be used at the top of %files)
* Could you remove #Requires comments
* Could you remove "bash" build requires dependencies and add udisks(http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2)
For URL project page, http://sourceforge.net/projects/bashmount/ seems to be more complete than https://gitorious.org/bashmount/bashmount
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com
--- Comment #2 from Rahul Sundaram metherid@gmail.com 2011-12-12 21:51:02 EST ---
* You can just drop the defattr completely since its fully redundant now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
--- Comment #3 from Harsh Verma yevlempy@gmail.com 2011-12-13 00:46:26 EST --- Thanks folks for review. Have made the mentioned changes. Kindly check.
Spec URL: http://yevlempy.fedorapeople.org/bashmount.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
Harsh Verma yevlempy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
--- Comment #4 from Cédric OLIVIER cedric.olivier@free.fr 2011-12-13 07:30:58 EST --- You have updated your spec file, so you can increase release number and fill in changelog.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
--- Comment #5 from Harsh Verma yevlempy@gmail.com 2011-12-13 08:45:35 EST --- Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
--- Comment #6 from Rahul Sundaram metherid@gmail.com 2011-12-14 03:18:03 EST ---
You have updated it only in the changelog. Bump up the release number as well. Post the new spec and srpm link. Make sure you run rpmlint to check for errors and warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766604
--- Comment #7 from Harsh Verma yevlempy@gmail.com 2011-12-14 13:18:04 EST --- My bad, i totally missed increasing the release number. Have fixed that.
Spec URL : http://yevlempy.fedorapeople.org/bashmount.spec SRPM URL : http://yevlempy.fedorapeople.org/bashmount-1.6.0-2.fc15.src.rpm
As far as rpmlint is concerned, it gives no error but gives like around 8 warnings but that is basically due to spelling errors like udisks being taken as u disks in en_US, cant do anything about those kinda warnings. A different warning is, bashmount lacks a man page.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=766604
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |i.am.fedora.bk@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=766604
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com Flags| |needinfo?
--- Comment #8 from Miroslav Suchý msuchy@redhat.com --- Ping? Any progress here? Harsh are you still interrested in this package? Michael can you finish this review or reassign it back to nobody?
https://bugzilla.redhat.com/show_bug.cgi?id=766604
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@gmail.com, | |yevlempy@gmail.com Flags| |needinfo?(yevlempy@gmail.co | |m)
--- Comment #9 from James Hogarth james.hogarth@gmail.com --- Hi Harsh
It has been been quite some time since the last comments
Are you still intending to progress this?
As per policy if there is no update for a week this bug will be closed.
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
https://bugzilla.redhat.com/show_bug.cgi?id=766604
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|i.am.fedora.bk@gmail.com |nobody@fedoraproject.org Flags|fedora-review? needinfo? | |needinfo?(yevlempy@gmail.co | |m) |
https://bugzilla.redhat.com/show_bug.cgi?id=766604
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(yevlempy@gmail.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=766604
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(yevlempy@gmail.co | |m) | Last Closed| |2015-12-11 11:12:38
--- Comment #10 from James Hogarth james.hogarth@gmail.com --- It's been over a week with no response from the requestor to the NeedsInfo flag.
Closing as per policy.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org