[Bug 2138156] New: Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

Bug ID: 2138156
           Summary: Review Request: rust-schemafy_core - Generates
                    serializeable Rust types from a json schema
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/jamacku/rust-schemafy_cor...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jamacku/rust-schemafy_cor...
Description: Generates serializeable Rust types from a json schema.
Fedora Account System Username: jamacku

[Bug 2138156] Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

--- Comment #1 from Fabio Valentini  ---
Taking this review, will probably get to it tomorrow.

[Bug 2138156] Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

Jan Macku  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/jamacku/rust-schemafy_cor...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jamacku/rust-schemafy_cor...
Description: Generates serializeable Rust types from a json schema.
Fedora Account System Username: jamacku

[Bug 2138156] Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #2 from Fabio Valentini  ---
Thanks for the update, package looks good to me!
Please just include an actual link to the upstream PR / change for the included
patch,
i.e. https://github.com/Marwes/schemafy/pull/62

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files (submitted + accepted
upstream, included manually)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

[Bug 2138156] Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-schemafy_core

[Bug 2138156] Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

--- Comment #4 from Jan Macku  ---
Thank you Fabio. I have added a comment mentioning upstream PR and submitted
builds.

[Bug 2138156] Review Request: rust-schemafy_core - Generates serializeable Rust types from a json schema

https://bugzilla.redhat.com/show_bug.cgi?id=2138156

Jan Macku  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-11-01 09:15:14