Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Summary: Review Request: soundmodem - Soundcard Packet Radio Modem Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cooly@gnome.eu.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://lucilanga.fedorapeople.org/soundmodem.spec SRPM URL: http://lucilanga.fedorapeople.org/soundmodem-0.10-1.fc9.src.rpm Description: This package contains the driver and the diagnostic utility for userspace SoundModem. It allows you to use soundcards supported by OSS/Free as Amateur Packet Radio modems.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: soundmodem - Soundcard Packet Radio Modem
https://bugzilla.redhat.com/show_bug.cgi?id=455137
------- Additional Comments From notting@redhat.com 2008-07-17 10:51 EST ------- Our drivers aren't OSS/Free (they're alsa), so that description could probably use some rewording. Maybe just 's|supported by OSS/Free||'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: soundmodem - Soundcard Packet Radio Modem
https://bugzilla.redhat.com/show_bug.cgi?id=455137
------- Additional Comments From cooly@gnome.eu.org 2008-07-17 11:08 EST ------- I've updated the description and bumped version
new files:
http://lucilanga.fedorapeople.org/soundmodem.spec http://lucilanga.fedorapeople.org/soundmodem-0.10-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@math.uh.edu
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2008-11-20 12:57:36 EDT --- This failed to build for me on x86_64 with current rawhide:
+ ./configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu --target=x86_64-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info checking build system type... Invalid configuration `x86_64-unknown-linux-gnu': machine `x86_64-unknown' not recognized configure: error: /bin/sh ./config.sub x86_64-unknown-linux-gnu failed
I do not know what that means. Maybe the configure script was simply generated by a really old autotools version?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
--- Comment #4 from Lucian Langa cooly@gnome.eu.org 2008-11-21 09:22:08 EDT --- (In reply to comment #3)
I do not know what that means. Maybe the configure script was simply generated by a really old autotools version?
I've used autotools to update.
new ver: http://lucilanga.fedorapeople.org/soundmodem.spec http://lucilanga.fedorapeople.org/soundmodem-0.10-3.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2008-12-02 20:53:45 EDT --- Builds fine and rpmlint is silent.
The documentation files are duplicated between the main and -devel package.
Unfortunately, modem.h and simd.h are far too generic to place in /usr/include.
* source files match upstream. sha256sum: e7a42c413a180b873ae76b2c252904a3e34c9807c2604f2315426443d9e28627 soundmodem-0.10.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: soundmodem-0.10-3.fc11.x86_64.rpm soundmodem = 0.10-3.fc11 soundmodem(x86-64) = 0.10-3.fc11 = /bin/sh chkconfig initscripts libX11.so.6()(64bit) libXext.so.6()(64bit) libXi.so.6()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libaudiofile.so.0()(64bit) libgdk-1.2.so.0()(64bit) libglib-1.2.so.0()(64bit) libgmodule-1.2.so.0()(64bit) libgtk-1.2.so.0()(64bit) libutil.so.1()(64bit) libutil.so.1(GLIBC_2.2.5)(64bit) libxml.so.1()(64bit)
soundmodem-devel-0.10-3.fc11.x86_64.rpm soundmodem-devel = 0.10-3.fc11 soundmodem-devel(x86-64) = 0.10-3.fc11 = soundmodem = 0.10-3.fc11
* no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. X generically named files * scriptlets present OK (service management). * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no pkgconfig files. * no static libraries. * no libtool .la files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
--- Comment #6 from Lucian Langa cooly@gnome.eu.org 2008-12-03 05:59:09 EDT --- (In reply to comment #5)
The documentation files are duplicated between the main and -devel package.
Updated, there's no doc files for devel package.
Unfortunately, modem.h and simd.h are far too generic to place in /usr/include.
Moved'em to /usr/include/soundmodem.
http://lucilanga.fedorapeople.org/soundmodem.spec http://lucilanga.fedorapeople.org/soundmodem-0.10-4.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
--- Comment #7 from Alan Crosswell alan@columbia.edu 2008-12-06 12:28:16 EDT --- Created an attachment (id=326008) --> (https://bugzilla.redhat.com/attachment.cgi?id=326008) remove spurious printf's
I've removed two spurious printfs that were resulting in the syslog buffers getting filled up when soundmodem runs as daemon. I've been running soundmodem in two production aprsdigi's for several years with this patch. Without it, soundmodem would randomly exit.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
--- Comment #8 from Alan Crosswell alan@columbia.edu 2008-12-06 12:31:21 EDT --- Created an attachment (id=326009) --> (https://bugzilla.redhat.com/attachment.cgi?id=326009) SPEC to apply spurious printf patch
This is the SPEC to apply the spurious printf's patch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Alan Crosswell alan@columbia.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #326009|0 |1 is obsolete| |
--- Comment #9 from Alan Crosswell alan@columbia.edu 2008-12-06 12:39:07 EDT --- Created an attachment (id=326010) --> (https://bugzilla.redhat.com/attachment.cgi?id=326010) applies soundmodem-spurious-printf.patch
Sorry, I patched against what is in the fedora SRPM. Here's the update against the 10.4 spec.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #10 from Jason Tibbitts tibbs@math.uh.edu 2008-12-06 12:48:49 EDT --- The issues I had with this review have been fixed. It would be nice to address the above mentioned code quality issue, which I have no way to test, but I'm going to leave that up to Lucian. Alan, if your issue is not addressed when this package is imported, please consider filing a bug against it. Unfortunately you can't do that now because the review isn't finished and so the bugzilla component doesn't exist yet. It should be available soon after the CVS request has been processed.
Anyway, I'm going to approve this and leave it to Lucian to decide what to do with the above patch.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Lucian Langa cooly@gnome.eu.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #11 from Lucian Langa cooly@gnome.eu.org 2008-12-06 16:20:46 EDT --- Thank you, Jason. Alan, thank you for the patch, I'm going to handle this after I check this in.
New Package CVS Request ======================= Package Name: soundmodem Short Description: Soundcard Packet Radio Modem Owners: lucilanga Branches: F-9 F-10 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #12 from Kevin Fenzi kevin@tummy.com 2008-12-06 22:30:33 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2008-12-08 05:48:23 EDT --- soundmodem-0.10-5.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/soundmodem-0.10-5.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2008-12-08 05:49:35 EDT --- soundmodem-0.10-5.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/soundmodem-0.10-5.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455137
Lucian Langa cooly@gnome.eu.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org