[Bug 549709] New: Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libgnome-keyring - Framework for managing passwords and other secrets

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Summary: Review Request: libgnome-keyring - Framework for
                    managing passwords and other secrets
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring.spec
SRPM URL:
http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring-2.29.4-1.f...

Description: 
gnome-keyring is a program that keep password and other secrets for
users. The library libgnome-keyring is used by applications to integrate
with the gnome-keyring system.

--
Basically, this is a split of gnome-keyring (recent upstream decision),
creating separate library with the core.

Feel free to propose better description, I'm bad with that.

rpmlint passes without warning, package builds fine in koji.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Tomáš Bžatek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|medium                      |high

--- Comment #1 from Tomáš Bžatek   2009-12-22 09:51:28 EDT ---
Forgot to add that we will have to add libgnome-keyring dependency to all g-k
clients and fix tons of packages in Fedora. This will effectively make decent
mess once libgnome-keyring and new gnome-keyring packages will hit rawhide.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Bastien Nocera  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Bastien Nocera   2009-12-22 09:55:14 EDT ---
(In reply to comment #1)
> Forgot to add that we will have to add libgnome-keyring dependency to all g-k
> clients and fix tons of packages in Fedora. This will effectively make decent
> mess once libgnome-keyring and new gnome-keyring packages will hit rawhide.

Not really. Make the library depend on gnome-keyring, voila. You'd probably
have a problem with bootstrapping gnome-keyring from scratch if it depends on
libgnome-keyring, but that's relatively minor.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

--- Comment #3 from Matthias Clasen   2009-12-22 10:02:10 EDT ---
You still need a libgnome-keyring-devel BR everywhere...

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

--- Comment #4 from Tomáš Bžatek   2009-12-22 10:11:19 EDT ---
Right, we can add explicit Require: libgnome-keyring-devel to the
gnome-keyring-devel, that might do the trick for the moment.

FYI, we have bootstrapping problems in Fedora anyway, circular BR dependency
nautilus <--> gnome-disk-utility (pulled in by gvfs, which nautilus depends
on), but that's another story.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

--- Comment #5 from Matthias Clasen   2009-12-22 17:31:52 EDT ---
Package builds fine in mock, and rpmlint is silent:

rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/libgnome-keyring-*.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Matthias Clasen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

--- Comment #6 from Matthias Clasen   2009-12-22 18:06:31 EDT ---
package name: ok
spec name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec language: ok
spec readable: yes
upstream source: ok
buildable: yes
ExcludeArch: none, ok
BuildRequires: ok
locale handling: none, ok
ldconfig: ok
system libraries: none, ok
relocatable: no, ok
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: ok
permissable content: ok
large docs: none, ok
%doc content: ok
header files: ok
static libs: none, ok
pc files: ok
shared libs: ok
devel deps: ok
libtool archives: none, ok
gui apps: no, ok
file ownership: ok, but we should figure out how to handle the conflict with
the old gnome-keyring package
%install: ok
utf8 filenames: ok

Summary: all looks good, we just need to figure out the conflict with the old
gnome-keyring package. Probably add something like

Conflicts: gnome-keyring < 2.29.4
Conflicts: gnome-keyring-devel < 2.29.4

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

--- Comment #7 from Tomáš Bžatek   2010-01-04 11:05:38 EDT ---
Thanks for the review. I've added Conflicts: in libgnome-keyring.spec and
explicit Requires: libgnome-keyring in gnome-keyring.spec for both
gnome-keyring and gnome-keyring-devel subpackages (as discussed above). This
should guarantee good upgrade path without breaking the things.

New Spec:
http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring.spec
New SRPM:
http://tbzatek.fedorapeople.org/libgnome-keyring/libgnome-keyring-2.29.4-1.f...

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Matthias Clasen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #8 from Matthias Clasen   2010-01-04 13:29:11 EDT ---
Looks good. Approved.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Tomáš Bžatek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #9 from Tomáš Bžatek   2010-01-05 06:04:24 EDT ---
New Package CVS Request
=======================
Package Name: libgnome-keyring
Short Description: Framework for managing passwords and other secrets
Owners: tbzatek
Branches: devel
InitialCC:

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #10 from Kevin Fenzi   2010-01-06 16:30:26 EDT ---
cvs done.

[Bug 549709] Review Request: libgnome-keyring - Framework for managing passwords and other secrets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549709

Tomáš Bžatek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #11 from Tomáš Bžatek   2010-01-07 05:25:53 EDT ---
(In reply to comment #10)
> cvs done.

Thanks!

libgnome-keyring-2.29.4-1.fc13 has been built:
http://koji.fedoraproject.org/koji/buildinfo?buildID=149812