[Bug 219889] New: Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

Summary: Review Request: bootchart - a utility for profiling the
                    boot process
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://people.freedesktop.org/~johnp/bootchart.spec
SRPM URL: http://people.freedesktop.org/~johnp/bootchart-0.9-1.src.rpm

Description:

A tool for performance analysis and visualization of the GNU/Linux boot
process. Resource utilization and process information are collected during
the boot process and are later rendered in a PNG, SVG or EPS encoded chart.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-12-20 17:47 EST -------
Hi John.  I'll review this package.

Does this package really need a javadoc subpackage?  It's an application, not a
development library, right?

Also, I don't think System/Benchmark is a valid Group tag for Extras.  Maybe
this should be Applications/System.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-02-23 11:59 EST -------
Hi John,

It's been a couple of months now.  Do you want to abandon this package review?

AG

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-04-24 12:03 EST -------
If it does get abandoned, I'll be happy to pick it up.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-06-05 14:54 EST -------
So it's been another six weeks; I think this should be closed, and I'll do so in
a week if there's no further response.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-06-05 15:06 EST -------
sorry, been really busy.  javadoc is there to be a bit more kind for space
requirements since I work on a  space limited project.  You don't always need
the docs around.  I would actually like to see most of Fedora be a little more
finegrained when it comes to packaging.  I'll change the group to
Applications/System.  Any other issues with the package?

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?([e-mail])

------- Additional Comments From [e-mail]  2007-07-06 12:54 EST -------
Currently it seems as if Andy Green is reviewing this, but he hasn't responded.
 I'll set needinfo.

Andy, if you are reviewing this, please set fedora-review to '?'.  Or if you
don't want to continue reviewing this, go ahead and assign it back to
[e-mail] so someone else can take it.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?([e-mail]) |

------- Additional Comments From [e-mail]  2007-07-06 13:07 EST -------
(In reply to comment #6)
> Currently it seems as if Andy Green is reviewing this, but he hasn't responded.
>  I'll set needinfo.
>
> Andy, if you are reviewing this, please set fedora-review to '?'.  Or if you
> don't want to continue reviewing this, go ahead and assign it back to
> [e-mail] so someone else can take it.

(I think you mean "Anthony" Green).  Yes, I'll continue reviewing this.  I don't
know how I missed John's reply.  I'll look at this today.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-08-15 16:02 EST -------
This has stalled for a while but I still really want it.  So:

http://ajax.fedorapeople.org/bootchart/

Has new spec and srpm (and noarch rpms).

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]            |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-08-16 13:50 EST -------
Comandeering this package review...

% rpmlint *rpm
W: bootchart invalid-license GPL
W: bootchart invalid-license GPL
W: bootchart-logger non-standard-group System/Boot
W: bootchart-logger invalid-license GPL

* Please choose one of GPL+, GPLv2, GPLv2+, GPLv3, GPLv3+.  See various mailing
list threads about it.  Also, I'll note that one of the files you install
(/usr/share/doc/bootchart-0.9/LICENSE.compress.txt) mentions the Apache License.
 Might want to figure out what's up with that.

* System Environment/Base seems to be the right group for the logger

* Preserve your file timestamps by using the -p flag to install(1)

* There's a new preferred buildroot of the day, it appears, though you're using
the second-best version of it.  Just figured I'd point that out since it humors me.

* I'll assume this builds under mock.  If it doesn't you'll find out when you
try to build into koji.

* Also, is this package really useful without the logger subpackage?  Might
consider killing the subpackage.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-08-16 13:58 EST -------
Oh and if you don't kill the subpackage, you need to Requires: %{name} from it.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-08-16 16:50 EST -------
Better make that Requires: %{name} = %{version}-%{release}

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review?

------- Additional Comments From [e-mail]  2007-08-16 17:07 EST -------
(In reply to comment #9)
> Please choose one of GPL+, GPLv2, GPLv2+, GPLv3, GPLv3+.  See various mailing
>
> list threads about it.  Also, I'll note that one of the files you install
> (/usr/share/doc/bootchart-0.9/LICENSE.compress.txt) mentions the Apache License.
>  Might want to figure out what's up with that.

Everything looks to be v2+, but then also links against
org.apache.commons.compress.tar, which is Apache 2.0.  So I'm just claiming it's
 GPLv3+ for now.  I'll ask upstream what they really mean though.
> System Environment/Base seems to be the right group for the logger

Done.
> Preserve your file timestamps by using the -p flag to install(1)

Done.
> There's a new preferred buildroot of the day, it appears, though you're using
>
> the second-best version of it.  Just figured I'd point that out since it

humors me.

Done.
> I'll assume this builds under mock.  If it doesn't you'll find out when you
>
> try to build into koji.

Yep.
> Also, is this package really useful without the logger subpackage?  Might
>
> consider killing the subpackage.

Yeah, it's sort of backwards.  The core package is the renderer, the logger is
the init wrapper.  I could do it as bootchart / bootchart-renderer I guess?

The intent is to just have bootchart-logger always active, and let people either
render stuff themselves or go to the web UI for it on bootchart.org.

New packages and spec at the same URL as before.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-08-17 01:59 EST -------
Erm, I see no new packages on several computars...

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889

------- Additional Comments From [e-mail]  2007-08-24 18:34 EST -------
Sorry, was late about it.  Current build:

http://ajax.fedorapeople.org/bootchart/bootchart.spec
http://ajax.fedorapeople.org/bootchart/bootchart-0.9-4.fc8.src.rpm

Folds the subpackages together just for the hell of it, and applies gcj
precompilation (patch from overholt).

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-08-27 11:23 EST -------
Cool.

* Pick one syntax format for your if blocks in %post and %postun
* Consider %{_sysconfdir} for /etc and %{_sbindir} for /sbin
* %define boottitle is unused?
* Url tag -> URL (personal nit).

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-08-27 11:50 EST -------
Fixed those locally, they'll show up in the import.

Except for the sbin thing, since %{_sbindir} is /usr/sbin; once I remember what
the macro for /sbin is, I'll fix that.

New Package CVS Request
=======================
Package Name: bootchart
Short Description: A utility for boot time profiling
Owners: ajax
Branches: 
InitialCC: 
Cvsextras Commits:

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-08-27 12:39 EST -------
cvs done.

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2007-08-27 13:09 EST -------
Imported, building 0.9-5.fc8 now.  Thanks!

[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process

https://bugzilla.redhat.com/show_bug.cgi?id=219889

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |
              nThis|                            |

------- Additional Comments From [e-mail]  2007-09-01 12:04 EST -------
Removing old FE-REVIEW blocker.