[Bug 226056] New: Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

Summary: Merge Review: libvorbis
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: libvorbis

http://cvs.fedora.redhat.com/viewcvs/devel/libvorbis/
Initial Owner: [e-mail]

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-03 14:26 EST -------
Good:
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* The devel package require should be:
Requires: libvorbis = %{epoch}:%{version}-%{release}
* Should use BuildRequires, instead of BuildPrereq for libogg
* rpmlint gives the following error:
 E: libvorbis-devel obsolete-not-provided vorbis-devel
* Is the static lib necessary?  If so, it should be split out into a
sub-package.  Refer to:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4...

Minor:
* Doesn't use preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Drop the '.' from the summary to quite rpmlint.
* Does this package build using 'make %{_smp_mflags}'?
* rpmlint warnings:
 W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/floor1_inverse_dB_table.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/framing.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/v-comment.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/helper.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbis-fidelity.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/stereo.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/programming.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/oggstream.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbisfile/fileinfo.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbis.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/index.html
W: libvorbis-devel wrong-file-end-of-line-encoding
/usr/share/doc/libvorbis-devel-1.1.2/vorbisfile/seeking.html

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]
               Flag|fedora-review-              |fedora-review?

------- Additional Comments From [e-mail]  2007-02-08 12:12 EST -------
* Thu Feb  8 2007 Matthias Clasen  - 1:1.1.2-2
- Package review cleanups
- Don't ship static libraries

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

------- Additional Comments From [e-mail]  2007-04-11 07:14 EST -------
Brian, anything left here ?

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-04-11 13:17 EST -------
Nope, you changes look fine.

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]

[Bug 226056] Merge Review: libvorbis

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libvorbis

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 21:30 EST -------
Review done.