[Bug 2257677] New: Review Request: python-snakemake-storage-plugin-http - Snakemake storage plugin for downloading input files from HTTP(s)
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
Bug ID: 2257677 Summary: Review Request: python-snakemake-storage-plugin-http - Snakemake storage plugin for downloading input files from HTTP(s) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 2257676 Blocks: 1276941 (fedora-neuro,NeuroFedora), 2255578 Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/python-snakemake-storage-plugin-http.spec SRPM URL: https://music.fedorapeople.org/python-snakemake-storage-plugin-http-0.2.3-1....
Description:
Snakemake storage plugin for downloading input files from HTTP(s).
Fedora Account System Username: music
Building this package requires (at least a bootstrap build of) python-snakemake-interface-storage-plugins, bug 2257676, as well as (at least a bootstrap build) of snakemake >= 8, https://src.fedoraproject.org/rpms/snakemake/pull-request/25.
A COPR build is available at:
https://copr.fedorainfracloud.org/coprs/music/snakemake8/build/6879155/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug https://bugzilla.redhat.com/show_bug.cgi?id=2255578 [Bug 2255578] snakemake-8.1.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2257676 [Bug 2257676] Review Request: python-snakemake-interface-storage-plugins - Stable interface for interactions between Snakemake and its storage plugins
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6879310 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2257677 Bug 2257677 depends on bug 2257676, which changed state.
Bug 2257676 Summary: Review Request: python-snakemake-interface-storage-plugins - Stable interface for interactions between Snakemake and its storage plugins https://bugzilla.redhat.com/show_bug.cgi?id=2257676
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |gui1ty@penguinpee.nl CC| |gui1ty@penguinpee.nl
--- Comment #2 from Sandro gui1ty@penguinpee.nl --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Notes =====
Seeing all the specific version restrictions in the dependencies, this will become an interesting pool of packages to maintain.
Package is APPROVED.
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Binary eggs must be removed in %prep [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: python3-snakemake-storage-plugin-http-0.2.3-1.fc40.noarch.rpm python-snakemake-storage-plugin-http-0.2.3-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxl83_9na')] checks: 31, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-snakemake-storage-plugin-http". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/snakemake/snakemake-storage-plugin-http/archive/v0.2.3/sn... : CHECKSUM(SHA256) this package : 12fc0f612da7073852caee0e9789072a1de1cdbff93e849c44b06165850fe794 CHECKSUM(SHA256) upstream package : 12fc0f612da7073852caee0e9789072a1de1cdbff93e849c44b06165850fe794
Requires -------- python3-snakemake-storage-plugin-http (rpmlib, GLIBC filtered): (python3.12dist(requests) < 3~~ with python3.12dist(requests) >= 2.28.2) (python3.12dist(requests-oauthlib) < 2~~ with python3.12dist(requests-oauthlib) >= 1.3.1) (python3.12dist(snakemake-interface-common) < 2~~ with python3.12dist(snakemake-interface-common) >= 1.14) (python3.12dist(snakemake-interface-storage-plugins) < 4~~ with python3.12dist(snakemake-interface-storage-plugins) >= 3) python(abi)
Provides -------- python3-snakemake-storage-plugin-http: python-snakemake-storage-plugin-http python3-snakemake-storage-plugin-http python3.12-snakemake-storage-plugin-http python3.12dist(snakemake-storage-plugin-http) python3dist(snakemake-storage-plugin-http)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-snakemake-storage-plugin-http --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Ocaml, SugarActivity, PHP, fonts, Java, R, Haskell, C/C++, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- Thank you!
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-snakemake-storage-plugin-http
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- https://release-monitoring.org/project/370954/
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-a2f086ebfe has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a2f086ebfe
https://bugzilla.redhat.com/show_bug.cgi?id=2257677
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-01-19 04:48:31
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-a2f086ebfe has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com