https://bugzilla.redhat.com/show_bug.cgi?id=2130053
Bug ID: 2130053 Summary: Review Request: typescript - A language for application scale JavaScript development Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: carl@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedor...
Description: TypeScript is a language for application-scale JavaScript. TypeScript adds optional types to JavaScript that support tools for large-scale JavaScript applications for any browser, for any host, on any OS. TypeScript compiles to readable, standards-based JavaScript.
Fedora Account System Username: carlwgeorge
This is a re-review in order to rename nodejs-typescript to typescript. I would like to do this rename to comply with the current Node.js packaging guidelines [0]. A re-review is required per the Package Renaming Process [1].
[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_naming_g... [1] https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Pr...
https://bugzilla.redhat.com/show_bug.cgi?id=2130053
--- Comment #1 from Carl George 🤠 carl@redhat.com --- Based on feedback from one of the nodejs maintainers, since this package is noarch I've switched the build requirements from nodejs-devel to nodejs-packaging. I also added an explicit build requirement on nodejs for the %check section (nodejs-packaging doesn't currently require it).
Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedor...
https://bugzilla.redhat.com/show_bug.cgi?id=2130053
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- This package doesn't look significantly different from the current one.
Packaging notes:
* Package follows packaging guidelines * Package is named appropriately (now) * Package builds and installs * Package licensing is correctly handled * Package presents no serious rpmlint issues
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2130053
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/typescript
https://bugzilla.redhat.com/show_bug.cgi?id=2130053
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-0398edd8b7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0398edd8b7
https://bugzilla.redhat.com/show_bug.cgi?id=2130053
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-10-10 17:40:48
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-0398edd8b7 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org