[Bug 1795197] New: Review Request: rust-dissimilar - Diff library with semantic cleanup, based on Google's diff-match-patch
6:23 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
Bug ID: 1795197
Summary: Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: decathorpe(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/packages/rust-dissimilar.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/rust-dissimilar-1.0.1-1.fc31...
Description:
Diff library with semantic cleanup, based on Google's diff-match-patch.
Fedora Account System Username: decathorpe
koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=41080300
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2 p.m.
New subject: [Bug 1795197] Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
Josh Stone <jistone(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jistone(a)redhat.com
Doc Type|--- |If docs needed, set a value
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:26 p.m.
New subject: [Bug 1795197] Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
Jerry James <loganjerry(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |loganjerry(a)gmail.com
Assignee|nobody(a)fedoraproject.org |loganjerry(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Jerry James <loganjerry(a)gmail.com> ---
I will take this review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 p.m.
New subject: [Bug 1795197] Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
Jerry James <loganjerry(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jerry James <loganjerry(a)gmail.com> ---
This package is APPROVED.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: rust-dissimilar-devel-1.0.1-1.fc32.noarch.rpm
rust-dissimilar+default-devel-1.0.1-1.fc32.noarch.rpm
rust-dissimilar-1.0.1-1.fc32.src.rpm
rust-dissimilar-devel.noarch: W: invalid-url URL:
https://crates.io/crates/dissimilar HTTP Error 404: Not Found
rust-dissimilar-devel.noarch: W: hidden-file-or-dir
/usr/share/cargo/registry/dissimilar-1.0.1/.cargo-checksum.json
rust-dissimilar+default-devel.noarch: W: invalid-url URL:
https://crates.io/crates/dissimilar HTTP Error 404: Not Found
rust-dissimilar+default-devel.noarch: W: no-documentation
rust-dissimilar.src: W: invalid-url URL: https://crates.io/crates/dissimilar
HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Rpmlint (installed packages)
----------------------------
rust-dissimilar+default-devel.noarch: W: invalid-url URL:
https://crates.io/crates/dissimilar HTTP Error 404: Not Found
rust-dissimilar+default-devel.noarch: W: no-documentation
rust-dissimilar-devel.noarch: W: invalid-url URL:
https://crates.io/crates/dissimilar HTTP Error 404: Not Found
rust-dissimilar-devel.noarch: W: hidden-file-or-dir
/usr/share/cargo/registry/dissimilar-1.0.1/.cargo-checksum.json
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Source checksums
----------------
https://crates.io/api/v1/crates/dissimilar/1.0.1/download#/dissimilar-1.0...
:
CHECKSUM(SHA256) this package :
39de161cd2ebbd6e5783db53a82a47b6a47dcfef754130839603561745528b94
CHECKSUM(SHA256) upstream package :
39de161cd2ebbd6e5783db53a82a47b6a47dcfef754130839603561745528b94
Requires
--------
rust-dissimilar-devel (rpmlib, GLIBC filtered):
cargo
rust-dissimilar+default-devel (rpmlib, GLIBC filtered):
cargo
crate(dissimilar)
Provides
--------
rust-dissimilar-devel:
crate(dissimilar)
rust-dissimilar-devel
rust-dissimilar+default-devel:
crate(dissimilar/default)
rust-dissimilar+default-devel
Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07
Command line :/usr/bin/fedora-review -b 1795197 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: C/C++, Ruby, Python, SugarActivity, PHP, Java, Ocaml, fonts,
Perl, Haskell, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:19 p.m.
New subject: [Bug 1795197] Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
--- Comment #3 from Fabio Valentini <decathorpe(a)gmail.com> ---
Thanks!
Repo request
https://pagure.io/releng/fedora-scm-requests/issue/22018
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:31 p.m.
New subject: [Bug 1795197] Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
--- Comment #4 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-dissimilar
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:03 p.m.
New subject: [Bug 1795197] Review Request: rust-dissimilar - Diff library with
semantic cleanup, based on Google's diff-match-patch
https://bugzilla.redhat.com/show_bug.cgi?id=1795197
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Fixed In Version| |rust-dissimilar-1.0.1-1.fc3
| |2
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1458030
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1596
days inactive
1607
days old
package-review@lists.fedoraproject.org
6 comments
1 participants
participants (1)
-
bugzilla＠redhat.com