[Bug 1919037] New: Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

Bug ID: 1919037
           Summary: Review Request: dotnet5.0 - .NET Runtime and SDK
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://fedorapeople.org/~omajid/dotnet/dotnet5.0.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/@dotnet-sig/dotnet-previe...

Description:

.NET is a fast, lightweight and modular platform for creating
cross platform applications that work on Linux, macOS and Windows.

It particularly focuses on creating console applications, web
applications and micro-services.

.NET contains a runtime conforming to .NET Standards a set of
framework libraries, an SDK containing compilers and a 'dotnet'
application to drive everything.

Fedora Account System Username: omajid

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

--- Comment #1 from Omair Majid  ---
This is not an upgrade to the existing dotnet3.1 package, but an addition. They
can be installed side-by-side.

This package needs to be bootstrapped. We have a blanket bootstrap exception
from the fedora packaging committee:
https://pagure.io/packaging-committee/issue/989

After bootstrapping, this package needs an additional dependency to build:
dotnet5.0-build-reference-packages, tracked by bug 1919045.

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

--- Comment #2 from Omair Majid  ---
Here's this package building in copr:
https://copr.fedorainfracloud.org/coprs/g/dotnet-sig/dotnet-preview/build/18...

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

Chris Rummel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

Chris Rummel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Chris Rummel  ---
Allowed package: good.
Naming: good.
Version and release: good.
Licensing: good.
Library/application: good.
Packages MUST specify their dependencies: good.
Desktop applications MUST NOT depend on other desktop applications: N/A.
Spec file
- naming: good.
- legibility: good.
- encoding: good.
- outside repo: N/A.
Source file verification: N/A.
Architecture support: good.
Filesystem layout: good.
RPMLint: clean.
Tags and sections: good.
Dependencies: good.
Build-time dependencies: good.
Summary and description: good.
Documentation: good.
Changelog: good.
Man pages: good.
Compiler: good.
Compiler flags: good.
Debuginfo: good.
Devel packages: N/A.
Requiring base packages: good.
Shared libraries: good.
Static libraries: N/A.
Bundling and duplication of libraries: good.
Rpath: good.
Config files: good.
Initscripts: good.
Systemd units: N/A.
Desktop files: N/A.
AppData files: N/A.
Macros: good.
Scripting: N/A.
Locale: good.
Log files: N/A.
Ownership: good.
Users and groups: N/A.
Web applications: N/A.
Patches:
- Patch1: source-build-runtime-fixup-linker-order.patch need an upstream bug is
missing an upstream bug or comment.
Epoch: N/A.
Symlinks: good.
Test suite: N/A.
binfmt, sysctl, tmpfiles: N/A.
Renaming/replacing/deprecating packages: N/A.
IPv6: good.
Cron files: N/A.
Security updates: N/A.
Build-time network access: N/A.
Bootstrapping: good.
Shebangs: N/A.
BuildRoot policy: N/A.
EPEL: N/A.

This passes but the missing comment or upstream bug for the patch should be
fixed.

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

--- Comment #4 from Omair Majid  ---
Thanks for the review! I am going to add this note to the patch:

# Fix up a patch included in source-build to apply after we apply the
linker-order patch first

It's basically a patch that fixes up a source-build patch
(patches/runtime/0014-Fix-singlefilehost-build-in-non-portable-mode-42415.patch)
which fails to apply once we apply https://github.com/dotnet/runtime/pull/42094
first.

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

--- Comment #5 from Chris Rummel  ---
That sounds good to me, thanks!

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

--- Comment #6 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/dotnet5.0

[Bug 1919037] Review Request: dotnet5.0 - .NET Runtime and SDK

https://bugzilla.redhat.com/show_bug.cgi?id=1919037

Omair Majid  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-02-01 15:01:15

--- Comment #7 from Omair Majid  ---
Thanks again for the review!

The package has been built for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-2cf45ff8b3