https://bugzilla.redhat.com/show_bug.cgi?id=2293755
Bug ID: 2293755 Summary: Review Request: golang-github-charlievieth-fastwalk - Fast parallel directory traversal for Golang Product: Fedora Version: rawhide URL: https://github.com/charlievieth/fastwalk Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://qulogic.fedorapeople.org/reviews/golang-github-charlievieth-fastwalk... SRPM URL: https://qulogic.fedorapeople.org/reviews/golang-github-charlievieth-fastwalk...
Description: Fast parallel directory traversal for Golang.
https://bugzilla.redhat.com/show_bug.cgi?id=2293755
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2256379
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2256379 [Bug 2256379] fzf-0.53.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2293755
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7650157 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2293755
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #2 from Mikel Olasagasti Uranga mikel@olasagasti.info --- spec is correct, but I've one question:
%bcond check 1
go2rpm template uses bcond_without and has done it since the beginning: https://gitlab.com/fedora/sigs/go/go2rpm/-/blob/main/go2rpm/templates/profil...
Is there a reason to change it?
https://bugzilla.redhat.com/show_bug.cgi?id=2293755
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I find this style to be clearer (it says what it is, not what it isn't), and it's available on all Fedora. I don't know about EPEL though. But we should probably change it in the template as well.
https://bugzilla.redhat.com/show_bug.cgi?id=2293755
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Eclipseo is proposing similar template change in https://gitlab.com/fedora/sigs/go/go2rpm/-/merge_requests/13 so I guess we'll end adopting it.
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
package-review@lists.fedoraproject.org