[Bug 2098373] New: Review Request: gearhead2 - Roguelike mecha role-playing game in space
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Bug ID: 2098373 Summary: Review Request: gearhead2 - Roguelike mecha role-playing game in space Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://svgames.pl/fedora/gearhead2-0.701-1/gearhead2.spec srpm: https://svgames.pl/fedora/gearhead2-0.701-1/gearhead2-0.701-1.20201130git86d... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=88407234
Description: GearHead II is the sequel to GearHead: Arena. Create your own character and pilot giant mechas in this roguelike role-playing game.
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@emailplus.org
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- Unofficial review:
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "Unknown or generated", "GNU Lesser General Public License, Version 2.1 [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU Lesser General Public License". 884 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/gearhead2/2098373-gearhead2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package does not use a name that already exists. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gearhead2-textmode , gearhead2-SDL , gearhead2-data , gearhead2-data- gfx [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/jwvhewitt/gearhead-2/archive/86d17e191529733c06d05c333d7f... : CHECKSUM(SHA256) this package : f8fb8fbfce46cec83eca50b6cb577fe14dbee12642181f7434225963e3ef5031 CHECKSUM(SHA256) upstream package : f8fb8fbfce46cec83eca50b6cb577fe14dbee12642181f7434225963e3ef5031
Requires -------- gearhead2 (rpmlib, GLIBC filtered): gearhead2-bin(x86-64)
gearhead2-textmode (rpmlib, GLIBC filtered): gearhead2-data
gearhead2-SDL (rpmlib, GLIBC filtered): gearhead2-data gearhead2-data-gfx libSDL-1.2.so.0()(64bit) libSDL_image-1.2.so.0()(64bit) libSDL_ttf-2.0.so.0()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit)
gearhead2-data (rpmlib, GLIBC filtered):
gearhead2-data-gfx (rpmlib, GLIBC filtered): font(bitstreamverasans) font(bitstreamverasansmono) gearhead2-data hicolor-icon-theme
gearhead2-debuginfo (rpmlib, GLIBC filtered):
gearhead2-debugsource (rpmlib, GLIBC filtered):
Provides -------- gearhead2: gearhead2 gearhead2(x86-64)
gearhead2-textmode: gearhead2-bin(x86-64) gearhead2-textmode gearhead2-textmode(x86-64)
gearhead2-SDL: application() application(gearhead2-sdl.desktop) gearhead2-SDL gearhead2-SDL(x86-64) gearhead2-bin(x86-64) metainfo() metainfo(gearhead2-sdl.appdata.xml)
gearhead2-data: gearhead2-data
gearhead2-data-gfx: gearhead2-data-gfx
gearhead2-debuginfo: gearhead2-debuginfo gearhead2-debuginfo(x86-64)
gearhead2-debugsource: gearhead2-debugsource gearhead2-debugsource(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2098373 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, Python, Haskell, R, Java, C/C++, PHP, SugarActivity, fonts, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments: 1) Excluded architecture ARM-hfp https://fedoraproject.org/wiki/Architectures#Primary_Architectures seems ok due to Free Pascal support https://src.fedoraproject.org/rpms/fpc/blob/rawhide/f/fpc.spec 2) May want to have the history.txt file in the documentation 3) Should the testing program cosplay2 also be packaged? It is not necessary, but may help users check system functionality for game support.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Artur Frenszek-Iwicki fedora@svgames.pl ---
Should the testing program cosplay2 also be packaged? It is not necessary, but may help users check system functionality for game support.
I looked into this and it seems to me that cosplay2 is just part of the main executable (i.e. a sub-menu), not a separate program. So I guess the README is a bit outdated.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Programs seems to run. May want to package the doc directory https://github.com/jwvhewitt/gearhead-2/tree/master/doc
Some linting messages below. Incorrect address might be something that can be fixed upstream. Is it possible to generate a PIC executable? What about the statically linked errors?
$ rpmlint gearhead2-0.701-1.20201130git86d17e1.fc36.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2.spec:151: W: mixed-use-of-spaces-and-tabs (spaces: line 151, tab: line 147) 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 1.7 s
$ rpmlint gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2.x86_64: W: no-documentation gearhead2.x86_64: E: no-binary 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.3 s
$ rpmlint gearhead2-data-0.701-1.20201130git86d17e1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-data.noarch: E: incorrect-fsf-address /usr/share/licenses/gearhead2-data/license.txt gearhead2-data.noarch: W: files-duplicate /usr/share/gearhead2/series/ARENAMISSION_Police.txt /usr/share/gearhead2/series/ARENAMISSION_Criminal.txt 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 0.8 s
$ rpmlint gearhead2-data-gfx-0.701-1.20201130git86d17e1.fc37.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-data-gfx.noarch: W: no-documentation gearhead2-data-gfx.noarch: W: dangling-symlink /usr/share/gearhead2/image/VeraBd.ttf /usr/share/fonts/bitstream-vera-sans-fonts/VeraBd.ttf gearhead2-data-gfx.noarch: W: dangling-symlink /usr/share/gearhead2/image/VeraMoBd.ttf /usr/share/fonts/bitstream-vera-sans-mono-fonts/VeraMoBd.ttf 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 1.0 s
$ rpmlint gearhead2-debuginfo-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64 gearhead2-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64 gearhead2-debuginfo.x86_64: W: no-documentation gearhead2-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64 gearhead2-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz gearhead2-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz 1 packages and 0 specfiles checked; 2 errors, 4 warnings, 2 badness; has taken 0.7 s
$ rpmlint gearhead2-debugsource-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-debugsource.x86_64: W: no-documentation gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ability.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/aibrain.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/arenacfe.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/arenaplay.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/backpack.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/chargen.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/colormenu.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/customization.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/description.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gearhead2.pas gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gearparser.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gears.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gearutil.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghchars.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghguard.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghholder.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghintrinsic.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghmecha.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghmovers.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghsensor.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghswag.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghweapon.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/grabgear.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/infodisplay.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/locale.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/menugear.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/minigame.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/minitype.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/mpbuilder.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/narration.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/navigate.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/pcaction.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/robotics.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/rpgdice.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlgfx.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlinfo.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlmap.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlmenus.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/services.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/specialsys.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/targetui.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/texutil.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/training.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ui4gh.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidgfx.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidinfo.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidmap.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidmenus.pp gearhead2-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/wmonster.pp 1 packages and 0 specfiles checked; 49 errors, 1 warnings, 49 badness; has taken 0.5 s
$ rpmlint gearhead2-SDL-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-SDL.x86_64: W: position-independent-executable-suggested /usr/bin/gearhead2-sdl gearhead2-SDL.x86_64: W: no-manual-page-for-binary gearhead2-sdl gearhead2-SDL.x86_64: W: no-documentation gearhead2-SDL.x86_64: W: description-shorter-than-summary 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 249.9 s
$ rpmlint gearhead2-SDL-debuginfo-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-SDL-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/gearhead2-sdl-0.701-1.20201130git86d17e1.fc37.x86_64.debug gearhead2-SDL-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/usr/bin/gearhead2-sdl-0.701-1.20201130git86d17e1.fc37.x86_64.debug gearhead2-SDL-debuginfo.x86_64: W: position-independent-executable-suggested /usr/lib/debug/usr/bin/gearhead2-sdl-0.701-1.20201130git86d17e1.fc37.x86_64.debug gearhead2-SDL-debuginfo.x86_64: W: no-documentation gearhead2-SDL-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/40/b443ec0cf04cab227195f3de43ed190c145ab0 ../../../.build-id/40/b443ec0cf04cab227195f3de43ed190c145ab0 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 34.3 s
$ rpmlint gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-textmode.x86_64: E: statically-linked-binary /usr/bin/gearhead2-textmode gearhead2-textmode.x86_64: W: position-independent-executable-suggested /usr/bin/gearhead2-textmode gearhead2-textmode.x86_64: W: no-manual-page-for-binary gearhead2-textmode gearhead2-textmode.x86_64: W: no-documentation gearhead2-textmode.x86_64: W: description-shorter-than-summary 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 2.5 s
$ rpmlint gearhead2-textmode-debuginfo-0.701-1.20201130git86d17e1.fc37.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
gearhead2-textmode-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.debug gearhead2-textmode-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/usr/bin/gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.debug gearhead2-textmode-debuginfo.x86_64: W: position-independent-executable-suggested /usr/lib/debug/usr/bin/gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.debug gearhead2-textmode-debuginfo.x86_64: W: no-documentation gearhead2-textmode-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/68/24ce97de3eea44232e005c4d799fddbf11b7be ../../../.build-id/68/24ce97de3eea44232e005c4d799fddbf11b7be 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 1.1 s
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- doc directory is packaged within data, so this is ok.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #5 from Artur Frenszek-Iwicki fedora@svgames.pl ---
What about the statically linked errors?
It's a false positive. FPC has its own low-level interface and doesn't rely on libc, so a pure-Pascal program that doesn't use any external libraries won't link against anything - which is exactly the case with the "textmode" build of the game.
Is it possible to generate a PIC executable?
Yes, FPC has an option for generatic PIC code. I don't think I've used it when packaging any other Pascal programs, though.
Incorrect address might be something that can be fixed upstream.
Submitted a patch: https://github.com/jwvhewitt/gearhead-2/pull/18
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #6 from Benson Muite benson_muite@emailplus.org --- Maybe helpful to try generate PIC code. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gearhead2
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d89d89b017 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d89d89b017
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3d0a882df8 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3d0a882df8
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-6122fd72b6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6122fd72b6
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d89d89b017 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d89d89b017 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d89d89b017
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3d0a882df8 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3d0a882df8 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3d0a882df8
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-6122fd72b6 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6122fd72b6 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6122fd72b6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-09-01 09:40:18
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3d0a882df8 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-6122fd72b6 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d89d89b017 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com