[Bug 714047] New: Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format - package-review

List overview All Threads
Download

newer

[Bug 714047] New: Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

older

[Bug 225645] New: Merge Review:...

[Bug 576272] New: Review Request:...

Red Hat Bugzilla

17 Jun 2011 17 Jun '11

8:44 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Summary: Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sanjay.ankur@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---

Spec URL: http://ankursinha.fedorapeople.org/nifticlib/nifticlib.spec SRPM URL: http://ankursinha.fedorapeople.org/nifticlib/nifticlib-2.0.0-1.fc15.src.rpm

Description: Nifticlib is a set of C i/o libraries for reading and writing files in the nifti-1 data format. nifti-1 is a binary file format for storing medical image data, e.g. magnetic resonance image (MRI) and functional MRI (fMRI) brain images.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

17 Jun 17 Jun

8:46 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #1 from Ankur Sinha sanjay.ankur@gmail.com 2011-06-17 04:46:17 EDT --- [ankur@ankur SRPMS]$ rpmlint ../SPECS/nifticlib.spec nifticlib-2.0.0-1.fc15.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/nifticlib.spec:53: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/* ../SPECS/nifticlib.spec:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/ ../SPECS/nifticlib.spec: W: invalid-url Source0: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz HTTP Error 404: Not Found nifticlib.src: W: spelling-error Summary(en_US) nifti -> nifty nifticlib.src: W: spelling-error %description -l en_US nifti -> nifty nifticlib.src: W: spelling-error %description -l en_US fMRI -> MRI, f MRI, firm nifticlib.src:53: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/* nifticlib.src:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/ nifticlib.src: W: invalid-url Source0: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz HTTP Error 404: Not Found nifticlib.i686: W: spelling-error Summary(en_US) nifti -> nifty nifticlib.i686: W: spelling-error %description -l en_US nifti -> nifty nifticlib.i686: W: spelling-error %description -l en_US fMRI -> MRI, f MRI, firm nifticlib.i686: W: no-manual-page-for-binary nifti_stats nifticlib.i686: W: no-manual-page-for-binary nifti_tool nifticlib.i686: W: no-manual-page-for-binary nifti1_test nifticlib.src: W: spelling-error Summary(en_US) nifti -> nifty nifticlib.src: W: spelling-error %description -l en_US nifti -> nifty nifticlib.src: W: spelling-error %description -l en_US fMRI -> MRI, f MRI, firm nifticlib.src:53: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/* nifticlib.src:54: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/ nifticlib.src: W: invalid-url Source0: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz HTTP Error 404: Not Found nifticlib-devel.i686: W: no-documentation 6 packages and 1 specfiles checked; 6 errors, 16 warnings.

The errors are irrelevant here.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:55 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Ankur Sinha sanjay.ankur@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |nifticlib

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

18 Jun 18 Jun

6:03 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Ankur Sinha sanjay.ankur@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |714328(xmedcon)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

26 Jul 26 Jul

2:18 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Richard W.M. Jones rjones@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:20 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #2 from Richard W.M. Jones rjones@redhat.com 2011-07-26 10:20:17 EDT --- Package source matches upstream:

$ sha1sum ../nifticlib-2.0.0.tar.gz nifticlib-2.0.0.tar.gz 3a6187cb09767f97cef997cf492d89ac3db211df ../nifticlib-2.0.0.tar.gz 3a6187cb09767f97cef997cf492d89ac3db211df nifticlib-2.0.0.tar.gz

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:25 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #3 from Richard W.M. Jones rjones@redhat.com 2011-07-26 10:25:39 EDT --- Source0 URL is WRONG:

WRONG: http://downloads.sourceforge.net/nifticlib/nifticlib-2.0.0.tar.gz Right: http://downloads.sourceforge.net/niftilib/nifticlib-2.0.0.tar.gz

Try 'wget'-ing both URLs.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:26 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #4 from Richard W.M. Jones rjones@redhat.com 2011-07-26 10:26:05 EDT --- Koji scratch build worked: http://koji.fedoraproject.org/koji/taskinfo?taskID=3231346

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:27 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #5 from Richard W.M. Jones rjones@redhat.com 2011-07-26 10:27:40 EDT --- I agree that the other rpmlint warnings can be ignored, including the one about /usr/lib which is bogus.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:34 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #6 from Richard W.M. Jones rjones@redhat.com 2011-07-26 10:34:01 EDT --- + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm + package successfully builds on at least one architecture n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + consistent use of macros + package must contain code or permissible content + large documentation files should go in -doc subpackage + files marked %doc should not affect package + header files should be in -devel n/a static libraries should be in -static + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' + libfoo.so must go in -devel + -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file n/a packages must not own files or directories owned by other packages + filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock ? the package should build into binary RPMs on all supported architectures ? review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

Package is not approved. Please just fix the Source URL.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:22 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #7 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-26 11:22:25 EDT --- Corrected:

Fresh srpm/spec:

http://ankursinha.fedorapeople.org/nifticlib/nifticlib.spec

http://ankursinha.fedorapeople.org/nifticlib/nifticlib-2.0.0-2.fc15.src.rpm

Thank you for the *quick* review Richard! Ankur

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:19 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Richard W.M. Jones rjones@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+

--- Comment #8 from Richard W.M. Jones rjones@redhat.com 2011-07-26 12:19:48 EDT --- Looks good.

-----------------

This package is APPROVED by rjones

-----------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:30 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #9 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-26 12:30:55 EDT --- Thank you Richard!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:32 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Ankur Sinha sanjay.ankur@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #10 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-26 12:32:03 EDT --- New Package SCM Request ======================= Package Name: nifticlib Short Description: A set of i/o libraries for reading and writing files in the nifti-1 data format Owners: ankursinha Branches: f14 f15 InitialCC: susmit mrceresa

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:08 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #11 from Jon Ciesla limb@jcomserv.net 2011-07-26 13:08:45 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:45 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:45 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-07-26 13:45:37 EDT --- nifticlib-2.0.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nifticlib-2.0.0-2.fc15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:46 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-07-26 13:46:18 EDT --- nifticlib-2.0.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nifticlib-2.0.0-2.fc14

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:48 p.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Ankur Sinha sanjay.ankur@gmail.com changed:

--- Comment #14 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-26 13:48:03 EDT --- Built for rawhide and pushed to f14 f15 for testing. Closing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Aug 17 Aug

12:57 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-08-16 20:57:30 EDT --- nifticlib-2.0.0-2.fc14 has been pushed to the Fedora 14 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:57 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:22 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-08-16 21:22:46 EDT --- nifticlib-2.0.0-2.fc15 has been pushed to the Fedora 15 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:22 a.m.

New subject: [Bug 714047] Review Request: nifticlib - A set of i/o libraries for reading and writing files in the nifti-1 data format

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=714047

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nifticlib-2.0.0-2.fc14 |nifticlib-2.0.0-2.fc15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4701

Age (days ago)

4762

Last active (days ago)

package-review@lists.fedoraproject.org

22 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla